From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753101AbbJOPFG (ORCPT ); Thu, 15 Oct 2015 11:05:06 -0400 Received: from mout.kundenserver.de ([212.227.126.187]:49769 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751302AbbJOPFC (ORCPT ); Thu, 15 Oct 2015 11:05:02 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Hannes Reinecke , linux-scsi@vger.kernel.org, JBottomley@odin.com, linux-kernel@vger.kernel.org Subject: Re: [PATCH] scsi: advansys needs ISA dma api for ISA support Date: Thu, 15 Oct 2015 17:04:50 +0200 Message-ID: <8749889.aUxSEGWaCq@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <561F977B.1030009@suse.de> References: <5081546.QjQ32dGX2L@wuerfel> <561F96B7.4050300@suse.de> <561F977B.1030009@suse.de> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:SIzE22fP63Gg9lo+sz2Ww5EAC1KQYlFdRnB0Vp9g6WmHaDT3+hr n/YeMn3ty2Rn8CEFACcxng1CGk7G7iJCT/4jixik20p+nrn7yufVALBhPn21wHYIZlt9af9 lFwxw0Y+oZD1RFuGcUBq61SS2iYg6cYcWbmIc/EnS12rQV+Z2EivdTOluS71wDdFQ0bLWfj fBLnAeo91s0Li81Hm8IMA== X-UI-Out-Filterresults: notjunk:1;V01:K0:Y44WhHSJ9yk=:hld51nHl4hmgECz/QGVU4W 6yWQjr1tyflQqfyHTFe097PtqTDPxKbV2CXEsum+eh+xr3XbqxlOYQP5/Y+E0LkVYWmC1Uw+B oMaWNrCNyZT54gVA4CxUzxv345/2/d7D+drmAr6cGthEgCIcQP70YErrV9d8P7ba0knNivuNA RPc2GUZIl8NcUbuxRkt76FF+RPxNANfgsqq97jRJrAtnPElqWP7rIvoRLkG/e4de65BGoPn3Y rupjHUgZeO16GW14iO4XeIQNYVWzT4QF3ygoaq619cs3Hr43xzy3wOMd9kwrvK3xfILyb/0LQ 7PgR2PPW+QB43XS6yhiGh+7fkbwno5cU/74NrSAuIHRBRUA0yiAzSkgNqISLtG1TGpP2DgpLr fvwk1z2c8vSDNJbO2gaSUfe0XyatPcTuaro7J9Sl7E9XuWGaoyef1UXNAtyWSYufHxQaM00P+ DoWTTx88UccNLfNdfT9lLyiAAnH6LvhBTV1ZIjxLMsYKAiGY6u7uLsAxqtjIG/kUl15bAISRS cxeD69WDnrUWb8bG2awr7mUT3YswjKQpPlc4Y/zzy7EfAWImFKNF4eBg2W9YVz7Ilv7a+SRRm 64uptM+e9komY2Si85FkciAiGE5VWdtpPY5j5pRkV264Q+CT9kJuFhXiJfGtLp/aegAuxWFa0 doapv7i+fJLroZ90/tP26iH3QDYf8+lE7CxeWV31lE3HL3TnQ3ALyBD1q22Cj4cLix3qeju9K T5h1Z8qr48QY7kAE Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 15 October 2015 14:09:31 Hannes Reinecke wrote: > On 10/15/2015 02:06 PM, Hannes Reinecke wrote: > > On 10/12/2015 05:10 PM, Arnd Bergmann wrote: > >> diff --git a/drivers/scsi/Kconfig b/drivers/scsi/Kconfig > >> index d2f480b04a52..d4aa6a1a806c 100644 > >> --- a/drivers/scsi/Kconfig > >> +++ b/drivers/scsi/Kconfig > >> @@ -499,6 +499,7 @@ config SCSI_ADVANSYS > >> tristate "AdvanSys SCSI support" > >> depends on SCSI > >> depends on ISA || EISA || PCI > >> + depends on ISA_DMA_API || !ISA > >> help > >> This is a driver for all SCSI host adapters manufactured by > >> AdvanSys. It is documented in the kernel source in > >> > > Sorry to chime in again, but wouldn't this allow to build on platforms > > which have neither ISA_DMA_API nor ISA, like oldish sparc systems with > > proprietary S-BUS? No, the first dependency is still in place. It could also be written as depends on (ISA && ISA_DMA_API) || EISA || PCI which might be easier to understand. Do you want me to resubmit it like that? > > Why not ISA_DMA_API || EISA || PCI ? That would indeed make it possible to enable it on ancient systems that have none of ISA, EISA or PCI but still support ISA_DMA_API, e.g. for a floppy controller. A theoretical downside is that a system with a PCI advansys adapter and ISA slots but no ISA_DMA_API would not be able to build this. As far as I know, such a system does not exist. > Gnaa. Ignore this. > > Mailer got confused about which mails are more recent than others Just to make sure we are on the same page: James thought my second patch was making things too ugly and wanted to get back to this one. Arnd