From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751274AbdAMI2h (ORCPT ); Fri, 13 Jan 2017 03:28:37 -0500 Received: from mx0a-001b2d01.pphosted.com ([148.163.156.1]:32982 "EHLO mx0a-001b2d01.pphosted.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751181AbdAMI2g (ORCPT ); Fri, 13 Jan 2017 03:28:36 -0500 Subject: Re: [PATCH] virtio-crypto: adjust priority of algorithm To: Gonglei , virtualization@lists.linux-foundation.org, linux-crypto@vger.kernel.org, linux-kernel@vger.kernel.org References: <1484288741-31100-1-git-send-email-arei.gonglei@huawei.com> Cc: mst@redhat.com, herbert@gondor.apana.org.au From: Christian Borntraeger Date: Fri, 13 Jan 2017 09:28:29 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.6.0 MIME-Version: 1.0 In-Reply-To: <1484288741-31100-1-git-send-email-arei.gonglei@huawei.com> Content-Type: text/plain; charset=iso-8859-15 Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 X-Content-Scanned: Fidelis XPS MAILER x-cbid: 17011308-0016-0000-0000-0000059FDEE5 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00006424; HX=3.00000240; KW=3.00000007; PH=3.00000004; SC=3.00000199; SDB=6.00807006; UDB=6.00392783; IPR=6.00584338; BA=6.00005052; NDR=6.00000001; ZLA=6.00000005; ZF=6.00000009; ZB=6.00000000; ZP=6.00000000; ZH=6.00000000; ZU=6.00000002; MB=3.00013909; XFM=3.00000011; UTC=2017-01-13 08:28:33 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 17011308-0017-0000-0000-000036390542 Message-Id: <874ee338-4dd6-8a2c-fb95-59bd784de026@de.ibm.com> X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10432:,, definitions=2017-01-13_05:,, signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 suspectscore=0 malwarescore=0 phishscore=0 adultscore=0 bulkscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1612050000 definitions=main-1701130119 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org ACK. Whoever takes this patch might want to fixup 3 typos. On 01/13/2017 07:25 AM, Gonglei wrote: > Some hardware accelerators (like intel aseni or the s390 aesni > cpacf functions) have lower priorities than virtio > crypto, and those drivers are faster than the same in > the host via virtio. So let's lower the priority of > virtio-crypto's algorithm, make it's higher than sofeware software > implimentations but lower than the hardware ones. implementations > > Suggested-by: Christian Borntraeger > Signed-off-by: Gonglei > --- > drivers/crypto/virtio/virtio_crypto_algs.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/crypto/virtio/virtio_crypto_algs.c b/drivers/crypto/virtio/virtio_crypto_algs.c > index 6f40a42..4de4740 100644 > --- a/drivers/crypto/virtio/virtio_crypto_algs.c > +++ b/drivers/crypto/virtio/virtio_crypto_algs.c > @@ -498,7 +498,7 @@ void virtio_crypto_ablkcipher_finalize_req( > static struct crypto_alg virtio_crypto_algs[] = { { > .cra_name = "cbc(aes)", > .cra_driver_name = "virtio_crypto_aes_cbc", > - .cra_priority = 501, > + .cra_priority = 150, > .cra_flags = CRYPTO_ALG_TYPE_ABLKCIPHER | CRYPTO_ALG_ASYNC, > .cra_blocksize = AES_BLOCK_SIZE, > .cra_ctxsize = sizeof(struct virtio_crypto_ablkcipher_ctx), >