From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtpout-02.galae.net (smtpout-02.galae.net [185.246.84.56]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C7193EAC80 for ; Tue, 25 Aug 2026 09:09:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=185.246.84.56 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787648958; cv=none; b=WFojPnXjziZqMHsl2WBRwgdaBokImUbxlb4j/KH/ipb+eGfKmssi7j7VTd87wLstgGas2qAWKPNG7z+Ngh3ItX7FhP3Cg7tgrGvFAWaeAiBMXl3x53MdmSrW/X3xbuKuwq7i3M/a1yDk4jFQKCueBLKxPbJLImRZNfO/KfKGy9s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1787648958; c=relaxed/simple; bh=CzFv5pMa4H11oivFa/CKd7sBXFEXF+bEaltU0iUJA7o=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=qJ4qsXxnWQZUZscHNgmVos5XcGffBEzFWs2i1YaQTQnPrwUe6Vig1ror2AY/jT2U1yeRdGYqZAIiFwVCGzr/c9DZ4eXLwv73vqIcQlz8Ka2a8vPTQo+/Cddmtw8TLskbVtZORc1dmDcbxG3hIUhHdeA58DwMGPv0Jxg7f9d1p+E= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com; spf=pass smtp.mailfrom=bootlin.com; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b=A5of0bdA; arc=none smtp.client-ip=185.246.84.56 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=bootlin.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=bootlin.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bootlin.com header.i=@bootlin.com header.b="A5of0bdA" Received: from smtpout-01.galae.net (smtpout-01.galae.net [212.83.139.233]) by smtpout-02.galae.net (Postfix) with ESMTPS id C40CC1A1766; Tue, 25 Aug 2026 09:09:12 +0000 (UTC) Received: from mail.galae.net (mail.galae.net [212.83.136.155]) by smtpout-01.galae.net (Postfix) with ESMTPS id 96F1C604C4; Tue, 25 Aug 2026 09:09:12 +0000 (UTC) Received: from [127.0.0.1] (localhost [127.0.0.1]) by localhost (Mailerdaemon) with ESMTPSA id 396CB11C7A247; Tue, 25 Aug 2026 11:09:04 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bootlin.com; s=dkim; t=1787648948; h=from:subject:date:message-id:to:cc:mime-version:content-type: content-transfer-encoding:in-reply-to:references; bh=Elys4dNv6mqSI4zLl4ODog5miDdDALJ+akBka8bjTnM=; b=A5of0bdADpnmAu5Ugp7H77N3jL3Ky4XLopUo5WtD2WJsCS/Ga1fA9+AMhix/LwG+67GYiD pWW1PA6r768rgprxS7/u8dmqGollAG+V1Xg9XDCWG6tKDI34fvikiOQDzEF5vdEH6eDmQn EVayH1JAU7xOO4X+NGJbe6xl5AsxfO2qadJIitM4wgud97Z0NJGgP/0GinSMOg7O4qtq4y u3mDOFLAYmsyIVStDo2x9RYwYRB1xRqoqYOdG/6ng9OA/y16iBQrP06j6EY9/lvaewDDgp XPrLhSlHHvywjAsw6CGLvQuwvBUZz7aXQqdeqgGHGzgFGnWdXvfIfxG1ZIlMMQ== From: Miquel Raynal To: Huasin Liao Cc: asmadeus@codewreck.org, vigneshr@ti.com, richard@nod.at, tudor.ambarus@linaro.org, linux-kernel@vger.kernel.org, linux-mtd@lists.infradead.org, huasin.liao@airoha.com Subject: Re: [PATCH] mtd: spinand: winbond: add support for W25N04LV In-Reply-To: <20260816165614.16262-1-huasinliao@gmail.com> (Huasin Liao's message of "Mon, 17 Aug 2026 00:56:14 +0800") References: <20260816165614.16262-1-huasinliao@gmail.com> User-Agent: mu4e 1.12.12; emacs 30.2 Date: Tue, 25 Aug 2026 11:09:03 +0200 Message-ID: <874igik1n4.fsf@bootlin.com> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Last-TLS-Session-Version: TLSv1.3 >>> +static const struct mtd_ooblayout_ops w25n04lv_ooblayout =3D { >>> + .ecc =3D w25n04lv_ooblayout_ecc, >>> + .free =3D w25n04lv_ooblayout_free, >>=20 >> FWIW, these two are the same as what I consolidated in >> https://lore.kernel.org/r/20260814-w25n04lw-v3-1-c6a7423ac7d0@atmark-tec= hno.com >> using oobsize, so we probably want to reuse that here too > > Thanks for the pointer, and good to see Miquel is fine with reusing > w25n02kv_ooblayout. Once your patch lands, I'll rebase on top of it > and switch from w25n04lv_ooblayout to w25n02kv_ooblayout =E2=80=94 is tha= t in > line with what you'd expect? I guess so, thanks! Miqu=C3=A8l