From: Takashi Iwai <tiwai@suse.de>
To: "Cássio Gabriel" <cassiogabrielcontato@gmail.com>
Cc: Takashi Iwai <tiwai@suse.com>, Jaroslav Kysela <perex@perex.cz>,
linux-sound@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: usx2y: Drain pending US-428 pipe-4 output commands
Date: Tue, 19 May 2026 08:10:36 +0200 [thread overview]
Message-ID: <874ik43p5v.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260519-alsa-usx2y-p4out-drain-v1-1-8f0a4550bae2@gmail.com>
On Tue, 19 May 2026 05:20:41 +0200,
Cássio Gabriel wrote:
>
> The US-428 pipe-4 output path submits at most one pending p4out
> entry from the shared-memory ring per input interrupt. If userspace
> queues more than one command before the interrupt handler runs, later
> commands remain pending until later input interrupts, even when async
> pipe-4 URBs are available.
>
> Drain pending entries while idle async URBs are available. Copy each
> command into the existing per-URB async buffer before submission, so the
> submitted transfer does not depend on a userspace-mapped ring slot
> remaining unchanged after p4out_sent is advanced.
>
> Also update p4out_sent only after usb_submit_urb() succeeds, so a
> failed submission is not reported as sent.
>
> This keeps the shared-memory ABI unchanged and fixes only the local
> queue-draining behavior.
>
> Signed-off-by: Cássio Gabriel <cassiogabrielcontato@gmail.com>
Applied to for-next branch. Thanks.
Takashi
prev parent reply other threads:[~2026-05-19 6:10 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-19 3:20 Cássio Gabriel
2026-05-19 6:10 ` Takashi Iwai [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874ik43p5v.wl-tiwai@suse.de \
--to=tiwai@suse.de \
--cc=cassiogabrielcontato@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sound@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®