From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 2240E1A8F93 for ; Tue, 31 Dec 2024 17:03:39 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735664621; cv=none; b=QHZQPz7blStP8HGiOseo7xm3cdYNlNLdi79/gE2Q7P0pjxCLRfNh4SXgLE4D1y119towM8ZHy8mO/UoE5hQTg23lQ0XvXq3dXaKufwDfOb8hZyuPViioHoOFxcKGlRoO0SdQguqEQkC82y9h35YQy8xhMiYd1o/OmaFr5PbCpk0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1735664621; c=relaxed/simple; bh=mfYF/iCg1e00q3XktSV4Cu+sANcJYzDDgGUTDGzFGaY=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=WTzAIOc4kS4c8M1KBH6NQcezk99HJf35qegYnGNQiAnDNZd0VNdOIXPF/rAu/DmY+SEn8rIuQ6kWV5KvmHSQ8PrP91IlB0CjAJZuqxOO4WwiQZaL/dlttX5gdwmaPGfG2DjW30Z05O8qSjo0ncemXjOIfbDGCi1KQsIaS9wBEPY= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=alNIIuWw; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="alNIIuWw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1735664619; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=OMQDKUUk1foYPBKNxPEyaAlDK3T3xpWOx3kaLhclbuU=; b=alNIIuWwfoxvy5HPyGjR7zJYmkv4TxMcdgh1tbPkEyECiqVPCYbN+TQyLqCiK19Scnl9r1 YXaqwUlLQ4q5fX1CYwqHL8qWcaxDspNJrhEP9WIbpeeq+afEYMnZc23yU1sIWHQL+tsuYn Ddc2wk46yuiEl8Wmi2td02+eGE7QC5g= Received: from mail-wm1-f71.google.com (mail-wm1-f71.google.com [209.85.128.71]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-672-H4mg_C7aO6OrxmOYCYdxCQ-1; Tue, 31 Dec 2024 12:03:37 -0500 X-MC-Unique: H4mg_C7aO6OrxmOYCYdxCQ-1 X-Mimecast-MFC-AGG-ID: H4mg_C7aO6OrxmOYCYdxCQ Received: by mail-wm1-f71.google.com with SMTP id 5b1f17b1804b1-4362b9c15d8so54855465e9.3 for ; Tue, 31 Dec 2024 09:03:37 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1735664616; x=1736269416; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=OMQDKUUk1foYPBKNxPEyaAlDK3T3xpWOx3kaLhclbuU=; b=tAfeOq9kEhbePJ9kuCabv2ftC76fC9b/cbN84O46rNL2iOji5LQfEj2Wqzu7HqEzP/ gIb5yGdV+Ec3BPjImAq9Wdpd1oS6o/hnVGHQxQrp0zIdxUnZK/DDYorK5q9nW73hq7d2 g6+5ktjOoxyDUnyVtUq3bwpSgTAKnXa+NTb17j3opTSaKN/N3caUsIVOK+UeAzBULwoK DXHXZr70l+UzbWbh40bfaLoDIgB7Cx2gyG0PGskTmB/r3FS0kxMcBXZMoQWQ/MB2D0jp NX9JdAzueVYnPt1ZdSL74/ADDhsT1qTyC0AxRXTGFoGrCu1Zj34FGiyV4pSsWb6JcWID Ypsw== X-Gm-Message-State: AOJu0YxNTQ97/wVvU4th3w7MM2EWfysRBAFX6eK3HbP489oh3qJJT1NP c+JQtktjMngl4uZIpMKS73UrmVt2dMKBY4kx4px/5WnpPAt7sB5sikYT3r9jQZt4oPd/3u2MAP0 gnG/ylOySRKeOe/2QZ77m7XRLWeIhA9neww3FSHXmyWKwfxoOy4NlR14GYikipg== X-Gm-Gg: ASbGncuvsgvFCCxahaCEwcJou1HuEihaaD5m8ZmNAtLuhRBCQ/CJni35BuKyTc5Z5Yr TduuwhDQUzSJNxKEQ8+oZQfiKlaG7I7HXR4R9vxsa3vOnkwo5LRKt/kJFRYmONuite1ZyaleLxh orcKyceQ2L2jjDU2XLHcX/3m6H9lbUOtpNZ4p2+8P6m3M13CY0FrZ6NywksMEGFy2ix7fQpAzhx cBO8keqXXSERlHl0FLnWrEHTvudMz+PjGydbGyquGOVKvm0P/MU9CpHOh1RoRqMMAzdjRIjjZjF 0Bp4p+/moTd4lBZey1q9c7EN87Pg+Jy3h+U6FWs= X-Received: by 2002:a05:600c:3b23:b0:434:9499:9e87 with SMTP id 5b1f17b1804b1-43668b5e194mr292785845e9.25.1735664616297; Tue, 31 Dec 2024 09:03:36 -0800 (PST) X-Google-Smtp-Source: AGHT+IEo4cjoNHNIV6MdPiesoFX2rukT4UJRgCNEULiJwNuJ5T53/oG30mZuQu0l6CZLCxyFn7x9rA== X-Received: by 2002:a05:600c:3b23:b0:434:9499:9e87 with SMTP id 5b1f17b1804b1-43668b5e194mr292785515e9.25.1735664615924; Tue, 31 Dec 2024 09:03:35 -0800 (PST) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-38a1c8474c2sm32808596f8f.55.2024.12.31.09.03.34 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Tue, 31 Dec 2024 09:03:35 -0800 (PST) From: Javier Martinez Canillas To: Dmitry Baryshkov Cc: linux-kernel@vger.kernel.org, Mark Brown , David Airlie , Maarten Lankhorst , Maxime Ripard , Simona Vetter , Thomas Zimmermann , dri-devel@lists.freedesktop.org Subject: Re: [PATCH] drm/ssd130x: Set SPI .id_table to prevent an SPI core warning In-Reply-To: References: <20241231114516.2063201-1-javierm@redhat.com> <877c7fkgs5.fsf@minerva.mail-host-address-is-not-set> Date: Tue, 31 Dec 2024 18:03:34 +0100 Message-ID: <874j2jkcnt.fsf@minerva.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Dmitry Baryshkov writes: > On Tue, Dec 31, 2024 at 04:34:34PM +0100, Javier Martinez Canillas wrote: >> Dmitry Baryshkov writes: >> >> Hello Dmitry, >> >> > On Tue, Dec 31, 2024 at 12:44:58PM +0100, Javier Martinez Canillas wrote: > > [...] > >> >> Since the check is done even for built-in drivers, drop the condition to >> >> only define the ID table when the driver is built as a module. Finally, >> >> rename the variable to use the "_spi_id" convention used for ID tables. >> >> >> >> Signed-off-by: Javier Martinez Canillas >> > >> > Fixes: 74373977d2ca ("drm/solomon: Add SSD130x OLED displays SPI support") >> > >> >> I was on the fence about adding a Fixes: tag due a) the issue being there >> from the beginning as you pointed out and b) the warning being harmless. >> >> But I'll add it to v2 or just before pushing it to drm-misc-next. > > Just before pushing is enough. dim b4-shazam can do that for you. > Yeah, I meant in case that I post a v2. I'll wait a few days before pushing in case someone else chimes in. Thanks again! -- Best regards, Javier Martinez Canillas Core Platforms Red Hat