From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A114E7D0AB for ; Thu, 21 Sep 2023 21:51:17 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232122AbjIUVvV (ORCPT ); Thu, 21 Sep 2023 17:51:21 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34454 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232921AbjIUVvC (ORCPT ); Thu, 21 Sep 2023 17:51:02 -0400 Received: from smtp-out2.suse.de (smtp-out2.suse.de [195.135.220.29]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ADE7989209 for ; Thu, 21 Sep 2023 10:39:36 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out2.suse.de (Postfix) with ESMTPS id E6C00207B4; Thu, 21 Sep 2023 06:24:45 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1695277485; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fzevEupZOeMHULGlXmrBX0p1fGc8/puuPIGI/o6Y7cE=; b=iLBQaTiG9lomdXbN6oRdohF/3ihI7lAKIL/UZMlplOETUIpTchesZAbkdhUJ5e+ldZ17Vl F801yQXtSZkmoyPOxVkeSZ4wX0zQqiFgeXYzTlzjwcSNcwaKaGR/r/v1HyZtNaFEB4l2Nn pnRpx+02OS+oykzQ/DVz23SHK6CfzxE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1695277485; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=fzevEupZOeMHULGlXmrBX0p1fGc8/puuPIGI/o6Y7cE=; b=JApG9Tmmlr90NzfHH5hmXAet2Dya5Fh8ddrG0JGh8j9kfMyzIm91qxwRX8P5qSBQAV5n0X IL9KypAHrHM6d/BQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id BE061134B0; Thu, 21 Sep 2023 06:24:45 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id TnFiLa3hC2XIWAAAMHmgww (envelope-from ); Thu, 21 Sep 2023 06:24:45 +0000 Date: Thu, 21 Sep 2023 08:24:46 +0200 Message-ID: <874jjoujpt.wl-tiwai@suse.de> From: Takashi Iwai To: Abby Ricart Cc: linux-kernel@vger.kernel.org, perex@perex.cz, tiwai@suse.com, alsa-devel@alsa-project.org Subject: Re: [PATCH] ALSA: hda/realtek: Add quirk for ASUS ROG G533Q In-Reply-To: References: User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 20 Sep 2023 18:28:42 +0200, Abby Ricart wrote: > > The same quirk applied to the ASUS G533Z is also applicable to the ASUS > G533Q (of which I am an owner and have thus tested). > > Signed-off-by: Abelardo Ricart The patch can't be applied cleanly. Please fix your mailer setup not to break spaces and resubmit. thanks, Takashi > --- > diff --git a/sound/pci/hda/patch_realtek.c b/sound/pci/hda/patch_realtek.c > index b7e78bfcffd8..7bb3c1e05bf2 100644 > --- a/sound/pci/hda/patch_realtek.c > +++ b/sound/pci/hda/patch_realtek.c > @@ -9781,6 +9781,7 @@ static const struct snd_pci_quirk alc269_fixup_tbl[] = { > SND_PCI_QUIRK(0x1043, 0x1493, "ASUS GV601V", ALC285_FIXUP_ASUS_HEADSET_MIC), > SND_PCI_QUIRK(0x1043, 0x1517, "Asus Zenbook UX31A", > ALC269VB_FIXUP_ASUS_ZENBOOK_UX31A), > SND_PCI_QUIRK(0x1043, 0x1573, "ASUS GZ301V", ALC285_FIXUP_ASUS_HEADSET_MIC), > + SND_PCI_QUIRK(0x1043, 0x1602, "ASUS ROG Strix G15 (G533Q)", > ALC285_FIXUP_ASUS_G533Z_PINS), > SND_PCI_QUIRK(0x1043, 0x1662, "ASUS GV301QH", ALC294_FIXUP_ASUS_DUAL_SPK), > SND_PCI_QUIRK(0x1043, 0x1683, "ASUS UM3402YAR", ALC287_FIXUP_CS35L41_I2C_2), > SND_PCI_QUIRK(0x1043, 0x16b2, "ASUS GU603", ALC289_FIXUP_ASUS_GA401), >