From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 35F43CD343F for ; Tue, 19 Sep 2023 06:37:05 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229821AbjISGhJ (ORCPT ); Tue, 19 Sep 2023 02:37:09 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55270 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229553AbjISGhG (ORCPT ); Tue, 19 Sep 2023 02:37:06 -0400 Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BB5C4119; Mon, 18 Sep 2023 23:37:00 -0700 (PDT) Received: by smtp.kernel.org (Postfix) with ESMTPSA id D2128C433C8; Tue, 19 Sep 2023 06:36:59 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1695105420; bh=fEmXkRf1BlO1aq/3eAd0nY8VtZl1PlGZ/UWAiyLWBro=; h=References:From:To:Cc:Subject:Date:In-reply-to:From; b=Qx3HP3frbS/kXweUYyGCFVJD7mZpTD2UVn6XZsXrerjWiRjyRnzalul/+ToeiMrr2 Jx3j5seVRpfHj88dx9Ufl4FCXDZQ3P+3nBA2iLtXAAL12zJ7j5hJHyf1CNLabIb7cb YhZVkpfKi0NWfBxvyI5mvQU+OJVzSeXT7EdLv/x/r9X/NX7MLd5l6rDrVabKeKVNbN 2EMmz4buEqwbWsHxwJma+z9dv3csHp7IC2aZUJxZZOyo2XPI3MECUMajvEClaFaWLN iFqugf2UZJd/8Vx8atexK9KAXpiRQuGEfK7bcUC/ABdOYyqzAmzbAKo2b14hpf7tgD hkLha342dA0VQ== References: <63b3742c-0efe-c096-c737-a0e0419480bd@outlook.com> <59dd15dd-5b35-871d-6d3a-ec779975b089@outlook.com> <0a72f462-8b8e-4dec-6ce4-f52e33423957@outlook.com> <20230919032138.GC348037@frogsfrogsfrogs> User-agent: mu4e 1.8.10; emacs 27.1 From: Chandan Babu R To: "Darrick J. Wong" Cc: Wang Jianchao , Chandan Babu R , linux-xfs@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V3] xfs: use roundup_pow_of_two instead of ffs during xlog_find_tail Date: Tue, 19 Sep 2023 12:04:44 +0530 In-reply-to: <20230919032138.GC348037@frogsfrogsfrogs> Message-ID: <874jjqk6t2.fsf@debian-BULLSEYE-live-builder-AMD64> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, Sep 18, 2023 at 08:21:38 PM -0700, Darrick J. Wong wrote: > On Tue, Sep 19, 2023 at 10:06:56AM +0800, Wang Jianchao wrote: >> Ping ? Do I need other update on this patch ? > > Nope, I think this is ok... > >> Thanks >> Jianchao >> >> On 2023/9/13 09:38, Wang Jianchao wrote: >> > >> > In our production environment, we find that mounting a 500M /boot >> > which is umount cleanly needs ~6s. One cause is that ffs() is >> > used by xlog_write_log_records() to decide the buffer size. It >> > can cause a lot of small IO easily when xlog_clear_stale_blocks() >> > needs to wrap around the end of log area and log head block is >> > not power of two. Things are similar in xlog_find_verify_cycle(). >> > >> > The code is able to handed bigger buffer very well, we can use >> > roundup_pow_of_two() to replace ffs() directly to avoid small >> > and sychronous IOs. >> > >> > Reviewed-by: Dave Chinner >> > Signed-off-by: Wang Jianchao > > ...so let's see if the release manager will take this patch. > > Chandan? Could you pull in the various one-off patches floating around > on the list that have passed review? ;) I had picked this patch along with others sometime last week. I have pushed the new set of commits to official xfs-linux git repository and sent the announcement mail around 30 mins ago. > > Reviewed-by: Darrick J. Wong > > PS: If you'd like to send a pull request to push things along, please do > -- Chandan