From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.2 required=3.0 tests=BAYES_00, BUG6152_INVALID_DATE_TZ_ABSURD,DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU, HEADER_FROM_DIFFERENT_DOMAINS,INVALID_DATE_TZ_ABSURD,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 31E06C433E6 for ; Tue, 26 Jan 2021 15:25:09 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id ECCC223122 for ; Tue, 26 Jan 2021 15:25:08 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2392774AbhAZPYD (ORCPT ); Tue, 26 Jan 2021 10:24:03 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57250 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392690AbhAZPXb (ORCPT ); Tue, 26 Jan 2021 10:23:31 -0500 Received: from galois.linutronix.de (Galois.linutronix.de [IPv6:2a0a:51c0:0:12e:550::1]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5CB28C061D73 for ; Tue, 26 Jan 2021 07:22:45 -0800 (PST) From: John Ogness DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020; t=1611674563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/Sy7SVHtgC4wi2yhfM1q/uvM8tpuukxbMGUaZm5YeAQ=; b=aXJ6N6FsbKuIEAZvUQye40M/aPjnbvVGLEFRi72UtqLzHtgf2EmqzQt3mD5KyBqRr2dHjU 2uuleuKWIKZ9VFZQKvqET71ukdxaJMIxjjjP9EgM7uxiiklbiObYfIvjrkBx+9vmHCW4F3 mtTqWS6qDu8UIq9TUyhT0EfYx80QSK1NgWm/kHcB2SFLVJ3o65tG2RwbtPgIdc57JBar3d +STjfhrdPsHzoWXqYH3qLJgL1DOIzqsjYJjv7gxw2npAs1einxExCmJSstUUDb/JyGkcO+ 8Glw1leu2Gy3z3SGKWeSz2X/5zihnpWwJEm3t/6I2MUhJxASMhqSuVLnez3+Iw== DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=linutronix.de; s=2020e; t=1611674563; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=/Sy7SVHtgC4wi2yhfM1q/uvM8tpuukxbMGUaZm5YeAQ=; b=52ux6m8uBoxjuCQ6pZVGvLukEV7E/KvrQ0iYxLsJjw7Xi44d5Cpnw3Ag3edlrTYPc1EqrP mgHIqVEn3u60ozDA== To: Qais Yousef , Sergey Senozhatsky Cc: Petr Mladek , Thomas Gleixner , Steven Rostedt , "Peter Zijlstra \(Intel\)" , linux-kernel@vger.kernel.org Subject: Re: [PATCH 0/2] Fix BUG: Invalid wait context in hrtimer_interrupt() In-Reply-To: <20210126145917.r64vzibgpiwyuake@e107158-lin> References: <20210123233741.3614408-1-qais.yousef@arm.com> <20210126145917.r64vzibgpiwyuake@e107158-lin> Date: Tue, 26 Jan 2021 16:28:42 +0106 Message-ID: <874kj3lo3h.fsf@jogness.linutronix.de> MIME-Version: 1.0 Content-Type: text/plain Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 2021-01-26, Qais Yousef wrote: > [67628.393550] ============================= > [67628.393554] [ BUG: Invalid wait context ] > [67628.393557] 5.11.0-rc3-00019-g86be331946f7 #37 Not tainted > [67628.393560] ----------------------------- > [67628.393563] sugov:0/192 is trying to lock: > [67628.393566] ffff000800b1d898 (&port_lock_key){-.-.}-{3:3}, at: pl011_console_write+0x138/0x218 > [67628.393581] other info that might help us debug this: > [67628.393584] context-{2:2} > [67628.393586] 4 locks held by sugov:0/192: > [67628.393589] #0: ffff0008059cb720 (&sg_policy->work_lock){+.+.}-{4:4}, at: sugov_work+0x58/0x88 > [67628.393603] #1: ffff800015446f20 (prepare_lock){+.+.}-{4:4}, at: clk_prepare_lock+0x34/0xb0 > [67628.393618] #2: ffff8000152aaa60 (console_lock){+.+.}-{0:0}, at: vprintk_emit+0x12c/0x310 > [67628.393632] #3: ffff8000152aab88 (console_owner){-.-.}-{0:0}, at: console_unlock+0x190/0x6d8 > [67628.393646] stack backtrace: > [67628.393649] CPU: 0 PID: 192 Comm: sugov:0 Not tainted 5.11.0-rc3-00019-g86be331946f7 #37 > [67628.393653] Hardware name: ARM Juno development board (r2) (DT) > [67628.393656] Call trace: > [67628.393659] dump_backtrace+0x0/0x1b0 > [67628.393661] show_stack+0x20/0x70 > [67628.393664] dump_stack+0xf8/0x168 > [67628.393666] __lock_acquire+0x964/0x1c88 > [67628.393669] lock_acquire+0x26c/0x500 > [67628.393671] _raw_spin_lock+0x64/0x88 > [67628.393674] pl011_console_write+0x138/0x218 > [67628.393677] console_unlock+0x2c4/0x6d8 > [67628.393680] vprintk_emit+0x134/0x310 > [67628.393682] vprintk_default+0x40/0x50 > [67628.393685] vprintk_func+0xfc/0x2b0 > [67628.393687] printk+0x68/0x90 > [67628.393690] hrtimer_interrupt+0x24c/0x250 > [67628.393693] arch_timer_handler_phys+0x3c/0x50 > [67628.393695] handle_percpu_devid_irq+0xd8/0x460 > [67628.393698] generic_handle_irq+0x38/0x50 > [67628.393701] __handle_domain_irq+0x6c/0xc8 > [67628.393704] gic_handle_irq+0xb0/0xf0 > [67628.393706] el1_irq+0xb4/0x180 > [67628.393709] _raw_spin_unlock_irqrestore+0x58/0xa8 > [67628.393712] hrtimer_start_range_ns+0x1b0/0x420 > [67628.393715] msg_submit+0x100/0x108 > [67628.393717] mbox_send_message+0x84/0x128 > [67628.393720] scpi_send_message+0x11c/0x2a8 > [67628.393723] scpi_dvfs_set_idx+0x48/0x70 > [67628.393726] scpi_dvfs_set_rate+0x60/0x78 > [67628.393728] clk_change_rate+0x184/0x8a8 > [67628.393731] clk_core_set_rate_nolock+0x1c0/0x280 > [67628.393734] clk_set_rate+0x40/0x98 > [67628.393736] scpi_cpufreq_set_target+0x40/0x68 > [67628.393739] __cpufreq_driver_target+0x1a0/0x5d0 pl011_console_write() does: local_irq_save(flags); spin_lock(&uap->port.lock); This needs to be: spin_lock_irqsave(&uap->port.lock, flags); Of course, it will be a trickier than that because of the @oops_in_progress madness. This bug has been around for quite a while. John Ogness