From: Thomas Gleixner <tglx@linutronix.de>
To: Catalin Marinas <catalin.marinas@arm.com>
Cc: Andrei Vagin <avagin@gmail.com>, Will Deacon <will@kernel.org>,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org,
Vincenzo Frascino <vincenzo.frascino@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Dmitry Safonov <dima@arista.com>,
Christian Brauner <christian.brauner@ubuntu.com>
Subject: Re: [PATCH v5 0/6] arm64: add the time namespace support
Date: Fri, 24 Jul 2020 15:22:34 +0200 [thread overview]
Message-ID: <874kpxujxh.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <20200724110131.GC23388@gaia>
Catalin Marinas <catalin.marinas@arm.com> writes:
> On Thu, Jul 23, 2020 at 10:25:35PM +0200, Thomas Gleixner wrote:
>> Andrei Vagin <avagin@gmail.com> writes:
>> > On Wed, Jul 22, 2020 at 07:15:06PM +0100, Catalin Marinas wrote:
>> >
>> > I don't think that we need to handle this case in the kernel. Users
>> > must understand what they are doing and have to write code so that avoid
>> > these sort of situations. In general, I would say that in most cases it
>> > is a bad idea to call setns from a signal handler.
>>
>> This should not be supported in the first place and just let the
>> offender die right there.
>
> It would have been nice if we caught the offender easily but since
> signal handling doesn't have to be paired with sigreturn(), the kernel
> can't tell whether setns() is called in the wrong context. I guess we
> just have to live with this (maybe document the restriction in
> time_namespaces(7) or setns(2)).
Yes, I know that it's more or less impossible. The 'should' was just
wishful thinking :)
But yes, proper documentation is required.
Thanks,
tglx
next prev parent reply other threads:[~2020-07-24 13:22 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-06-24 8:33 Andrei Vagin
2020-06-24 8:33 ` [PATCH 1/6] arm64/vdso: use the fault callback to map vvar pages Andrei Vagin
2020-07-24 17:26 ` Catalin Marinas
2020-07-27 6:45 ` Andrei Vagin
2020-06-24 8:33 ` [PATCH 2/6] arm64/vdso: Zap vvar pages when switching to a time namespace Andrei Vagin
2020-06-24 15:18 ` Christian Brauner
2020-06-25 8:25 ` Andrei Vagin
2020-06-24 8:33 ` [PATCH 3/6] arm64/vdso: Add time namespace page Andrei Vagin
2020-06-24 8:33 ` [PATCH 4/6] arm64/vdso: Handle faults on timens page Andrei Vagin
2020-06-24 8:33 ` [PATCH 5/6] arm64/vdso: Restrict splitting VVAR VMA Andrei Vagin
2020-06-24 8:33 ` [PATCH 6/6] arm64: enable time namespace support Andrei Vagin
2020-07-05 6:40 ` [PATCH v5 0/6] arm64: add the " Andrei Vagin
2020-07-14 1:57 ` Andrei Vagin
2020-07-22 18:15 ` Catalin Marinas
2020-07-23 17:41 ` Andrei Vagin
2020-07-23 20:25 ` Thomas Gleixner
2020-07-24 11:01 ` Catalin Marinas
2020-07-24 13:22 ` Thomas Gleixner [this message]
2020-07-24 13:30 ` Christian Brauner
2020-07-24 14:40 ` Catalin Marinas
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874kpxujxh.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=avagin@gmail.com \
--cc=catalin.marinas@arm.com \
--cc=christian.brauner@ubuntu.com \
--cc=dima@arista.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=vincenzo.frascino@arm.com \
--cc=will@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome