mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Thomas Gleixner <tglx@linutronix.de>
To: Prasad Sodagudi <psodagud@codeaurora.org>,
	john.stultz@linaro.org, sboyd@kernel.org
Cc: linux-kernel@vger.kernel.org, saravanak@google.com,
	tsoni@codeaurora.org, tj@kernel.org,
	Prasad Sodagudi <psodagud@codeaurora.org>
Subject: Re: [PATCH 2/2] sched: Add a check for cpu unbound deferrable timers
Date: Mon, 16 Mar 2020 09:38:45 +0100	[thread overview]
Message-ID: <874kuoelt6.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <1584326350-30275-3-git-send-email-psodagud@codeaurora.org>

Prasad Sodagudi <psodagud@codeaurora.org> writes:
> @@ -948,6 +949,11 @@ static void __tick_nohz_idle_stop_tick(struct tick_sched *ts)
>  	ktime_t expires;
>  	int cpu = smp_processor_id();
>  
> +#ifdef CONFIG_SMP
> +	if (check_pending_deferrable_timers(cpu))
> +		raise_softirq_irqoff(TIMER_SOFTIRQ);
> +#endif

So if that raises the soft interrupt then the warning in 

can_stop_idle_tick()

	if (unlikely(local_softirq_pending())) {
		....
                pr_warn()

will trigger. Try again.

Thanks,

        tglx

  reply	other threads:[~2020-03-16  8:38 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-03-16  2:39 [PATCH 0/2] timer: make deferrable cpu unbound timers really not bound to a cpu Prasad Sodagudi
2020-03-16  2:39 ` [PATCH 1/2] " Prasad Sodagudi
2020-03-16  2:39 ` [PATCH 2/2] sched: Add a check for cpu unbound deferrable timers Prasad Sodagudi
2020-03-16  8:38   ` Thomas Gleixner [this message]
2020-03-16 11:27   ` Pavan Kondeti

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874kuoelt6.fsf@nanos.tec.linutronix.de \
    --to=tglx@linutronix.de \
    --cc=john.stultz@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=psodagud@codeaurora.org \
    --cc=saravanak@google.com \
    --cc=sboyd@kernel.org \
    --cc=tj@kernel.org \
    --cc=tsoni@codeaurora.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome