From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D5CEAC7619D for ; Thu, 20 Feb 2020 02:16:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id B8EDA2465D for ; Thu, 20 Feb 2020 02:16:11 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1727898AbgBTCQK (ORCPT ); Wed, 19 Feb 2020 21:16:10 -0500 Received: from relmlor1.renesas.com ([210.160.252.171]:39321 "EHLO relmlie5.idc.renesas.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1727476AbgBTCQK (ORCPT ); Wed, 19 Feb 2020 21:16:10 -0500 Date: 20 Feb 2020 11:16:08 +0900 X-IronPort-AV: E=Sophos;i="5.70,462,1574089200"; d="scan'208";a="39766111" Received: from unknown (HELO relmlir6.idc.renesas.com) ([10.200.68.152]) by relmlie5.idc.renesas.com with ESMTP; 20 Feb 2020 11:16:08 +0900 Received: from mercury.renesas.com (unknown [10.166.252.133]) by relmlir6.idc.renesas.com (Postfix) with ESMTP id 780A04127DC1; Thu, 20 Feb 2020 11:16:08 +0900 (JST) Message-ID: <874kvmt355.wl-kuninori.morimoto.gx@renesas.com> From: Kuninori Morimoto To: Rob Herring Cc: Liam Girdwood , Mark Brown , Mark Rutland , alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH v2] ASoC: dt-bindings: renesas,rsnd: switch to yaml base Documentation In-Reply-To: <20200219161732.GB25095@bogus> References: <87d0ahzr9d.wl-kuninori.morimoto.gx@renesas.com> <20200219161732.GB25095@bogus> User-Agent: Wanderlust/2.15.9 Emacs/25.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Rob Thank you for your review > > From: Kuninori Morimoto > > > > This patch switches from .txt base to .yaml base Document. > > It is still keeping detail explanations at .txt > > > > Signed-off-by: Kuninori Morimoto > > --- (snip) > > + compatible: > > + oneOf: > > + # for Gen1 SoC > > + - items: > > + - enum: > > nit: Should be indented 2 more spaces. I couldn't understand this. Do you mean like this ?? compatible: oneOf: # for Gen1 SoC - items: => - enum: > > + clock-frequency: > > + description: for audio_clkout0/1/2/3 > > + $ref: /schemas/types.yaml#/definitions/uint32-array > > This already has a common definition and this conflicts with that. > 'clock-frequency' is a single uint32 or uint64. This needs clock array. Like this clock-frequency = <12288000 11289600>; > > + # For OF-graph > > + port: > > + description: OF-Graph subnode > > + type: object > > + properties: > > + reg: > > + $ref: /schemas/types.yaml#/definitions/uint32 > > No unit-address for 'port', so you don't need 'reg' here. But I got warning without reg ? And, renesas,rsnd and/or simple-card sometimes needs reg for port to handle sound path. > > + # For multi OF-graph > > + ports: > > + description: multi OF-Graph subnode > > + type: object > > + patternProperties: > > + "port(@.*)?": > > ^port(@[0-9a-f])?$" > > Perhaps there's max number of ports that's less than 0xf? > > > + $ref: "#properties/port" > > Would be more simple to just always have 'ports'. Having "ports" or "port" are case-by-case, not always. Thank you for your help !! Best regards --- Kuninori Morimoto