From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751099AbdJREFJ (ORCPT ); Wed, 18 Oct 2017 00:05:09 -0400 Received: from mail.parknet.co.jp ([210.171.160.6]:44395 "EHLO mail.parknet.co.jp" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750724AbdJREFI (ORCPT ); Wed, 18 Oct 2017 00:05:08 -0400 X-Greylist: delayed 1933 seconds by postgrey-1.27 at vger.kernel.org; Wed, 18 Oct 2017 00:05:07 EDT From: OGAWA Hirofumi To: Andrew Morton Cc: Colin King , kernel-janitors@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] fat: remove redundant assignment of 0 to slots References: <20171017140258.22536-1-colin.king@canonical.com> Date: Wed, 18 Oct 2017 12:32:52 +0900 In-Reply-To: <20171017140258.22536-1-colin.king@canonical.com> (Colin King's message of "Tue, 17 Oct 2017 15:02:58 +0100") Message-ID: <874lqxuo4b.fsf@mail.parknet.co.jp> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.0.50 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Colin King writes: > From: Colin Ian King > > The variable slots is being assigned a value of zero that is never > read, slots is being updated again a few lines later. Remove this > redundant assignment. > Cleans clang warning: Value stored to 'slots' is never read > > Signed-off-by: Colin Ian King Looks like good (if old gcc didn't have false positive warning). Acked-by: OGAWA Hirofumi > --- > fs/fat/dir.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/fs/fat/dir.c b/fs/fat/dir.c > index 81cecbe6d7cf..b833ffeee1e1 100644 > --- a/fs/fat/dir.c > +++ b/fs/fat/dir.c > @@ -291,7 +291,6 @@ static int fat_parse_long(struct inode *dir, loff_t *pos, > } > } > parse_long: > - slots = 0; > ds = (struct msdos_dir_slot *)*de; > id = ds->id; > if (!(id & 0x40)) -- OGAWA Hirofumi