From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1751508AbdGRM3P (ORCPT <rfc822;w@1wt.eu>);
        Tue, 18 Jul 2017 08:29:15 -0400
Received: from mga01.intel.com ([192.55.52.88]:17918 "EHLO mga01.intel.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1751322AbdGRM3O (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 18 Jul 2017 08:29:14 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.40,377,1496127600"; 
   d="scan'208";a="994273549"
From: Alexander Shishkin <alexander.shishkin@linux.intel.com>
To: Alexey Budankov <alexey.budankov@linux.intel.com>,
        Peter Zijlstra <peterz@infradead.org>, Ingo Molnar <mingo@redhat.com>,
        Arnaldo Carvalho de Melo <acme@kernel.org>
Cc: Andi Kleen <ak@linux.intel.com>, Kan Liang <kan.liang@intel.com>,
        Dmitri Prokhorov <Dmitry.Prohorov@intel.com>,
        Valery Cherepennikov <valery.cherepennikov@intel.com>,
        Mark Rutland <mark.rutland@arm.com>,
        David Carrillo-Cisneros <davidcc@google.com>,
        Stephane Eranian <eranian@google.com>,
        linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v5 1/4]: perf/core: use rb trees for pinned/flexible groups
In-Reply-To: <fb3cd0a0-ff6e-daba-956b-316379e54735@linux.intel.com>
References: <fb3cd0a0-ff6e-daba-956b-316379e54735@linux.intel.com>
User-Agent: Notmuch/0.23.7 (http://notmuchmail.org) Emacs/24.5.1 (x86_64-pc-linux-gnu)
Date: Tue, 18 Jul 2017 15:29:10 +0300
Message-ID: <874luavsh5.fsf@ashishki-desk.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

Alexey Budankov <alexey.budankov@linux.intel.com> writes:

> +/*
> + * Helper function to test if event groups are empty;
> + */
> +static int
> +perf_event_groups_empty(struct perf_event_groups *groups)
> +{
> +	return list_empty(&groups->list);
> +}

This doesn't seem useful, it's only used once. Also, it's not clear how
access to groups->list is serialized here, but it is in the caller.

I'm assuming you will use this helper after the linked lists are done
away with, but I'll have to go fishing for that patch to make sure.

> +static void
> +perf_event_groups_insert(struct perf_event_groups *groups,
> +		struct perf_event *event)
> +{
> +	struct rb_node **node;
> +	struct rb_node *parent;
> +	struct perf_event *node_event;
> +
> +	WARN_ON_ONCE(!groups || !event);

I'm pretty sure neither of these is plausible.

> +	WARN_ON_ONCE(!list_empty(&event->group_list_entry));

So ctx::lock is held here, right? That could be a useful assert and/or
comment at least for review purposes. Now I see that it's called from
list_add_event().

Regards,
--
Alex