From: Michael Ellerman <mpe@ellerman.id.au>
To: Borislav Petkov <bp@alien8.de>
Cc: dougthompson@xmission.com, mchehab@kernel.org,
linux-edac@vger.kernel.org, linux-kernel@vger.kernel.org,
linuxppc-dev@ozlabs.org, arnd@arndb.de
Subject: Re: [PATCH] drivers/edac: NO_IRQ removal from powerpc-only drivers
Date: Mon, 12 Sep 2016 14:47:37 +1000 [thread overview]
Message-ID: <874m5lrafq.fsf@concordia.ellerman.id.au> (raw)
In-Reply-To: <20160910145320.bg6s6wo5ya7zzw2n@pd.tnic>
Borislav Petkov <bp@alien8.de> writes:
> On Sat, Sep 10, 2016 at 07:57:08PM +1000, Michael Ellerman wrote:
>> We'd like to eventually remove NO_IRQ on powerpc, so remove usages of it
>> from powerpc-only drivers.
>>
>> Signed-off-by: Michael Ellerman <mpe@ellerman.id.au>
>> ---
>> drivers/edac/mpc85xx_edac.c | 6 +++---
>> drivers/edac/mv64x60_edac.c | 8 ++++----
>> drivers/edac/ppc4xx_edac.c | 6 +++---
>> 3 files changed, 10 insertions(+), 10 deletions(-)
>>
>> diff --git a/drivers/edac/mpc85xx_edac.c b/drivers/edac/mpc85xx_edac.c
>> index ca63d0da8889..e12b8e166a53 100644
>> --- a/drivers/edac/mpc85xx_edac.c
>> +++ b/drivers/edac/mpc85xx_edac.c
>> @@ -267,7 +267,7 @@ static int mpc85xx_pci_err_probe(struct platform_device *op)
>>
>> pdata = pci->pvt_info;
>> pdata->name = "mpc85xx_pci_err";
>> - pdata->irq = NO_IRQ;
>> + pdata->irq = 0;
>>
>> plat_data = op->dev.platform_data;
>> if (!plat_data) {
>
> So all of those pdata structs come from kzalloc() so you don't really
> have to assign to 0 - simply kill the line.
OK.
>> @@ -1058,7 +1058,7 @@ static int mpc85xx_mc_err_probe(struct platform_device *op)
>>
>> pdata = mci->pvt_info;
>> pdata->name = "mpc85xx_mc_err";
>> - pdata->irq = NO_IRQ;
>> + pdata->irq = 0;
>> mci->pdev = &op->dev;
>> pdata->edac_idx = edac_mc_idx++;
>> dev_set_drvdata(mci->pdev, mci);
>
> That part went into drivers/edac/fsl_ddr_edac.c which is only the
> freescale memory controller being shared between ARM and PPC, see
>
> http://git.kernel.org/cgit/linux/kernel/git/bp/bp.git/log/?h=for-next
>
> But that shouldn't change the issue wrt ->irq as now it is implicitly 0.
Ah OK.
NO_IRQ is -1 on ARM (or at least it can be?), see arch/arm/include/asm/irq.h.
So I'll leave that one alone for now.
> IOW, you can drop this hunk.
>
> Please send v2 against the above branch or linux-next.
OK will do.
cheers
next prev parent reply other threads:[~2016-09-12 4:47 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-09-10 9:57 Michael Ellerman
2016-09-10 14:53 ` Borislav Petkov
2016-09-12 4:47 ` Michael Ellerman [this message]
2016-09-12 7:36 ` Arnd Bergmann
2016-09-12 9:57 ` Michael Ellerman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874m5lrafq.fsf@concordia.ellerman.id.au \
--to=mpe@ellerman.id.au \
--cc=arnd@arndb.de \
--cc=bp@alien8.de \
--cc=dougthompson@xmission.com \
--cc=linux-edac@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxppc-dev@ozlabs.org \
--cc=mchehab@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®