From: Vivien Didelot <vivien.didelot@savoirfairelinux.com>
To: Cong Wang <xiyou.wangcong@gmail.com>
Cc: Linux Kernel Network Developers <netdev@vger.kernel.org>,
LKML <linux-kernel@vger.kernel.org>,
kernel@savoirfairelinux.com,
"David S. Miller" <davem@davemloft.net>,
Stephen Hemminger <stephen@networkplumber.org>
Subject: Re: [PATCH] net: bridge: br_set_ageing_time takes a clock_t
Date: Thu, 21 Jul 2016 14:18:59 -0400 [thread overview]
Message-ID: <874m7ilur0.fsf@ketchup.mtl.sfl> (raw)
In-Reply-To: <CAM_iQpUzf6MiOqYNc-vX0A-mhZ_=URwVPoUD1TY7xC0amTZoww@mail.gmail.com>
Hi Cong,
Cong Wang <xiyou.wangcong@gmail.com> writes:
> On Thu, Jul 21, 2016 at 9:42 AM, Vivien Didelot
> <vivien.didelot@savoirfairelinux.com> wrote:
>> Change the ageing_time type in br_set_ageing_time() from u32 to what it
>> is expected to be, i.e. a clock_t.
>
> You also need to change struct switchdev_attr:
>
> struct switchdev_attr {
> struct net_device *orig_dev;
> enum switchdev_attr_id id;
> u32 flags;
> void *complete_priv;
> void (*complete)(struct net_device *dev, int err, void *priv);
> union {
> struct netdev_phys_item_id ppid; /* PORT_PARENT_ID */
> u8 stp_state; /* PORT_STP_STATE */
> unsigned long brport_flags; /* PORT_BRIDGE_FLAGS */
> u32 ageing_time; /* BRIDGE_AGEING_TIME */
> bool vlan_filtering; /*
> BRIDGE_VLAN_FILTERING */
> } u;
> };
Already changed in net/master as of eabfdda93477
("net: switchdev: change ageing_time type to clock_t").
Thanks,
Vivien
next prev parent reply other threads:[~2016-07-21 18:19 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-21 16:42 Vivien Didelot
2016-07-21 16:58 ` Cong Wang
2016-07-21 18:18 ` Vivien Didelot [this message]
2016-07-21 18:27 ` Cong Wang
2016-07-25 17:31 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874m7ilur0.fsf@ketchup.mtl.sfl \
--to=vivien.didelot@savoirfairelinux.com \
--cc=davem@davemloft.net \
--cc=kernel@savoirfairelinux.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=stephen@networkplumber.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®