From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759126AbbJ3M4o (ORCPT ); Fri, 30 Oct 2015 08:56:44 -0400 Received: from mx1.redhat.com ([209.132.183.28]:1282 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1758553AbbJ3M4m (ORCPT ); Fri, 30 Oct 2015 08:56:42 -0400 From: Vitaly Kuznetsov To: Hannes Reinecke Cc: James Bottomley , linux-scsi@vger.kernel.org, linux-kernel@vger.kernel.org, "K. Y. Srinivasan\" , Long Li , Dexuan Cui "@redhat.com Subject: Re: [PATCH v3 RESEND] scsi: report 'INQUIRY result too short' once per host References: <1446205211-12874-1-git-send-email-vkuznets@redhat.com> <56335AAD.4040506@suse.de> Date: Fri, 30 Oct 2015 13:56:36 +0100 In-Reply-To: <56335AAD.4040506@suse.de> (Hannes Reinecke's message of "Fri, 30 Oct 2015 12:55:25 +0100") Message-ID: <874mh8seez.fsf@vitty.brq.redhat.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hannes Reinecke writes: > On 10/30/2015 12:40 PM, Vitaly Kuznetsov wrote: >> Some host adapters (e.g. Hyper-V storvsc) are known for not respecting the >> SPC-2/3/4 requirement for 'INQUIRY data (see table ...) shall contain at >> least 36 bytes'. As a result we get tons on 'scsi 0:7:1:1: scsi scan: >> INQUIRY result too short (5), using 36' messages on console. This can be >> problematic for slow consoles. Introduce short_inquiry flag in struct >> Scsi_Host to print the message once per host. >> >> Signed-off-by: Vitaly Kuznetsov >> --- >> Changes since v3 RESEND: >> - Sorry, I screwed up James address when sending 'v3 RESEND'. >> >> Changes since v3: >> - no changes, this is just a RESEND. >> >> Changes since v2: >> - This is a successor of previously sent (and still not merged) "scsi: >> introduce short_inquiry flag for broken host adapters" patch. I'm not >> particularly sure which solution is better but I'm leaning towards this >> one as it doesn't require changes to adapter drivers. >> --- >> drivers/scsi/scsi_scan.c | 9 ++++++--- >> include/scsi/scsi_host.h | 3 +++ >> 2 files changed, 9 insertions(+), 3 deletions(-) >> > Why not printk_once? > Should achieve the same result, and we're saving yet another flag... > It seems it makes sense to print this warning per-host (as we can have many hosts) and not just once. It's hard to come up with a reasonable message for printk_once() -- "some of your SCSI devices are buggy" sounds to vague. Here we say "this particular scsi controller is buggy". -- Vitaly