From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932950AbbI1L0v (ORCPT ); Mon, 28 Sep 2015 07:26:51 -0400 Received: from mail-wi0-f170.google.com ([209.85.212.170]:38047 "EHLO mail-wi0-f170.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932297AbbI1L0t (ORCPT ); Mon, 28 Sep 2015 07:26:49 -0400 From: Peter Korsgaard To: kbuild test robot Cc: Songjun Wu , alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Takashi Iwai , nicolas.ferre@atmel.com, Liam Girdwood , broonie@kernel.org, kbuild-all@01.org, linux-arm-kernel@lists.infradead.org Subject: Re: [alsa-devel] [PATCH] ASoC: atmel-classd: fix odd_ptr_err.cocci warnings References: <201509281735.7lYs3Huz%fengguang.wu@intel.com> <20150928091029.GA23312@roam> Date: Mon, 28 Sep 2015 13:26:46 +0200 In-Reply-To: <20150928091029.GA23312@roam> (kbuild test robot's message of "Mon, 28 Sep 2015 17:10:29 +0800") Message-ID: <874miekcnd.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org >>>>> "kbuild" == kbuild test robot writes: > sound/soc/atmel/atmel-classd.c:578:5-11: inconsistent IS_ERR and PTR_ERR, PTR_ERR on line 579 > PTR_ERR should access the value just tested by IS_ERR > Semantic patch information: > There can be false positives in the patch case, where it is the call > IS_ERR that is wrong. > Generated by: scripts/coccinelle/tests/odd_ptr_err.cocci > CC: Songjun Wu > Signed-off-by: Fengguang Wu > --- > atmel-classd.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > --- a/sound/soc/atmel/atmel-classd.c > +++ b/sound/soc/atmel/atmel-classd.c > @@ -576,7 +576,7 @@ static int atmel_classd_probe(struct pla dd-> gclk = devm_clk_get(dev, "gclk"); > if (IS_ERR(dd->aclk)) { > - ret = PTR_ERR(dd->gclk); > + ret = PTR_ERR(dd->aclk); It looks like it is the other way around. It should test IS_ERR(dd->gclk) instead. -- Bye, Peter Korsgaard