mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Andi Kleen <andi@firstfloor.org>
To: Stephane Eranian <eranian@google.com>
Cc: linux-kernel@vger.kernel.org, acme@redhat.com,
	peterz@infradead.org, mingo@elte.hu, jolsa@redhat.com,
	namhyung@kernel.org, kan.liang@intel.com, dsahern@gmail.com,
	adrian.hunter@intel.com
Subject: Re: [PATCH v2 4/4] perf script: enable printing of branch stack
Date: Mon, 31 Aug 2015 10:08:01 -0700	[thread overview]
Message-ID: <874mjfxu6m.fsf@tassilo.jf.intel.com> (raw)
In-Reply-To: <20150831170535.GY4524@tassilo.jf.intel.com> (Andi Kleen's message of "Mon, 31 Aug 2015 10:05:35 -0700")

Andi Kleen <ak@linux.intel.com> writes:

>>  $ perf script -F ip,brstack
>>   5d3000 0x401aa0/0x5d2000/M/-/-/-/0 ...
>> 
>>  $ perf script -F ip,brstacksym
>>   4011e0 noploop+0x0/noploop+0x0/P/-/-/0
>
> That's a weird format that's hard to parse with standard tools like
> awk, and also for humans. How about separating with spaces?

Also can you include the number of the LBR in the branch record?
That can be useful sometimes.

BTW I haven't checked, but it would be also good to make sure
the print order is the same as program order (perf stores
the LBRs reversed)

-Andi


-- 
ak@linux.intel.com -- Speaking for myself only

  reply	other threads:[~2015-08-31 17:08 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-31 16:41 [PATCH v2 0/4] perf: improve script and record for iregs and brstack Stephane Eranian
2015-08-31 16:41 ` [PATCH v2 1/4] perf script: enable printing of interrupted machine state Stephane Eranian
2015-08-31 20:51   ` Arnaldo Carvalho de Melo
2015-09-01  8:31   ` [tip:perf/urgent] perf script: Enable " tip-bot for Stephane Eranian
2015-08-31 16:41 ` [PATCH v2 2/4] perf/x86: add list of register names Stephane Eranian
2015-09-01  8:31   ` [tip:perf/urgent] perf/x86: Add " tip-bot for Stephane Eranian
2015-08-31 16:41 ` [PATCH v2 3/4] perf record: add ability to name registers to record Stephane Eranian
2015-08-31 21:02   ` Arnaldo Carvalho de Melo
2015-09-01  8:32   ` [tip:perf/urgent] perf record: Add " tip-bot for Stephane Eranian
2015-08-31 16:41 ` [PATCH v2 4/4] perf script: enable printing of branch stack Stephane Eranian
2015-08-31 17:05   ` Andi Kleen
2015-08-31 17:08     ` Andi Kleen [this message]
2015-10-30  9:13   ` [tip:perf/core] perf script: Enable " tip-bot for Stephane Eranian

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874mjfxu6m.fsf@tassilo.jf.intel.com \
    --to=andi@firstfloor.org \
    --cc=acme@redhat.com \
    --cc=adrian.hunter@intel.com \
    --cc=dsahern@gmail.com \
    --cc=eranian@google.com \
    --cc=jolsa@redhat.com \
    --cc=kan.liang@intel.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=namhyung@kernel.org \
    --cc=peterz@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

Powered by JetHome