mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Robert Jarzmik <robert.jarzmik@free.fr>
To: Ezequiel Garcia <ezequiel@vanguardiasur.com.ar>
Cc: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>,
	David Woodhouse <dwmw2@infradead.org>,
	Brian Norris <computersforpeace@gmail.com>,
	linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug
Date: Tue, 18 Aug 2015 20:26:49 +0200	[thread overview]
Message-ID: <874mjwa1w6.fsf@belgarion.home> (raw)
In-Reply-To: <20150818042426.GA27858@laptop> (Ezequiel Garcia's message of "Tue, 18 Aug 2015 01:24:26 -0300")

Ezequiel Garcia <ezequiel@vanguardiasur.com.ar> writes:

> On 11 Aug 09:57 PM, Robert Jarzmik wrote:
>> Add verbose debug for register accesses. This enables easier debugging
>> by following where and how hardware is stimulated, and how it answers.
>> 
>
> I really don't see why we want this patch. It's probably an useful hack to
> use in some cases, but can't see why we would want it in mainline.
>
> Feel free to prove me wrong.
Why not.

Imagine that there is a bug in the driver, such as the one with the status bits
clearing. You can't reproduce it, and the person who has the hardware to
reproduce it is not skilled enough to do any debug.

What are the tools and what will you ask this tester to do in order to debug and
solve his problem, as a good driver maintainer ?

Amongst the drivers I wrote in the past, this approach was the most reliable to
capture traces to debug remotely.

Cheers.

--
Robert

  reply	other threads:[~2015-08-18 18:31 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2015-08-11 19:57 Robert Jarzmik
2015-08-11 19:57 ` [PATCH 2/3] mtd: nand: pxa3xx_nand: fix early spurious interrupt Robert Jarzmik
2015-08-11 19:57 ` [PATCH 3/3] mtd: nand: pxa3xx-nand: fix readid without keep_config Robert Jarzmik
2015-08-16 21:36   ` Ezequiel Garcia
2015-08-16 22:22     ` Robert Jarzmik
2015-08-17 17:31       ` Ezequiel Garcia
2015-08-17 19:03         ` Robert Jarzmik
2015-08-18  8:59           ` Antoine Tenart
2015-08-18  4:24 ` [PATCH 1/3] mtd: nand: pxa3xx_nand: add register access debug Ezequiel Garcia
2015-08-18 18:26   ` Robert Jarzmik [this message]
2015-08-23 19:09     ` Robert Jarzmik
2015-08-24 13:46       ` Ezequiel Garcia
2015-12-19  0:48         ` Brian Norris
2015-12-19 12:19           ` Robert Jarzmik
2016-01-07  0:04             ` Brian Norris
2016-01-07  0:06 ` Brian Norris
2016-01-10 20:34   ` Robert Jarzmik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=874mjwa1w6.fsf@belgarion.home \
    --to=robert.jarzmik@free.fr \
    --cc=computersforpeace@gmail.com \
    --cc=dwmw2@infradead.org \
    --cc=ezequiel.garcia@free-electrons.com \
    --cc=ezequiel@vanguardiasur.com.ar \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mtd@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox

all inboxes | Powered by JetHome®