From: Andi Kleen <andi@firstfloor.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Mike Frysinger <vapier@gentoo.org>,
v4l-dvb-maintainer@linuxtv.org, linux-dvb@linuxtv.org,
Holger Waechtler <holger@convergence.de>,
Mauro Carvalho Chehab <mchehab@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ttusb-budget: make it depend on PCI
Date: Wed, 12 Nov 2008 14:11:45 +0100 [thread overview]
Message-ID: <874p2ddr72.fsf@basil.nowhere.org> (raw)
In-Reply-To: <200811121336.00521.arnd@arndb.de> (Arnd Bergmann's message of "Wed, 12 Nov 2008 13:35:59 +0100")
Arnd Bergmann <arnd@arndb.de> writes:
> On Wednesday 12 November 2008, Mike Frysinger wrote:
>> From:
>> Mike Frysinger <vapier@gentoo.org>
>> To:
>> v4l-dvb-maintainer@linuxtv.org, linux-dvb@linuxtv.org, Holger Waechtler <holger@convergence.de>
>> CC:
>> Mauro Carvalho Chehab <mchehab@infradead.org>, linux-kernel@vger.kernel.org
>> Date:
>> Today 13:00:18
>>
>> Since dvb-ttusb-budget.c relies on pci_alloc_consistent and
>> pci_free_consistent, make it depend on PCI in Kconfig.
>>
>> Signed-off-by: Mike Frysinger <vapier@gentoo.org>
>
> Shouldn't you just convert it (trivially) to dma_alloc_coherent and
> dma_alloc_coherent?
Unless it really needs to use the 16MB DMA zone (which I doubt
especially for USB devices) then it should not call either with a NULL
device argument.
-Andi
--
ak@linux.intel.com
next prev parent reply other threads:[~2008-11-12 12:54 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-11-12 12:00 Mike Frysinger
2008-11-12 12:04 ` [PATCH] ttusb-dec: " Mike Frysinger
2008-11-12 12:35 ` [PATCH] ttusb-budget: " Arnd Bergmann
2008-11-12 13:11 ` Andi Kleen [this message]
2008-11-12 13:46 ` Arnd Bergmann
2008-11-12 13:17 ` Mike Frysinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874p2ddr72.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=arnd@arndb.de \
--cc=holger@convergence.de \
--cc=linux-dvb@linuxtv.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mchehab@infradead.org \
--cc=v4l-dvb-maintainer@linuxtv.org \
--cc=vapier@gentoo.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®