From: Andi Kleen <andi@firstfloor.org>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, Linux-Kernel <linux-kernel@vger.kernel.org>
Subject: Re: [RFC][PATCH] tty: remove the BKL in n_tty.c
Date: Mon, 13 Oct 2008 12:37:10 +0200 [thread overview]
Message-ID: <874p3gsrvt.fsf@basil.nowhere.org> (raw)
In-Reply-To: <20081013084719.03972D1B9DE@perso1.free.fr> (Frederic Weisbecker's message of "Mon, 13 Oct 2008 10:47:18")
Frederic Weisbecker <fweisbec@gmail.com> writes:
>
> +
> +/*
> + * This Mutex is used to replace a big kernel lock that protected
> + * the access to tty->column.
> + */
> +static DEFINE_MUTEX(tty_column_mutex);
I suppose Alan did it already, but the general rule when doing
such changes is to lock data not code.
-Andi
--
ak@linux.intel.com
next prev parent reply other threads:[~2008-10-13 10:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2008-10-13 10:47 Frederic Weisbecker
2008-10-13 8:54 ` Frédéric Weisbecker
2008-10-13 9:24 ` Alan Cox
2008-10-13 9:37 ` Frédéric Weisbecker
2008-10-13 10:37 ` Andi Kleen [this message]
2008-10-13 10:40 ` Alan Cox
2008-10-13 12:23 ` Frédéric Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=874p3gsrvt.fsf@basil.nowhere.org \
--to=andi@firstfloor.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®