From: Sven Eckelmann <sven@narfation.org>
To: marek.lindner@mailbox.org, sw@simonwunderlich.de,
antonio@mandelbit.com, "Ömer Mete Kaya" <omermetekaya0@gmail.com>,
b.a.t.m.a.n@lists.open-mesh.org
Cc: davem@davemloft.net, b.a.t.m.a.n@lists.open-mesh.org,
linux-kernel@vger.kernel.org,
syzbot+61b202fdc410840f0198@syzkaller.appspotmail.com,
Sven Eckelmann <sven@narfation.org>
Subject: Re: [PATCH net] batman-adv: reduce softirq drain in tt_purge loops
Date: Sat, 31 Oct 2026 15:19:59 +0100 [thread overview]
Message-ID: <8752561.T7Z3S40VBb@sven-desktop> (raw)
In-Reply-To: <2282819.irdbgypaU6@sven-desktop>
[-- Attachment #1: Type: text/plain, Size: 549 bytes --]
On Friday, 30 October 2026 00:59:51 CET Ömer Mete Kaya wrote:
> + if ((i & 63) == 63) {
> + local_bh_enable();
> + cond_resched();
> + local_bh_disable();
> + }
This is repeated (and will be in the future even more repeated). And it
contains odd magic values. This should maybe be extracted.
https://git.open-mesh.org/pub/ecsv/batman-adv.git/commit/?h=b4/hash-iterate-disable-bh&id=2cda1f6e4640b3bbdfadb8ef1ef633cf3c87f6ec
Regards,
Sven
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 228 bytes --]
next prev parent reply other threads:[~2026-10-31 14:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-29 23:59 Ömer Mete Kaya
2026-10-30 8:25 ` Sven Eckelmann
2026-10-31 0:02 ` Ömer Mete Kaya
2026-10-31 8:39 ` Sven Eckelmann
2026-10-31 14:19 ` Sven Eckelmann [this message]
2026-10-30 22:00 ` kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8752561.T7Z3S40VBb@sven-desktop \
--to=sven@narfation.org \
--cc=antonio@mandelbit.com \
--cc=b.a.t.m.a.n@lists.open-mesh.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=marek.lindner@mailbox.org \
--cc=omermetekaya0@gmail.com \
--cc=sw@simonwunderlich.de \
--cc=syzbot+61b202fdc410840f0198@syzkaller.appspotmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®