From mboxrd@z Thu Jan 1 00:00:00 1970 Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.remote-ip=209.85.215.180 ARC-Seal: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; cv=none; t=1792458102; b=se5dHcx+AK/9iDgjsTxyYprSMgShmd28bGFo7hmzkJDclAJCeUz6zVLtRlY+qmYEVHk/ qpYpu9yI7OuenpH/E1s1LWsrIy9YAx3g98J62NzKCORBjWwknYVovFa77LD/ZA4kxREE7 fgr1krB4K+KmYq2nsqd/97Yjsm5tFMU5G9ezTeV9lZO8HMMz9u51YSM2wEScsY0vusk57 hVqM8a3hoyeSjfGOJCv78c54P51BJ8MHGo6aC/41B5JaW7+kvHWJBtRPNp7xuJusGmwT1 NSgRwaAK7f91D0TnhOQJZbbvFsFScWF+UtOs4xlJ0QD/mTfAU3Es+hWNy2z10XNsq+g== ARC-Message-Signature: i=1; d=subspace.kernel.org; s=arc20261015; a=rsa-sha256; c=relaxed/relaxed; t=1792458102; h=DMARC-Filter:Received:DKIM-Signature:X-Google-DKIM-Signature: X-Forwarded-Encrypted:X-Gm-Message-State:X-Gm-Gg:X-Received:Received: Sender:Message-ID:Date:MIME-Version:User-Agent:Subject:To:Cc: References:Content-Language:From:Autocrypt:In-Reply-To:Content-Type: Content-Transfer-Encoding; bh=FK8OjXvCaQjXVUd2PCHr3RPKmKfwRrKtAbES1NRfsvs=; b=oH+ss0QmF1NCN+b5ukS8jGXxkeoEvtXVptDd2H8pPCVmN1Xy5mUjo8ichoO8cHhsMW59 +Y5CSK7WJoLmlqLfqwZS51p7UfRESbgGlqwwoHNyuuKxBg1LHF7IGVJpWZf02FJ4/YuOx KoMUF64hA79LaEcGj3CJkiLn69i0WOH2cKPvE+DqPwkB1bM9V14xJ3GdYhzUMDqQv+b+n 6AqIJGKzHqyJKtSfwU29p7+xZibq5L1c3XcTfBDp85LWRofJVUKX2ZKHsjJRBxGU954Hd aotWU8nV7iIkjQz+ytYcntQLVEDu/YdD2v88VwNE2wie8xo+EjP16mHVtFF5MyvtQPA== ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none header.from=roeck-us.net; spf=pass smtp.mailfrom=gmail.com; dkim=pass header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=ErOz3YhK; arc=none smtp.remote-ip=209.85.215.180 Received: from mail-pg1-f180.google.com (mail-pg1-f180.google.com [209.85.215.180]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature ECDSA (prime256v1) server-digest SHA256) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 20B56606A31C for ; Tue, 20 Oct 2026 01:01:42 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.2 smtp.subspace.kernel.org 20B56606A31C Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=roeck-us.net Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key, unprotected) header.d=gmail.com header.i=@gmail.com header.a=rsa-sha256 header.s=20251104 header.b=ErOz3YhK Received: by mail-pg1-f180.google.com with SMTP id 41be03b00d2f7-cc4dbcf2b85so1099695a12.3 for ; Mon, 19 Oct 2026 18:01:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20251104; t=1792458101; x=1793062901; darn=vger.kernel.org; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:from:to:cc:subject:date:message-id:reply-to :content-type; bh=FK8OjXvCaQjXVUd2PCHr3RPKmKfwRrKtAbES1NRfsvs=; b=ErOz3YhKVZcSWXMrFWtgaTsRfJspK71A6rRjCFuHZhY4fzwr+kxUG5f07KQ0QySBH1 8dwQFZXCqQpE761fKbUvvcNB+ORBELzZa81SREU5h4zmt4gH8KEWIbpMNyGcrP2+L110 b+PI/YgV40CvhvAtGmTVquRmYpIvVow1NAh8XRZ26hp4rRPt/LCASFQmh7C0KV3efl/Y 1fnH0P94Z0m4Qd+1RyE6nB0zGNRwLbwBFu1MnfhZYTOvU+Faqv/eRa8P2LarntY5K6Fh SHju2Rrlj/lei5Qx10mInFLAXVqyGqW9PD3z74KKyLK4no5E9wfPUl996q/6PwJlwHw2 9cgw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20260707; t=1792458101; x=1793062901; h=content-transfer-encoding:content-type:in-reply-to:autocrypt:from :content-language:references:cc:to:subject:user-agent:mime-version :date:message-id:sender:x-gm-gg:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to:content-type; bh=FK8OjXvCaQjXVUd2PCHr3RPKmKfwRrKtAbES1NRfsvs=; b=GT90kNKBjuBkp35wUnJsVaZhOwFazCz4lH7XaNprd71ssvs6jqVWKK+/cT2iRVnL8e F3EbBRyqPlBPi1w9GJLKPLcvUUCyYcDorMUU+M6jObcvd6zGEQfzXn7czHXkh05doA/9 w2hPKPfmYlpd8mx1aaDXXWJ/gVpjgq8wAFNP3aC/M3H7IHXCiMvX1Bnr6eBuVerC5j+C rtZi2q1TUbWZjwaQmCRtq48TEwB9AgSoWsgILAVBX8U/L+VzzRlEPsYQmdNPkORwgzQ6 QrNUOcei4rjhO71pqt9tbtAUln8sNGpJ3b1tTACsqNNm2s80si13+FHD5VTEpluWaPr4 IIzQ== X-Forwarded-Encrypted: i=1; AKwUvBxURr/vSM001+op2Z+KlE8vqsTneH+K3a1HRirHr8BlmznRC0myolcl77bG9u2Q3zkOfr+FAcZamTIAkJo=@vger.kernel.org X-Gm-Message-State: AFq9FYLyihn1as+lcQV33DTomS083tDFXY3R5Cz5I1X1zMHlDq7qBXyH Aj8mhLqzI7bSXldaDg4mlnuknwJZDCXwsbBvHfcMooY7lauRQqtHNyjz X-Gm-Gg: AYBFou3KZJJ6RE5Ia6vqfW475+yca6GNhw1Iq0mdvuw66vw4N5DapzWprWIGEyy2Vcg XcZO7zO9gcCdjyrdLE9bKzrYl+SzTdcjAZM7xii4FxAbSHyen0oW5BrVxZSsM50BHi/ZyUQTQ5j 4leh2YM5XIzHUD6lRy3l21T2LyGThmW94iM1pGhM3dw5zNkn5Us0JfxYwVebO6krzCqwlug5EvA 4/loPUaKKgvGfVJS9u+mTBNS5OON+WTAcLU7L8VO8T/OXHKvk4wU4Iw9kgQj2hEowzhcMrSXVl6 4ikh8yfvKz6wCQ2tEHr5JxWKkGoPa4bzBCeHjIwzTf0hQJRBfVis2rUXH4YkJr+eBx6v18+/tBy 48HzxM3XndiVEvsm9We+txUv6m9733rc3aPFCBdxd9ya0QR1z1tEGgJvKC1BsTge5ZRUXt4xPM3 O7zhNz5BBgsH5bwPE8HFWQJdJzKI4WnJR5XRWrB/U4YBb6MAQW5Zd1j0H7Em2DmSSk422APf4Q9 wT+3PBIm9L1C05caRKTZnX9Llu5AsnhQVos39arpCaB4dv383yYGo7EnSaRDS7AkJDPZtAYVt4m EjU38PAi6oMdeURr7qRv5Jy1VN/mwA== X-Received: by 2002:a17:90a:3885:b0:3ad:3938:4444 with SMTP id 98e67ed59e1d1-3ad3938460fmr2410631a91.62.1792458101396; Mon, 19 Oct 2026 18:01:41 -0700 (PDT) Received: from ?IPV6:2600:1700:e321:62f0:da43:aeff:fecc:bfd5? ([2600:1700:e321:62f0:da43:aeff:fecc:bfd5]) by smtp.gmail.com with ESMTPSA id 98e67ed59e1d1-3ad5d4005b1sm1814815a91.6.2026.10.19.18.01.39 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 19 Oct 2026 18:01:40 -0700 (PDT) Sender: Guenter Roeck Message-ID: <8752c2d9-6b75-4793-8aeb-7d6f4a844d9c@roeck-us.net> Date: Mon, 19 Oct 2026 18:01:39 -0700 X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Post: List-Help: List-Subscribe: List-Unsubscribe: List-Owner: Precedence: list MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH 3/5] watchdog: gpio: Support watchdogs with a minimum heartbeat interval To: Florian Fainelli , linux-mips@vger.kernel.org Cc: Wim Van Sebroeck , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Bogendoerfer , Dmitry Torokhov , Bartosz Golaszewski , Jakub Kicinski , Andrew Lunn , Ethan Nelson-Moore , Eric Biggers , Greg Kroah-Hartman , Mingyu Wang <25181214217@stu.xidian.edu.cn>, Robert Marko , "open list:WATCHDOG DEVICE DRIVERS" , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" , open list , manuel.lauss@gmail.com References: <20261016221617.2223004-1-f.fainelli@gmail.com> <20261016221617.2223004-4-f.fainelli@gmail.com> Content-Language: en-US From: Guenter Roeck Autocrypt: addr=linux@roeck-us.net; keydata= xsFNBE6H1WcBEACu6jIcw5kZ5dGeJ7E7B2uweQR/4FGxH10/H1O1+ApmcQ9i87XdZQiB9cpN RYHA7RCEK2dh6dDccykQk3bC90xXMPg+O3R+C/SkwcnUak1UZaeK/SwQbq/t0tkMzYDRxfJ7 nyFiKxUehbNF3r9qlJgPqONwX5vJy4/GvDHdddSCxV41P/ejsZ8PykxyJs98UWhF54tGRWFl 7i1xvaDB9lN5WTLRKSO7wICuLiSz5WZHXMkyF4d+/O5ll7yz/o/JxK5vO/sduYDIlFTvBZDh gzaEtNf5tQjsjG4io8E0Yq0ViobLkS2RTNZT8ICq/Jmvl0SpbHRvYwa2DhNsK0YjHFQBB0FX IdhdUEzNefcNcYvqigJpdICoP2e4yJSyflHFO4dr0OrdnGLe1Zi/8Xo/2+M1dSSEt196rXaC kwu2KgIgmkRBb3cp2vIBBIIowU8W3qC1+w+RdMUrZxKGWJ3juwcgveJlzMpMZNyM1jobSXZ0 VHGMNJ3MwXlrEFPXaYJgibcg6brM6wGfX/LBvc/haWw4yO24lT5eitm4UBdIy9pKkKmHHh7s jfZJkB5fWKVdoCv/omy6UyH6ykLOPFugl+hVL2Prf8xrXuZe1CMS7ID9Lc8FaL1ROIN/W8Vk BIsJMaWOhks//7d92Uf3EArDlDShwR2+D+AMon8NULuLBHiEUQARAQABzTJHdWVudGVyIFJv ZWNrIChMaW51eCBhY2NvdW50KSA8bGludXhAcm9lY2stdXMubmV0PsLBgQQTAQIAKwIbAwYL CQgHAwIGFQgCCQoLBBYCAwECHgECF4ACGQEFAmgrMyQFCSbODQkACgkQyx8mb86fmYGcWRAA oRwrk7V8fULqnGGpBIjp7pvR187Yzx+lhMGUHuM5H56TFEqeVwCMLWB2x1YRolYbY4MEFlQg VUFcfeW0OknSr1s6wtrtQm0gdkolM8OcCL9ptTHOg1mmXa4YpW8QJiL0AVtbpE9BroeWGl9v 2TGILPm9mVp+GmMQgkNeCS7Jonq5f5pDUGumAMguWzMFEg+Imt9wr2YA7aGen7KPSqJeQPpj onPKhu7O/KJKkuC50ylxizHzmGx+IUSmOZxN950pZUFvVZH9CwhAAl+NYUtcF5ry/uSYG2U7 DCvpzqOryJRemKN63qt1bjF6cltsXwxjKOw6CvdjJYA3n6xCWLuJ6yk6CAy1Ukh545NhgBAs rGGVkl6TUBi0ixL3EF3RWLa9IMDcHN32r7OBhw6vbul8HqyTFZWY2ksTvlTl+qG3zV6AJuzT WdXmbcKN+TdhO5XlxVlbZoCm7ViBj1+PvIFQZCnLAhqSd/DJlhaq8fFXx1dCUPgQDcD+wo65 qulV/NijfU8bzFfEPgYP/3LP+BSAyFs33y/mdP8kbMxSCjnLEhimQMrSSo/To1Gxp5C97fw5 3m1CaMILGKCmfI1B8iA8zd8ib7t1Rg0qCwcAnvsM36SkrID32GfFbv873bNskJCHAISK3Xkz qo7IYZmjk/IJGbsiGzxUhvicwkgKE9r7a1rOwU0ETofVZwEQALlLbQeBDTDbwQYrj0gbx3bq 7kpKABxN2MqeuqGr02DpS9883d/t7ontxasXoEz2GTioevvRmllJlPQERVxM8gQoNg22twF7 pB/zsrIjxkE9heE4wYfN1AyzT+AxgYN6f8hVQ7Nrc9XgZZe+8IkuW/Nf64KzNJXnSH4u6nJM J2+Dt274YoFcXR1nG76Q259mKwzbCukKbd6piL+VsT/qBrLhZe9Ivbjq5WMdkQKnP7gYKCAi pNVJC4enWfivZsYupMd9qn7Uv/oCZDYoBTdMSBUblaLMwlcjnPpOYK5rfHvC4opxl+P/Vzyz 6WC2TLkPtKvYvXmdsI6rnEI4Uucg0Au/Ulg7aqqKhzGPIbVaL+U0Wk82nz6hz+WP2ggTrY1w ZlPlRt8WM9w6WfLf2j+PuGklj37m+KvaOEfLsF1v464dSpy1tQVHhhp8LFTxh/6RWkRIR2uF I4v3Xu/k5D0LhaZHpQ4C+xKsQxpTGuYh2tnRaRL14YMW1dlI3HfeB2gj7Yc8XdHh9vkpPyuT nY/ZsFbnvBtiw7GchKKri2gDhRb2QNNDyBnQn5mRFw7CyuFclAksOdV/sdpQnYlYcRQWOUGY HhQ5eqTRZjm9z+qQe/T0HQpmiPTqQcIaG/edgKVTUjITfA7AJMKLQHgp04Vylb+G6jocnQQX JqvvP09whbqrABEBAAHCwWUEGAECAA8CGwwFAmgrMyQFCSbODQkACgkQyx8mb86fmYHlgg/9 H5JeDmB4jsreE9Bn621wZk7NMzxy9STxiVKSh8Mq4pb+IDu1RU2iLyetCY1TiJlcxnE362kj njrfAdqyPteHM+LU59NtEbGwrfcXdQoh4XdMuPA5ADetPLma3YiRa3VsVkLwpnR7ilgwQw6u dycEaOxQ7LUXCs0JaGVVP25Z2hMkHBwx6BlW6EZLNgzGI2rswSZ7SKcsBd1IRHVf0miwIFYy j/UEfAFNW+tbtKPNn3xZTLs3quQN7GdYLh+J0XxITpBZaFOpwEKV+VS36pSLnNl0T5wm0E/y scPJ0OVY7ly5Vm1nnoH4licaU5Y1nSkFR/j2douI5P7Cj687WuNMC6CcFd6j72kRfxklOqXw zvy+2NEcXyziiLXp84130yxAKXfluax9sZhhrhKT6VrD45S6N3HxJpXQ/RY/EX35neH2/F7B RgSloce2+zWfpELyS1qRkCUTt1tlGV2p+y2BPfXzrHn2vxvbhEn1QpQ6t+85FKN8YEhJEygJ F0WaMvQMNrk9UAUziVcUkLU52NS9SXqpVg8vgrO0JKx97IXFPcNh0DWsSj/0Y8HO/RDkGXYn FDMj7fZSPKyPQPmEHg+W/KzxSSfdgWIHF2QaQ0b2q1wOSec4Rti52ohmNSY+KNIW/zODhugJ np3900V20aS7eD9K8GTU0TGC1pyz6IVJwIE= In-Reply-To: <20261016221617.2223004-4-f.fainelli@gmail.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit On 10/16/26 15:16, Florian Fainelli wrote: > Read the optional hw-min-interval-ms property into min_hw_heartbeat_ms so > the watchdog core defers keepalives that would toggle the GPIO too soon. > Reject zero intervals and intervals at or above the hardware margin. > Devices without the property retain their existing behavior. > > Remove the arbitrary 65535 ms upper bound on hw_margin_ms as well. There > is no register width to constrain this software interval, and the MTX-1 > watchdog needs a larger margin with a 1600 ms minimum ping interval. > > Signed-off-by: Florian Fainelli For my reference: Reviewed-by: Guenter Roeck > --- > drivers/watchdog/gpio_wdt.c | 14 ++++++++++++-- > 1 file changed, 12 insertions(+), 2 deletions(-) > > diff --git a/drivers/watchdog/gpio_wdt.c b/drivers/watchdog/gpio_wdt.c > index ff323d6e692e..a431c77fa179 100644 > --- a/drivers/watchdog/gpio_wdt.c > +++ b/drivers/watchdog/gpio_wdt.c > @@ -138,10 +138,20 @@ static int gpio_wdt_probe(struct platform_device *pdev) > ret = device_property_read_u32(dev, "hw_margin_ms", &hw_margin); > if (ret) > return ret; > - /* Disallow values lower than 2 and higher than 65535 ms */ > - if (hw_margin < 2 || hw_margin > 65535) > + /* The core feeds the watchdog at half the hardware margin. */ > + if (hw_margin < 2) > return -EINVAL; > > + if (device_property_present(dev, "hw-min-interval-ms")) { > + ret = device_property_read_u32(dev, "hw-min-interval-ms", > + &priv->wdd.min_hw_heartbeat_ms); > + if (ret) > + return ret; > + if (!priv->wdd.min_hw_heartbeat_ms || > + priv->wdd.min_hw_heartbeat_ms >= hw_margin) > + return -EINVAL; > + } > + > priv->always_running = device_property_read_bool(dev, "always-running"); > > watchdog_set_drvdata(&priv->wdd, priv);