From: "Sugaya, Taichi" <sugaya.taichi@socionext.com>
To: Arnd Bergmann <arnd@arndb.de>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Slaby <jslaby@suse.com>,
Takao Orito <orito.takao@socionext.com>,
Kazuhiro Kasai <kasai.kazuhiro@socionext.com>,
Shinji Kanematsu <kanematsu.shinji@socionext.com>,
Jassi Brar <jaswinder.singh@linaro.org>,
Masami Hiramatsu <masami.hiramatsu@linaro.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
linux-serial@vger.kernel.org
Subject: Re: [PATCH] serial: Add Milbeaut serial control
Date: Wed, 27 Mar 2019 18:39:13 +0900 [thread overview]
Message-ID: <875480bf-42d1-1c88-1dc7-4895e15cb87f@socionext.com> (raw)
In-Reply-To: <CAK8P3a0Sx5vxbserW27KMPYnpLabPkGJZ_2iuW9y082oHiO+aQ@mail.gmail.com>
Hi
Thank you for your comments.
On 2019/03/26 18:57, Arnd Bergmann wrote:
> On Tue, Mar 26, 2019 at 10:13 AM Sugaya Taichi
> <sugaya.taichi@socionext.com> wrote:
>
>>
>> diff --git a/drivers/tty/serial/Kconfig b/drivers/tty/serial/Kconfig
>> index 72966bc..961519b 100644
>> --- a/drivers/tty/serial/Kconfig
>> +++ b/drivers/tty/serial/Kconfig
>> @@ -1582,6 +1582,32 @@ config SERIAL_RDA_CONSOLE
>> Say 'Y' here if you wish to use the RDA8810PL UART as the system
>> console. Only earlycon is implemented currently.
>>
>> +config SERIAL_MILBEAUT_USIO
>> + tristate "Milbeaut USIO/UART serial port support"
>> + depends on ARCH_MILBEAUT
>> + default y
>> + select SERIAL_CORE
>> + help
>> + This selects the USIO/UART IP found in Socionext Milbeaut SoCs.
>
> In general, it would be good to make it possible to build this on
> other architectures for better compile test coverage, e.g. like
>
> config SERIAL_MILBEAUT_USIO
> tristate "Milbeaut USIO/UART serial port support"
> depends on ARCH_MILBEAUT || COMPILE_TEST
> default ARCH_MILBEAUT
>
All right.
I agree with the style.
> You might need additional dependencies like 'depends on OF'
> to make this work reliably.
>
I got it.
I think the way is inserting "depends on OF" as a new line.
Thanks,
Sugaya Taichi
> Arnd
>
prev parent reply other threads:[~2019-03-27 9:39 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-03-26 9:12 Sugaya Taichi
2019-03-26 9:57 ` Arnd Bergmann
2019-03-27 9:39 ` Sugaya, Taichi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875480bf-42d1-1c88-1dc7-4895e15cb87f@socionext.com \
--to=sugaya.taichi@socionext.com \
--cc=arnd@arndb.de \
--cc=gregkh@linuxfoundation.org \
--cc=jaswinder.singh@linaro.org \
--cc=jslaby@suse.com \
--cc=kanematsu.shinji@socionext.com \
--cc=kasai.kazuhiro@socionext.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=masami.hiramatsu@linaro.org \
--cc=orito.takao@socionext.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®