From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mx0b-0031df01.pphosted.com (mx0b-0031df01.pphosted.com [205.220.180.131]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6F816406290 for ; Wed, 17 Jun 2026 13:26:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=205.220.180.131 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781702784; cv=none; b=TcEBRy5WJqvbgmhTPTV95zgfHCFvTC/BClaveX4Yiox6WK4cckKvGk4iOM/6ADdUybyLmOUG+rAb41lRZs5n7UapBsKg8wl5BUIyT/oqGEmXemqFmLYyD8FP7UjhWqs3rHF/yaKhC2fS+LESQBZwH0KIxgTJfRhy/Q+9LiT8k6s= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781702784; c=relaxed/simple; bh=inIcFos/x0jKX2o4+YkzqWsmsZsjP37LAPvUVyviBhY=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=nHjxQXFmOHmLiDHhr6lwinEjuXPtrRpLAF+jLiWZbAcTrmKIOBXTePcC6WtxqgXxLj8QZYWJ70dd4sq4ldCZDEjsnrrBbUaJkRw/g4Rgc0jT+HrvzoRj+k1zgkefZ3XhEai6xoVzBdJ75YXKAXQvgrK1HkSSQGuOZBDnbCFyeP8= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com; spf=pass smtp.mailfrom=oss.qualcomm.com; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b=NEXglQqI; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b=OWFAxz49; arc=none smtp.client-ip=205.220.180.131 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=oss.qualcomm.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=qualcomm.com header.i=@qualcomm.com header.b="NEXglQqI"; dkim=pass (2048-bit key) header.d=oss.qualcomm.com header.i=@oss.qualcomm.com header.b="OWFAxz49" Received: from pps.filterd (m0279868.ppops.net [127.0.0.1]) by mx0a-0031df01.pphosted.com (8.18.1.11/8.18.1.11) with ESMTP id 65H8Vx4R2056618 for ; Wed, 17 Jun 2026 13:26:22 GMT DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=qualcomm.com; h= cc:content-transfer-encoding:content-type:date:from:in-reply-to :message-id:mime-version:references:subject:to; s=qcppdkim1; bh= d9L8d92QIfTFBohwf+5AnyF8y9DpzmN6NgGQoafr83o=; b=NEXglQqIlMtqgrma PHQUKfyUIotdvE8l3OThso2pEag+QOXl1vPMOkYhE+1+q6EJlOP7Zw/LeHo9+6cN CdPkgLfjmpKYpW3BgXx/c55Xa+qv5gRrY1ozJfILgs9XisOenPf2WWvBMqcwPuyg 4PYPUeVkE3ej8fSwEPXrQ7MuUnnOPO2y0yTqiX5gfSh1hdSsLGDkQyhn4IqPfv7S M1s/nBUfY9CwCCZJxwwbDUnyEn9MMRbU/laP8+QVWTL911PQyKKBtVkXDrCPjFSV UC6NanZGe0D78dRVvIuRjCTDdI/7yBCZjwbC/WxDX11FrmfH6tiTfyR33fZwoxee RqLnnA== Received: from mail-ua1-f71.google.com (mail-ua1-f71.google.com [209.85.222.71]) by mx0a-0031df01.pphosted.com (PPS) with ESMTPS id 4eueesbb27-1 (version=TLSv1.3 cipher=TLS_AES_128_GCM_SHA256 bits=128 verify=NOT) for ; Wed, 17 Jun 2026 13:26:22 +0000 (GMT) Received: by mail-ua1-f71.google.com with SMTP id a1e0cc1a2514c-966d2f25b83so125040241.1 for ; Wed, 17 Jun 2026 06:26:22 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=oss.qualcomm.com; s=google; t=1781702782; x=1782307582; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=d9L8d92QIfTFBohwf+5AnyF8y9DpzmN6NgGQoafr83o=; b=OWFAxz49qZMMi+904yowz1cbhbf2d/Mw5N3cDN383lvDqgGDMB5rvjRgKuo1NuC6bs BkbucN00F7mh7Z4c8p0g7uWS6CZFzYhesbFDghnLM14FmsXgIgFI8mRccLAXVLhYfg8n qRd5/qTeHJbSMjb0e1cONSe5jdBJjGlqZAkxRNU9SQ5lkmHec+g6JyvH5BhzVM1w9zFN Jc2a4UTPvXaYWaffH84I1kwOV7CzTeUc/EaM20uSdQBSWiZzsPfrCtHvMn4rCs8+s0a5 Xlx//Et8G/w58CMfaFI6KxngpSgbE+nSdlARoo6d6XXuRIX0GUYBk2quOsAoIhljHvhn rZ2A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781702782; x=1782307582; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=d9L8d92QIfTFBohwf+5AnyF8y9DpzmN6NgGQoafr83o=; b=h/Xs6ymHcpEcoTlY+1SSZq9khKLZiyQTw4RuORBwxVCrJ2a4LQFHBKjw9MIploLzIG gU0BW9fOxpRvyUymeEXLLgjv50SnJcb2uNMeRX0Jr/kdeZl5JWwb0Pj0icWuvne2zcLH GaLpSOS9y5MzwICoDLCfPGtEBb791zVauSawBRhOioUPficm5WEAOEFFyEuajP2/2EXY 9M2L/f0PfBr2WRR/FvmhUsUBjVbyjgst7F+NlLRXM+iKBnY1DaxrYaMBBLrDx060t58E VjzkbAr1wd8GrM95j/+YbtINFJksgtVf6jAnl+qMJpL+QlMmVAy2d+0BFH+ay1iDjJgN sOqw== X-Forwarded-Encrypted: i=1; AFNElJ+qk6Ut1G6IkO+jhstQtBv+JXI8RU4oDUQNNn7V3Rc21YNFYZNRqg+UulNYQsgJUYEVoMnGJ71E55i8gOo=@vger.kernel.org X-Gm-Message-State: AOJu0YwH/USXzjE2vs4FSA/NqWhVfs1jUu/HYF0u7JzOfGr8cCuIr57a IWKHPCTdSGAQ/MINu1PcOtOjS2z9jx74T9jCzHh2z9tgT+27jRwZy1Hf0lxUJEqka/gwSYG8aYT nNzv49p/SdXcy/mi9AWN06yoIXplcbKImsEVrzPDsl58IRrdjibbwPpbXcKDMrL2xlhg= X-Gm-Gg: AfdE7cmfmYAY8qqfj7hYwQuAvBcDzie/yJnl3QLh67FeHaYYGrwWMsfe4dGGzlOrjuc Lqs/xocUsvVRUw6ZgGme+D39NEAwNLZ8ZN3uDiOLuwIaWOxxdUxw6kF7Q4pURUTlhD4WWU/zrer nNSzJpk9RQNWy+L6STs1TUy2ib93xTbmW95htsKq1GVBvGDWd1HIICZW5ZVls/UIPa5PaboLqT7 rHq5OEvL4aXQfr+uyYsiSFrj3p4izEBNYOs2m6JSV3b008rlM2SHdigkY5J8YSWkQMdbnKZaOir Csy7y11FZuDAnrTXIZuOjr8pT1MP0Dv9whwBmUI1vSmK4CfoTB//17O/cpDvJIAQPilbrzXrjI7 OqnrajIiNnWFCgjfX/KKhvzN3UYw7kqLvnes= X-Received: by 2002:a05:6102:3f0c:b0:6d1:8f7:18a5 with SMTP id ada2fe7eead31-7245d1f4fa6mr841356137.1.1781702781695; Wed, 17 Jun 2026 06:26:21 -0700 (PDT) X-Received: by 2002:a05:6102:3f0c:b0:6d1:8f7:18a5 with SMTP id ada2fe7eead31-7245d1f4fa6mr841342137.1.1781702781292; Wed, 17 Jun 2026 06:26:21 -0700 (PDT) Received: from [192.168.120.170] ([178.235.128.140]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-bfdb7b6d934sm799439166b.40.2026.06.17.06.26.18 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 17 Jun 2026 06:26:20 -0700 (PDT) Message-ID: <8754de51-bfbe-42f2-84bf-36cc000afa3f@oss.qualcomm.com> Date: Wed, 17 Jun 2026 15:26:18 +0200 Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v3 2/8] irqchip/qcom-pdc: Move all statics to struct pdc_desc To: Maulik Shah , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Thomas Gleixner , Linus Walleij Cc: linux-arm-msm@vger.kernel.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-gpio@vger.kernel.org, Sneh Mankad References: <20260616-hamoa_pdc_v3-v3-0-4d8e1504ea75@oss.qualcomm.com> <20260616-hamoa_pdc_v3-v3-2-4d8e1504ea75@oss.qualcomm.com> Content-Language: en-US From: Konrad Dybcio In-Reply-To: <20260616-hamoa_pdc_v3-v3-2-4d8e1504ea75@oss.qualcomm.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-Proofpoint-Spam-Info: AW1haW4tMjYwNjE3MDEyOCBTYWx0ZWRfX0KW36fv87vMJ mfnDmnW42UP2YS+YV6UFcr4qV3yn+sTSSRavDu+TJifB/VcIbNyxXbAFc5iAWpo09uWIdVeM/hE FJR6GRhqmGUIkvMA3H3uR6U5QQRaaPs= X-Proofpoint-ORIG-GUID: 3dCMBy5DGav7hKJGcCTNGiYinlJ19OBS X-Authority-Analysis: v=2.4 cv=R6oz39RX c=1 sm=1 tr=0 ts=6a32a07e cx=c_pps a=KB4UBwrhAZV1kjiGHFQexw==:117 a=PRfkaYvzSr8QmIIGAkY2Sg==:17 a=IkcTkHD0fZMA:10 a=FelO9ux0wxsA:10 a=s4-Qcg_JpJYA:10 a=VkNPw1HP01LnGYTKEx00:22 a=u7WPNUs3qKkmUXheDGA7:22 a=ZpdpYltYx_vBUK5n70dp:22 a=EUspDBNiAAAA:8 a=YnNygKpUfyAIgCZGubgA:9 a=QEXdDO2ut3YA:10 a=o1xkdb1NAhiiM49bd1HK:22 X-Proofpoint-GUID: 3dCMBy5DGav7hKJGcCTNGiYinlJ19OBS X-Proofpoint-Spam-Details-Enc: AW1haW4tMjYwNjE3MDEyOCBTYWx0ZWRfXzARJhE5WxEK8 vlGclxg2OLXDlSk05ZxIPWy7J84tqdNN/Fe2+QtS1fK0PNaSgP9Vu/ugb9O9GsX4UFcXQNa8ZpG EYdosx/vJl+ors3337sHEGASigV5fmG1p/pYLzFcGk8IY4tN3JbPEuYMU62Co4kDBq03V3gamlT IxUnP4cNprNXKBUc4QKmLh/w7R5ZtjYmhV/GdGrQluSpol47QmdRh5yHfOm0IZm8qWKyANP/nNt PgL4W3kLNUx8plpA29WiSm/LF6/KzMkW3ltG+salWJHxs3glnpXPMUqo2D+1cKoH4wmD0GPcXQk 8CDyuO4pEd3VkBrlo0XChFnCcthRAIbfLeMZP3JxMi1oUjcc8qgocgBX2J3A5xRKv5iumI2M6PB /3Av8708RnBNKaP1Deldud1foBQi7xPz0wBqiTKHUbBD0bLQMQZUPX++f6pZ39NS9JNSAWoIYfV otrqh17K5k19F0hteLQ== X-Proofpoint-Virus-Version: vendor=baseguard engine=ICAP:2.0.293,Aquarius:18.0.1143,Hydra:6.1.125,FMLib:17.12.100.49 definitions=2026-06-17_01,2026-06-16_02,2025-10-01_01 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 spamscore=0 bulkscore=0 clxscore=1015 impostorscore=0 phishscore=0 lowpriorityscore=0 suspectscore=0 priorityscore=1501 malwarescore=0 adultscore=0 classifier=typeunknown authscore=0 authtc= authcc= route=outbound adjust=0 reason=mlx scancount=1 engine=8.22.0-2606150000 definitions=main-2606170128 On 6/16/26 11:25 AM, Maulik Shah wrote: > There are multiple statics used. Move all to struct pdc_desc to better > align with versioning support. Document them. > > No functional impact. > > Signed-off-by: Maulik Shah > --- [...] > static void pdc_enable_intr(struct irq_data *d, bool on) > { > - unsigned long flags; > + guard(raw_spinlock)(&pdc->lock); tglx suggested to use guard(irq) around "the other callsite".. which I'm not sure where it'd be - maybe around __pdc_enable_intr() in pdc_setup_pin_mapping()? Otherwise this patch looks good to me Konrad