From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751377AbdK0IbI (ORCPT ); Mon, 27 Nov 2017 03:31:08 -0500 Received: from mailout1.w1.samsung.com ([210.118.77.11]:58723 "EHLO mailout1.w1.samsung.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751138AbdK0IbG (ORCPT ); Mon, 27 Nov 2017 03:31:06 -0500 DKIM-Filter: OpenDKIM Filter v2.11.0 mailout1.w1.samsung.com 20171127083104euoutp01f29e0a9a804e7e3b1e25e8c4c6cf3c9e~65CMI9r1N2681726817euoutp012 X-AuditID: cbfec7f2-f793b6d000003243-0a-5a1bcd4668de Subject: Re: [RFC 2/2] drivers: dma-mapping: parse per device reserved mem at probe time To: Peng Fan , hch@lst.de, robin.murphy@arm.com, gregkh@linuxfoundation.org, robh+dt@kernel.org, frowand.list@gmail.com Cc: iommu@lists.linux-foundation.org, linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, van.freenix@gmail.com From: Marek Szyprowski Message-id: <875c3a8c-a857-823e-0243-487d1dd9bee7@samsung.com> Date: Mon, 27 Nov 2017 09:31:00 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-version: 1.0 In-reply-to: <20171126131346.12532-2-peng.fan@nxp.com> Content-type: text/plain; charset="utf-8"; format="flowed" Content-transfer-encoding: 7bit Content-language: en-US X-Brightmail-Tracker: H4sIAAAAAAAAA02SfyyUcRzHfd1zzz0up6c75RNFu9U/misxe0KmZXra+iOrfxymG8+4ctgd J2x12EnHJNeGy48rYXFLEeGS3B1XqyxpKyX9kTpLbi01mqach81/r8/78/P93ZfgCPu5voQ8 M4dRZsoyxDgf6x39MxZ0/KWf9OBwJUY12ca4VN33fzhV0tyJU3c6Rtwp41AENTFQj1NL7b+4 lHbQxqOGf8ysUvkiL5pPmxpNiO43fOTRXe1XcHqowcSj9e/aEG2e1OD0fWefO73Q5X+KkPIj U5kMuZpRHog6y0/XP67lZVs8L2g+XEMaVMvXIQ8CyFCom7O6s7wDXk134jrEJ4RkCwKrbXk9 WEAw3vMF3+hw/K3isIlWBA6HFbGBA0GxvWi1iiBEpBSeTPm7dG+yHEHpTAdydXPIPLg9pVub hJPBoJtnWUBGwcxKDebqxch9MHv9sEveTiZCR3MfxpZsgyX99Bp7kGHw+cb79ZHh8HVFy2U5 ALpN8xyWfaBEO4m5bgByGYfZxpuIdRADjkozxrIIvtkf8FjeBRP68nX96qoZ7X6WaxGMzQtY jgCrfXx9mRdU99ZwXDcDKYCyUiFbQsNlZxXGykeh5OFW9nl6EEzZHKgKBRg22TFssmDYZMGw yYIRYe3Im8lVKdIYVYhEJVOocjPTJClZii60+qGer9h/9qHfT8MtiCSQ2FOw56SfVMiVqVX5 CgsCgiP2FpB5vlKhIFWWX8Aos5KVuRmMyoL8CEzsIzgiLY0XkmmyHOY8w2Qzyo2sO+Hhq0Gp W96EnFN7vXD7xDW3UCKfIjfRsYqgt5fmupMeFScPhDpPRxS2P9sb1hDbFlk4IEna6e9nrI4x 6vSmyf4TpkOSiv62yETPuNrd8ZLW5oQzhqbXM7c4vaNJ1nsXQ9TOlAR5YPDgSNmgc5FZ9jB4 F0Tq9XFmbn3haLpVXi25Gx0rxlTpsuBAjlIl+w/9NAnmTAMAAA== X-Brightmail-Tracker: H4sIAAAAAAAAA+NgFprIIsWRmVeSWpSXmKPExsVy+t/xq7puZ6WjDDoWclvMP3KO1WLmm/9s Fs2L17NZrFx9lMliwX5ri8u75rBZ/Fj1hdWide8RdouDH54AWd3f2R24PNbMW8PosXPWXXaP Tas62Tz2z13D7jH5xnJGj903G9g8Nr7bweTxeZNcAEcUl01Kak5mWWqRvl0CV8bkfTPYCw7x VDTcnsjYwDiDq4uRk0NCwETi+Z8JzBC2mMSFe+vZuhi5OIQEljBKfF28iRnCec4ocazhOhtI lbBAlETz3CawKhGBbkaJt9uXM4EkmAXKJZbuuwbVvpVR4seLEywgCTYBQ4mut11g3bwCdhJP /k0HinNwsAioSryYYgkSFhWIkZj44CIjRImgxI/J98BaOQXMJB7PvsUIMd9M4svLw6wQtrzE 5jVvmSFscYnm1pssExgFZyFpn4WkZRaSlllIWhYwsqxiFEktLc5Nzy020itOzC0uzUvXS87P 3cQIjKhtx35u2cHY9S74EKMAB6MSD6+Cj3SUEGtiWXFl7iFGCQ5mJRFegXKpKCHelMTKqtSi /Pii0pzU4kOM0hwsSuK8vXtWRwoJpCeWpGanphakFsFkmTg4pRoY3Yq+11hWVB+2aDp+W2Za yuvel+/62hjbZpq5RvY6BFk/mchZM32tmU5+UI6e8wxWN7eCQ/ckbMWTFTL+vyu/6lX2NSJZ KsJcLCY00/vkjYxT/yVzqlI5pR/Jcf98kcXiKh5uNa1x9n1poQ+pX07c71BoivQPOp2w+fl6 jwKl3I8yOy80ZSuxFGckGmoxFxUnAgCMopjopAIAAA== X-CMS-MailID: 20171127083102eucas1p29ffad8ea834eb64e9bc62a49e47d0e85 X-Msg-Generator: CA CMS-TYPE: 201P X-CMS-RootMailID: 20171126131432epcas4p23145c6f438f7f186545456960f284b91 X-RootMTR: 20171126131432epcas4p23145c6f438f7f186545456960f284b91 References: <20171126131346.12532-1-peng.fan@nxp.com> <20171126131346.12532-2-peng.fan@nxp.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi On 2017-11-26 14:13, Peng Fan wrote: > Invoke of_reserved_mem_device_init at dma_configure, then > there is no need to call of_reserved_mem_device_init in device > specific probe function. > > Signed-off-by: Peng Fan This has been already tried long time ago, without success: http://patches.linaro.org/patch/33558/ > --- > drivers/base/dma-mapping.c | 6 +++++- > 1 file changed, 5 insertions(+), 1 deletion(-) > > diff --git a/drivers/base/dma-mapping.c b/drivers/base/dma-mapping.c > index e584eddef0a7..55dca06a7b55 100644 > --- a/drivers/base/dma-mapping.c > +++ b/drivers/base/dma-mapping.c > @@ -12,6 +12,7 @@ > #include > #include > #include > +#include > #include > #include > > @@ -351,7 +352,9 @@ int dma_configure(struct device *dev) > } > > if (dma_dev->of_node) { > - ret = of_dma_configure(dev, dma_dev->of_node); > + ret = of_reserved_mem_device_init(dev); > + if (ret) > + ret = of_dma_configure(dev, dma_dev->of_node); > } else if (has_acpi_companion(dma_dev)) { > attr = acpi_get_dma_attr(to_acpi_device_node(dma_dev->fwnode)); > if (attr != DEV_DMA_NOT_SUPPORTED) > @@ -367,5 +370,6 @@ int dma_configure(struct device *dev) > void dma_deconfigure(struct device *dev) > { > of_dma_deconfigure(dev); > + of_reserved_mem_device_release(dev); > acpi_dma_deconfigure(dev); > } Best regards -- Marek Szyprowski, PhD Samsung R&D Institute Poland