From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.3 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS, USER_AGENT_SANE_1 autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B2875ECE58D for ; Fri, 11 Oct 2019 19:26:16 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 82267206CD for ; Fri, 11 Oct 2019 19:26:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="M3PBlTde" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1729006AbfJKT0P (ORCPT ); Fri, 11 Oct 2019 15:26:15 -0400 Received: from mail-wm1-f42.google.com ([209.85.128.42]:39456 "EHLO mail-wm1-f42.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1728903AbfJKT0O (ORCPT ); Fri, 11 Oct 2019 15:26:14 -0400 Received: by mail-wm1-f42.google.com with SMTP id v17so11216642wml.4; Fri, 11 Oct 2019 12:26:11 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=uKbKcTI5oAu/5J+XUGF85siQfBKYiDyHMWqEMwYb3R8=; b=M3PBlTde+MQ1+upfHsMK7J1Rxi1Sbp1QyTwJb1ai1/tWQ1T5HfrpwfLhTOidEyJWIM LfHHmr9eUbPEZj5Fbc5wReHWhd3fl3Pkgac9dAMsCWDIlFF6jGpcJvoR/tdEt5a1Qg3k 9esVR8sKhexmXHJE+NRZKix8cYUI+Jp0X3qCdztQDIzi1nM8tvL/zO3dDUYSzYTsvm++ WeZU/wTB9aOTJ6tj0yBj9z7xNiYC+djytNNo+MU9ImpmnkUGpySmL8ghPJLFhlGmuciH pmnCKBupN73ORJghz7tEkuNO+bbChEuGNpeVV088rojs4ZBtpF31LL/ZZEt6rnOoc4wd k8yQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=uKbKcTI5oAu/5J+XUGF85siQfBKYiDyHMWqEMwYb3R8=; b=NEcNn8+r8cHF6wXYEZPIqQJbLEWDVbuQ6E9OKDtFp7epkAzkX791NdoyvkU8LiJ6mD TwPN5RcWOXmkKjeyZi9XERbtkgvi6luIU5gxSCdD12rK/Z9WS4/QgA5aFQ/OalASsGIn yq08AvVo+0OttLvfwX3yQK+B0kVRNBd0JRSCaBF7iPMv+S9ZySt/86WjvQA8Lg9aR9pW SXphFKuwQD/MOxHn7r4MRdJ3/IDK5iSCEqs9XNHA50P9VcbIUGpuRy1eW8GxZzZoU2p/ hgJyTPxEsXdDa16yn72j0BMc3GoICd7rB39gPe3+UY2fd84spWiuHdssp8u0/1P3YdpO EIKw== X-Gm-Message-State: APjAAAWH93GneB48m6SxfqdtHro0b6TvTLqYQnmeRcbv0yoyjjX8YZM9 WJMcbmBGBYhuV7XHuOF3zeu6cym7 X-Google-Smtp-Source: APXvYqy3NsrGaARW3kWkbuyvJuNZIETQM9FRnCxjAmy2sTTH2QIV8nAEpj1KyvMPmkOHYi91kDn4SQ== X-Received: by 2002:a05:600c:21da:: with SMTP id x26mr4459742wmj.152.1570821971183; Fri, 11 Oct 2019 12:26:11 -0700 (PDT) Received: from ?IPv6:2003:ea:8f26:6400:a940:7bc:76e0:c57? (p200300EA8F266400A94007BC76E00C57.dip0.t-ipconnect.de. [2003:ea:8f26:6400:a940:7bc:76e0:c57]) by smtp.googlemail.com with ESMTPSA id g185sm13491613wme.10.2019.10.11.12.26.10 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 11 Oct 2019 12:26:10 -0700 (PDT) Subject: Re: Module loading problem since 5.3 To: Luis Chamberlain Cc: linux-kernel@vger.kernel.org, netdev@vger.kernel.org, Andrew Lunn , Florian Fainelli References: <8132cf72-0ae1-48ae-51fb-1a01cf00c693@gmail.com> From: Heiner Kallweit Message-ID: <875eecfb-618a-4989-3b9f-f8272b8d3746@gmail.com> Date: Fri, 11 Oct 2019 21:26:05 +0200 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 10.10.2019 19:15, Luis Chamberlain wrote: > > > On Thu, Oct 10, 2019, 6:50 PM Heiner Kallweit > wrote: > >    MODULE_SOFTDEP("pre: realtek") > > Are you aware of any current issues with module loading > that could cause this problem? > > > Nope. But then again I was not aware of MODULE_SOFTDEP(). I'd encourage an extension to lib/kmod.c or something similar which stress tests this. One way that comes to mind to test this is to allow a new tests case which loads two drives which co depend on each other using this macro. That'll surely blow things up fast. That is, the current kmod tests uses request_module() or get_fs_type(), you'd want a new test case with this added using then two new dummy test drivers with the macro dependency. > > If you want to resolve this using a more tested path, you could have request_module() be used as that is currently tested. Perhaps a test patch for that can rule out if it's the macro magic which is the issue. > >   Luis > Maybe issue is related to a bug in introduction of symbol namespaces, see here: https://lkml.org/lkml/2019/10/11/659 Heiner