mirror of https://lore.kernel.org/lkml/
 help / color / mirror / Atom feed
From: Takashi Iwai <tiwai@suse.de>
To: Slavin Liu <bolin.liu@seu.edu.cn>
Cc: perex@perex.cz, tiwai@suse.com, linux-sound@vger.kernel.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ALSA: hda: trace PCM open only after assigning a stream
Date: Mon, 14 Sep 2026 18:10:55 +0200	[thread overview]
Message-ID: <875x07oltc.wl-tiwai@suse.de> (raw)
In-Reply-To: <20260913125154.109944-1-bolin.liu@seu.edu.cn>

On Sun, 13 Sep 2026 14:51:54 +0200,
Slavin Liu wrote:
> 
> Stream assignment can fail when hardware streams are exhausted.
> Move the tracepoint after the NULL check because its payload accesses
> the assigned stream tag.
> 
> Detected by static analysis and reviewed with AI-assisted source auditing.
> 
> Fixes: 184865085b88 ("ALSA: hda - rename hda_intel_trace.h to hda_controller_trace.h")
> Assisted-by: LLM
> Signed-off-by: Slavin Liu <bolin.liu@seu.edu.cn>

Applied now.

I think I wanted to track the error state, too, and that's likely the
reason the code was put there.  But, judging from the current code,
better to move as in this patch in the end.


thanks,

Takashi

      reply	other threads:[~2026-09-14 16:11 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-13 12:51 Slavin Liu
2026-09-14 16:10 ` Takashi Iwai [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=875x07oltc.wl-tiwai@suse.de \
    --to=tiwai@suse.de \
    --cc=bolin.liu@seu.edu.cn \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sound@vger.kernel.org \
    --cc=perex@perex.cz \
    --cc=tiwai@suse.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®