From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 1D0D135C188 for ; Wed, 20 May 2026 07:40:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779262825; cv=none; b=SV+3H6mH6cqQGiP0ltbvTnMaO8tj3/8CZhvSONIGAC2fHhXGCVzxnoKT7fQ0YIYm/J608FyKLcbY/kE4KCJotXmyK/3LLxtRVm0La9HKiSyTzCkIJ5wJYK7ko3gUsbZtQdTj9PcNRMB+aRt3j0A0PNX2l9j6GidYuau1vSbWnD0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1779262825; c=relaxed/simple; bh=i6oTUZUokHLIfpcnZn0aUGeo+uGCnRKdvKovslBQSY4=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=hpp69AGCIl28+HF63vvFhzxwl0VxWUzOK1tz5t7t4HEc/XkSn1Y40B+UX33gXX8Zq7/X6LlaxB04l7EnR1N/UcfLsE3U/FFWERZx972uo9wicv67a2mYT1tPaYNBiYX900ZBpAWWZv7HPJKgdXkugQvfxjGFvnD5C7kD4mBytv0= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=hmW6n7xW; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=bmO4V+tD; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="hmW6n7xW"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="bmO4V+tD" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1779262823; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=0BTWTApFCbsMsSyvfrQOGSrxC79mvO1+CZfSBBZN5ls=; b=hmW6n7xWYifYz8Yt8eMatT/5ZGDOe/7rctQfCqTQlOQ/0PG/vxHU+3Jlu1t8e5Ja6QvbeX slDcV6Nk0/uJfkReKzhplp9t4W1ozBDQZc4Eb7FR4Fm0K7rKqw1KUsTjnP+5yEMvwKUjmO DD0kZbnRhpLdqLMPM0+3aJaGJSEZD9U= Received: from mail-wm1-f69.google.com (mail-wm1-f69.google.com [209.85.128.69]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-332--plKFqnTOTm36ZJiiTNPvQ-1; Wed, 20 May 2026 03:40:20 -0400 X-MC-Unique: -plKFqnTOTm36ZJiiTNPvQ-1 X-Mimecast-MFC-AGG-ID: -plKFqnTOTm36ZJiiTNPvQ_1779262820 Received: by mail-wm1-f69.google.com with SMTP id 5b1f17b1804b1-48fdad6cce4so18726295e9.1 for ; Wed, 20 May 2026 00:40:20 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1779262819; x=1779867619; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=0BTWTApFCbsMsSyvfrQOGSrxC79mvO1+CZfSBBZN5ls=; b=bmO4V+tDjQeLjn1UiQuD3HMrvqX88zOHeabKTvj7xviDyMMb/T/b8d3URjg0b6we6X LwnyfbieVun3zAHcw7x12phhEXASvFXvHOx4nwRFVsHbcOIH+amE4GYjslnKSi9OQBaI yL2AyVkyGb78hVtq/EqLz1LP7S6P+BL61rYs/6oFwq+0lIhlQWe/AWYiBczhsNleH++S FzBQHNg4PrRoYjIAHsAoEK4DOFPWVWq9yU7JPYD6OMEv2E8kAZZFlZ7YZQg9pGbzHJq7 Y3K/bmIifwPNOJ+BR7knnwBpaXmEQUW4YHYly02VObI4pd7hch59vJ1mtVXLFORvIGml NmbQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1779262819; x=1779867619; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=0BTWTApFCbsMsSyvfrQOGSrxC79mvO1+CZfSBBZN5ls=; b=C7TvlQ6PqwPxNCqv8QX1l4A3Louz7GUVMSPzjaXbWkpPhjAwOBfwzfsfSWcg9nO0Cz blnCzbsNGv+lvXkuYCzffG+91R23unkc4AdcBSEOLv2DqzDUTzrpNKzp4vxHg5BqZCkx fdg+2lbdP5I1oIavqbHuirdCgH0JoMpTk4Dfys0THpaa8f2hl7XBJUfdpHLd3im5Ng+E dmI3eGz9Pbksxezr1jv11Qw/Z0nYlMda4ZycWWUIPTAF/d2OaXsu9bZRX0V9CCHANrhg 4vdiF58esZ3qKkA2AMU7sSwjMxOxbXdWHAs6/glx5rQ43yemSc5mUNoIomcG88nPOf/I m7tw== X-Forwarded-Encrypted: i=1; AFNElJ+6YSMRiYWR4nenceVB1T8V44mIxbNQYEG5+Edeqyhlu1d/zSsAXigJ/9zJ8uqMgb4fFml86SZB3Si7ZdE=@vger.kernel.org X-Gm-Message-State: AOJu0Yy8IAfclug+W9qQrwXZL61jlx3TwkISaRqKFOE7XETtHZ8ezicM yhN9v1EhmePwdLVc4hTwuR1IRf084HWkBTF5e7LNWC4XDzl8m0KbbcT4SHpo/MgDXNrIjtD5gB4 4s2OEvfoCgq/UMogoMj0yD8/Z8+EdRHT7jciiROLwujRvybmTuSQc0ivr8sdx8A8EjQ== X-Gm-Gg: Acq92OGoRDGQs6y/8tVRjwBui9ZuvbKv9v0LFFusNXnXwWSdz4LrLaDnq6hgNJEKH3q huvzbUYmabVyx0JEpnF2vUUhXcguJMPJfZad/BGqdS90scAlqGp3GeZcXFnV7MrOAC44+dQTBKA jDn0ntyeyuw/dj50+gH121nogBIYgdpNxLjpFoztCkN/N1bspLtgz6XrFtVOowLKGMz9PXMSgTf 90PhBMViQcgnUlYeC5nXEQHuFbMKjpOvcb1qfyWwsB8vKgN5TMRxAA59ydu+KMGL/4lf809J0aO yxjXwTivAfwJfmOzZrxq53T0+l39KkvMmCDDsFESHSvabqnAGfovKGkOHDVHSAOscWv0lZEYUva TxEzMzzFIYCucLGwkrzsbHHZ/pZBWXdvkPg3YZLJm49DmGVgCTrVDH0SWRv5KNaJGrmhU3AUPjd Dd73gA X-Received: by 2002:a05:600c:3b19:b0:490:f7c:b19 with SMTP id 5b1f17b1804b1-4900f7c0f52mr141631075e9.0.1779262819428; Wed, 20 May 2026 00:40:19 -0700 (PDT) X-Received: by 2002:a05:600c:3b19:b0:490:f7c:b19 with SMTP id 5b1f17b1804b1-4900f7c0f52mr141630755e9.0.1779262818939; Wed, 20 May 2026 00:40:18 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-49031731733sm2892285e9.0.2026.05.20.00.40.18 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 20 May 2026 00:40:18 -0700 (PDT) From: Javier Martinez Canillas To: Jani Nikula , linux-kernel@vger.kernel.org Cc: Maxime Ripard , David Airlie , Dmitry Baryshkov , Nicolas Frattaroli , Simona Vetter , dri-devel@lists.freedesktop.org Subject: Re: [PATCH 1/8] drm/display: hdmi: Add common TMDS character rate constants In-Reply-To: <78506dc5f7ff02a2bdd05de1170a1cb3e33e1abe@intel.com> References: <20260519144712.1418302-1-javierm@redhat.com> <20260519144712.1418302-2-javierm@redhat.com> <78506dc5f7ff02a2bdd05de1170a1cb3e33e1abe@intel.com> Date: Wed, 20 May 2026 09:40:17 +0200 Message-ID: <875x4iy1em.fsf@ocarina.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Jani Nikula writes: Hello Jani, > On Tue, 19 May 2026, Javier Martinez Canillas wrote: [...] >> >> +/* HDMI spec TMDS character rate limits (in Hz) */ >> +#define DRM_HDMI_TMDS_CHAR_RATE_MIN 25000000 >> +#define DRM_HDMI_TMDS_CHAR_RATE_MAX_1_0 165000000 >> +#define DRM_HDMI_TMDS_CHAR_RATE_MAX_1_3 340000000 >> +#define DRM_HDMI_TMDS_CHAR_RATE_MAX_2_0 600000000 > > Usually everything in DRM is in kHz, and Hz is the exception. > That is correct but in this case these constants are to be used with the HDMI helpers. Both struct drm_connector_hdmi_state.tmds_char_rate and the struct drm_bridge_funcs.hdmi_tmds_char_rate_valid() callback expect the TMDS char rate to be defined in Hz. If we define these in kHz, it means that drivers will have to * 1000 at every call site. > I'm also not sure the 1_0, 1_3, and 2_0 really help anyone reading the > code. I won't remember what they mean in Hz or kHz, and I'll have to > look them up every single time. > I discussed this with Maxime before posting the patches since I wondered the same. He suggested that the max TMDS character rate was linked to the HDMI spec versions and that it would be more readable to name it using the spec version rather than the resolution. The other naming I suggested was: /* HDMI spec TMDS character rate limits (in Hz) */ #define DRM_HDMI_TMDS_CHAR_RATE_MIN 25000000 #define DRM_HDMI_TMDS_CHAR_RATE_74_25MHZ 74250000 #define DRM_HDMI_TMDS_CHAR_RATE_148_5MHZ 148500000 #define DRM_HDMI_TMDS_CHAR_RATE_297MHZ 297000000 #define DRM_HDMI_TMDS_CHAR_RATE_MAX_1_4 340000000 > BR, > Jani. > -- Best regards, Javier Martinez Canillas Core Platforms Red Hat