From: Peter Korsgaard <peter@korsgaard.com>
To: John Keeping <jkeeping@inmusicbrands.com>
Cc: linux-usb@vger.kernel.org,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Jiri Kosina <jikos@kernel.org>,
Yuhao Jiang <danisjiang@gmail.com>,
Ben Hoff <hoff.benjamin.k@gmail.com>,
Michael Kelley <mhklinux@outlook.com>,
Terry Junge <linuxhid@cosmicgizmosystems.com>,
William Wu <william.wu@rock-chips.com>,
Kees Cook <kees@kernel.org>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] usb: gadget: f_hid: fix SuperSpeed descriptors
Date: Fri, 27 Feb 2026 17:22:41 +0100 [thread overview]
Message-ID: <875x7iqhpq.fsf@dell.be.48ers.dk> (raw)
In-Reply-To: <20260227111540.431521-1-jkeeping@inmusicbrands.com> (John Keeping's message of "Fri, 27 Feb 2026 11:15:39 +0000")
>>>>> "John" == John Keeping <jkeeping@inmusicbrands.com> writes:
> When adding dynamic configuration for bInterval, the value was removed
> from the static SuperSpeed endpoint descriptors but was not set from the
> configured value in hidg_bind(). Thus at SuperSpeed the interrupt
> endpoints have bInterval as zero which is not valid per the USB
> specification.
> Add the missing setting for SuperSpeed endpoints.
> Fixes: ea34925f5b2ee ("usb: gadget: hid: allow dynamic interval configuration via configfs")
> Signed-off-by: John Keeping <jkeeping@inmusicbrands.com>
Acked-by: Peter Korsgaard <peter@korsgaard.com>
--
Bye, Peter Korsgaard
prev parent reply other threads:[~2026-02-27 16:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-02-27 11:15 John Keeping
2026-02-27 16:22 ` Peter Korsgaard [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875x7iqhpq.fsf@dell.be.48ers.dk \
--to=peter@korsgaard.com \
--cc=danisjiang@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=hoff.benjamin.k@gmail.com \
--cc=jikos@kernel.org \
--cc=jkeeping@inmusicbrands.com \
--cc=kees@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=linuxhid@cosmicgizmosystems.com \
--cc=mhklinux@outlook.com \
--cc=william.wu@rock-chips.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®