From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from relay5-d.mail.gandi.net (relay5-d.mail.gandi.net [217.70.183.197]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 0D2E913A3EC; Thu, 14 Nov 2024 10:41:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=217.70.183.197 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731580903; cv=none; b=JX2IY9vHb699fhG1PSvFzh6xFYBIxKxWcnrCvaid/MPPpK9TMyoEgCKCAnoBDOWeYP/mcNPFwvflyro9vrjYfIUnqIbWfh+NjbUb5juW0UrAbKbFzIMQ5iT7QzLqAGHFCTW2dMWQoFQ6eFzPS0pFFwpHGU2C8yj1UzjXrTgCzvs= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1731580903; c=relaxed/simple; bh=5/XN2yxVu+U9puVJG+0u6hyp9c6YHtVO/9QbauFX12I=; h=From:To:Cc:Subject:References:Date:In-Reply-To:Message-ID: MIME-Version:Content-Type; b=lBQ1ige5ftGSPYZQfyLDpkT9KryPh3/jQjXKTMsv5DmhgjtVaJ2xDnaIDHmC36wIF5BY/mcRlX9EiZwWCTNvsDZO4R3OH7huFeGPB2rbLZWGxSb/NbjNmDZEbKk/B+wiJMDiyKlHclAacRvDx14wBKweU30yl8jWgJtOJPG5Swk= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=korsgaard.com; spf=pass smtp.mailfrom=korsgaard.com; arc=none smtp.client-ip=217.70.183.197 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=korsgaard.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=korsgaard.com Received: by mail.gandi.net (Postfix) with ESMTPSA id D61E61C000E; Thu, 14 Nov 2024 10:41:35 +0000 (UTC) Received: from peko by dell.be.48ers.dk with local (Exim 4.96) (envelope-from ) id 1tBXI7-000g3w-0Z; Thu, 14 Nov 2024 11:41:35 +0100 From: Peter Korsgaard To: Elson Roy Serrao Cc: gregkh@linuxfoundation.org, michal.vrastil@hidglobal.com, michal.vodicka@hidglobal.com, linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH v2] Revert "usb: gadget: composite: fix OS descriptors w_value logic" References: <20241113235433.20244-1-quic_eserrao@quicinc.com> Date: Thu, 14 Nov 2024 11:41:35 +0100 In-Reply-To: <20241113235433.20244-1-quic_eserrao@quicinc.com> (Elson Roy Serrao's message of "Wed, 13 Nov 2024 15:54:33 -0800") Message-ID: <875xoqxfkw.fsf@dell.be.48ers.dk> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/28.2 (gnu/linux) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain X-GND-Sasl: peter@korsgaard.com >>>>> "Elson" == Elson Roy Serrao writes: > From: Michal Vrastil > This reverts commit ec6ce7075ef879b91a8710829016005dc8170f17. > Fix installation of WinUSB driver using OS descriptors. Without the > fix the drivers are not installed correctly and the property > 'DeviceInterfaceGUID' is missing on host side. > The original change was based on the assumption that the interface > number is in the high byte of wValue but it is in the low byte, > instead. Unfortunately, the fix is based on MS documentation which is > also wrong. > The actual USB request for OS descriptors (using USB analyzer) looks > like: > Offset 0 1 2 3 4 5 6 7 > 0x000 C1 A1 02 00 05 00 0A 00 > C1: bmRequestType (device to host, vendor, interface) > A1: nas magic number > 0002: wValue (2: nas interface) > 0005: wIndex (5: get extended property i.e. nas interface GUID) > 008E: wLength (142) > The fix was tested on Windows 10 and Windows 11. > Cc: stable@vger.kernel.org > Fixes: ec6ce7075ef8 ("usb: gadget: composite: fix OS descriptors w_value logic") > Signed-off-by: Michal Vrastil > Signed-off-by: Elson Roy Serrao Acked-by: Peter korsgaard -- Bye, Peter Korsgaard