From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f42.google.com (mail-ej1-f42.google.com [209.85.218.42]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 6837616EC19 for ; Thu, 1 Aug 2024 08:57:30 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.42 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722502653; cv=none; b=FVqBOc9+PaUGEWfCDdfdIKnkpashldpNELNxtdYpP+PEGXpE0fveExto9iJErgmmXZtRRYV0X5vRBr3KFe5LVHjCiUulJGovdp6d0eV5ZePP35Fb2zC78GJaVatM3ay3Mo7YVPV4VJuHdrLypIN8qN4Buk04bvmcSQRQb6D+1VQ= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1722502653; c=relaxed/simple; bh=JtRBSdBvaqBsQtNVvhstlkMyWmalBV9Q7J8Cb3IfAjw=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=bkzCUaBZSu1w2PPZfENsjq3ISgnStrZqQgVU4QWUrqRBCNwggSiuEyZJfrvUz4Mq/LqXmVAY5IwpXW0shbHLsaKDtyTWemV+nG4ZkTJxQnBXeRHi8h9LFe4mn2wO0be0YixwcBWiBqdPA2yLVOZrMBfAcncD1OZZLwJFJCC5WO4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org; spf=pass smtp.mailfrom=linaro.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b=HLluQB1y; arc=none smtp.client-ip=209.85.218.42 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=linaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=linaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="HLluQB1y" Received: by mail-ej1-f42.google.com with SMTP id a640c23a62f3a-a7abf92f57bso876554566b.2 for ; Thu, 01 Aug 2024 01:57:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1722502649; x=1723107449; darn=vger.kernel.org; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:from:to:cc:subject:date:message-id :reply-to; bh=Syi3zSlJ8k1vqxBzUq6nZD+avtMgHQU+/NZ7B5gDmQ4=; b=HLluQB1yEDz5YjrqGn3CbV5T6LoGT61JO9LW6usM7k8ZL1wb1X0Jw47YEHur/NJx2Q HGCHnWf0Vn32449k3dQah72KnXB+GqO3IkHf8hZSEcr0r/u+AHMaEbj1FBRx/HwPd/lo Vqt1wEVh44XyBihgQDXMm3b7+D3w78KpK4SxsLsly5xhZMOIuhfNwH9gb64nGyaHEsVh KGGyfQtANKUJWcATdRcK2g93ocJL2eD+YTa80l3Uj3IMSL3IpjPRLZiUhyYo+8EbnRdI h7AmHv80Zoa4/Z3SeyMUbjhm8RXP7DvzwElnQRQkfAA+gBHG+aFeeIkl5eRaTbRgQFgs v3aQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1722502649; x=1723107449; h=content-transfer-encoding:mime-version:message-id:date:references :in-reply-to:subject:cc:to:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=Syi3zSlJ8k1vqxBzUq6nZD+avtMgHQU+/NZ7B5gDmQ4=; b=ATJq/2Mm77BAmUMZD9QnMjtAiwQoEZIWrGyxiNt0sDokRX9rReHF2dfm3sQqelEwNB Gb0Psq+45LaqjS38/C8z1WVTDutuA7yNY82QyG6LpRcAe3ltAHFA9BfkFJsRBqOhaa7e /s1MTuQVcaX+721ZvVsFvA2wGQPNi94d5Gv1GgoKoO1h/O6uSNvDL61BpBEfEKv9dX4u 787ZYZ91SBdPw/P8MWQBZkolafRm0Qvn24PtZy+YS2CCQFqRXEdrNi9HRmdHy0Pr8n5n SCVKySmZ0+/qluhAtxzPGyfW+NvzMqxvdM9I5i8WofD2g+qUQCNpiTiuEIYEfS9B4PAs 74WQ== X-Forwarded-Encrypted: i=1; AJvYcCVxYXVCzuOTRYEmGYjOairqoHo3pxwIxTOdNALVxAkBDAyD5S3aoSMRoKZ2RNaYYcv+LRqQf/+Nsua04yQ1Ye6fZTjhPXyKd0z+keR9 X-Gm-Message-State: AOJu0YzjqloLIQrBtrnRGHE52duhSU4lTfhCuN8jILqogxQwmbUswMzH C2NTpJHLBrYze/pwkV1jymTk4Wv44DG+PpNnn0eIa/gEjlmyXlgxpXmO/TF+1ng= X-Google-Smtp-Source: AGHT+IEdS3NM6t6Y7T/95sEL4C7ubpn/6F0Cu3mCtANczyd9mmWSLE4tcyyhWaOoIZKPq4CsXdarWQ== X-Received: by 2002:a17:907:6d0e:b0:a75:1069:5b94 with SMTP id a640c23a62f3a-a7daf535320mr136914966b.21.1722502647807; Thu, 01 Aug 2024 01:57:27 -0700 (PDT) Received: from draig.lan ([85.9.250.243]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7acadb82d5sm865337466b.199.2024.08.01.01.57.27 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 01 Aug 2024 01:57:27 -0700 (PDT) Received: from draig (localhost [IPv6:::1]) by draig.lan (Postfix) with ESMTP id 3FE7E5F80C; Thu, 1 Aug 2024 09:57:26 +0100 (BST) From: =?utf-8?Q?Alex_Benn=C3=A9e?= To: Sean Christopherson Cc: Paolo Bonzini , Marc Zyngier , Oliver Upton , Tianrui Zhao , Bibo Mao , Huacai Chen , Michael Ellerman , Anup Patel , Paul Walmsley , Palmer Dabbelt , Albert Ou , Christian Borntraeger , Janosch Frank , Claudio Imbrenda , kvm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, kvmarm@lists.linux.dev, loongarch@lists.linux.dev, linux-mips@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kvm-riscv@lists.infradead.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, David Matlack , David Stevens Subject: Re: [PATCH v12 03/84] KVM: Drop KVM_ERR_PTR_BAD_PAGE and instead return NULL to indicate an error In-Reply-To: <20240726235234.228822-4-seanjc@google.com> (Sean Christopherson's message of "Fri, 26 Jul 2024 16:51:12 -0700") References: <20240726235234.228822-1-seanjc@google.com> <20240726235234.228822-4-seanjc@google.com> Date: Thu, 01 Aug 2024 09:57:26 +0100 Message-ID: <875xskfwnd.fsf@draig.linaro.org> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Sean Christopherson writes: > Remove KVM_ERR_PTR_BAD_PAGE and instead return NULL, as "bad page" is just > a leftover bit of weirdness from days of old when KVM stuffed a "bad" page > into the guest instead of actually handling missing pages. See commit > cea7bb21280e ("KVM: MMU: Make gfn_to_page() always safe"). > > Signed-off-by: Sean Christopherson Reviewed-by: Alex Benn=C3=A9e --=20 Alex Benn=C3=A9e Virtualisation Tech Lead @ Linaro