From: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
To: Wenchao Hao <haowenchao2@huawei.com>,
Theodore Ts'o <tytso@mit.edu>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: louhongxiang@huawei.com, Wenchao Hao <haowenchao2@huawei.com>
Subject: Re: [PATCH] ext4: remove unused parameter biop in ext4_issue_discard()
Date: Mon, 26 Feb 2024 20:55:40 +0530 [thread overview]
Message-ID: <875xyb1c3v.fsf@doe.com> (raw)
In-Reply-To: <20240226081731.3224470-1-haowenchao2@huawei.com>
Wenchao Hao <haowenchao2@huawei.com> writes:
> all caller of ext4_issue_discard() would set biop to NULL since
> 'commit 55cdd0af2bc5 ("ext4: get discard out of jbd2 commit kthread
> contex")', it's unnecessary to keep this parameter any more.
>
> Signed-off-by: Wenchao Hao <haowenchao2@huawei.com>
Nice little cleanup. Feel free to add -
Reviewed-by: Ritesh Harjani (IBM) <ritesh.list@gmail.com>
next prev parent reply other threads:[~2024-02-26 15:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 8:17 Wenchao Hao
2024-02-26 14:06 ` Zhang Yi
2024-02-26 15:25 ` Ritesh Harjani [this message]
2024-03-14 3:54 ` Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875xyb1c3v.fsf@doe.com \
--to=ritesh.list@gmail.com \
--cc=adilger.kernel@dilger.ca \
--cc=haowenchao2@huawei.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=louhongxiang@huawei.com \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®