From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7C3CAEB64DC for ; Fri, 21 Jul 2023 14:22:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231802AbjGUOV7 (ORCPT ); Fri, 21 Jul 2023 10:21:59 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42702 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231734AbjGUOV5 (ORCPT ); Fri, 21 Jul 2023 10:21:57 -0400 Received: from smtp-out1.suse.de (smtp-out1.suse.de [IPv6:2001:67c:2178:6::1c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 07B212D6D for ; Fri, 21 Jul 2023 07:21:52 -0700 (PDT) Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by smtp-out1.suse.de (Postfix) with ESMTPS id B66AD21846; Fri, 21 Jul 2023 14:21:51 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_rsa; t=1689949311; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ysAjf4LaAMYK81D2vTaHAE6f/DlMCudpo3ZriX8GUwA=; b=UUujr/pt9EUeSV0flxzGlho75ibuqAHQ5eyLqBuvPQu+buTyk9lVNB4Cmv6neDEZ+Q55po VPqib/jyIWoXbNwdi3Vo1hDmWF26yzcTg+sVjVMUOcZn2gkvQbVBLfgehymq3/aL3DMzqg DZTYmhgA0iZ38CRqI9DWd+Tqfe+oPRE= DKIM-Signature: v=1; a=ed25519-sha256; c=relaxed/relaxed; d=suse.de; s=susede2_ed25519; t=1689949311; h=from:from:reply-to:date:date:message-id:message-id:to:to:cc:cc: mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=ysAjf4LaAMYK81D2vTaHAE6f/DlMCudpo3ZriX8GUwA=; b=OFnCMSO95Dml0FqzVI/VLkaZkkbmwKijXB4em4Y2GimQYV3QHr3iQZwKzUytxHGozsJG/C 59a/j1JTozvD8NBQ== Received: from imap2.suse-dmz.suse.de (imap2.suse-dmz.suse.de [192.168.254.74]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature ECDSA (P-521) server-digest SHA512) (No client certificate requested) by imap2.suse-dmz.suse.de (Postfix) with ESMTPS id 86D37134BA; Fri, 21 Jul 2023 14:21:51 +0000 (UTC) Received: from dovecot-director2.suse.de ([192.168.254.65]) by imap2.suse-dmz.suse.de with ESMTPSA id EpQEIH+UumRWCgAAMHmgww (envelope-from ); Fri, 21 Jul 2023 14:21:51 +0000 Date: Fri, 21 Jul 2023 16:21:51 +0200 Message-ID: <875y6dfips.wl-tiwai@suse.de> From: Takashi Iwai To: Andy Shevchenko Cc: alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org, Jaroslav Kysela , Takashi Iwai , Dan Williams Subject: Re: [PATCH v1 1/1] ALSA: korg1212: Re-use sockptr_t and respective APIs In-Reply-To: References: <20230721100146.67293-1-andriy.shevchenko@linux.intel.com> <878rb9h901.wl-tiwai@suse.de> <87y1j9fs55.wl-tiwai@suse.de> User-Agent: Wanderlust/2.15.9 (Almost Unreal) Emacs/27.2 Mule/6.0 MIME-Version: 1.0 (generated by SEMI-EPG 1.14.7 - "Harue") Content-Type: text/plain; charset=US-ASCII Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, 21 Jul 2023 14:58:05 +0200, Andy Shevchenko wrote: > > On Fri, Jul 21, 2023 at 12:58:14PM +0200, Takashi Iwai wrote: > > On Fri, 21 Jul 2023 12:42:08 +0200, > > Andy Shevchenko wrote: > > > On Fri, Jul 21, 2023 at 12:08:46PM +0200, Takashi Iwai wrote: > > > > On Fri, 21 Jul 2023 12:01:46 +0200, > > > > Andy Shevchenko wrote: > > ... > > > > > While I see the benefit, I feel this is very confusing. If we use the > > > > API for a generic use, it should be renamed at first. > > > > Any suggestion for the name? > > > > It's a universal pointer... uniptr_t? > > Or a generic pointer, genptr_t? > > > > I'm not good at naming, and I'm open for it. > > It seems it's already spread enough with this name, I would rather stick with > it for now (besides net it's used in crypto, nvme, and security). > > The (new) callback though makes a lot of sense on its own. OK, fair enough. > What do you think? Yes, we can go with it. Basically we need to add a new "copy" callback to take sockptr_t and use it instead of the old "copy_kernel" and "copy_user" callbacks. It's used only in sound/core/pcm_lib.c, so it shouldn't be too difficult, I suppose. Then replace the defined callbacks in each driver, and finally deprecate old callbacks. thanks, Takashi