From: Thomas Gleixner <tglx@linutronix.de>
To: Holger Schurig <holger.schurig@advantech.de>
Cc: "linux-kernel\@vger.kernel.org" <linux-kernel@vger.kernel.org>,
x86@kernel.org, Arnd Bergmann <arnd@arndb.de>
Subject: Re: BUG 5.5.6, from patch "cpu/SMT: Fix x86 link error without CONFIG_SYSFS"
Date: Sun, 26 Apr 2020 12:39:32 +0200 [thread overview]
Message-ID: <875zdmttsr.fsf@nanos.tec.linutronix.de> (raw)
In-Reply-To: <SG2PR02MB4299E161745C7938E32D4B70F7D30@SG2PR02MB4299.apcprd02.prod.outlook.com>
Holger,
Holger Schurig <holger.schurig@advantech.de> writes:
> if one compiled kernel 5.6.6 with CONFIG_HOTPLUG_CPU=n, then the
> compilation will fail. The reason is your patch, which introduces
> this:
> +int cpuhp_smt_disable(enum cpuhp_smt_control ctrlval)
It would have been more helpful to provide the actual commit SHA instead
of copying tons of patch code.
> It happens that cpu_down_maps_locked is only defined when
> CONFIG_HOTPLUG_CPU=y, but not otherwise.
Right.
> On my embedded target I so far had the CPU hotplugging off. After all,
> the CPU is physically soldered, there will never be a hotplugging
> happen.
CPU hotplug is used for far more than physical hotplug.
SMT control depends on it in order to apply speculation mitigations,
hibernation requires working CPU hotplug as well.
As the speculation mess requires SMT control we more or less have to
make CPU hotplug mandatory on x86...
Thanks,
tglx
parent reply other threads:[~2020-04-26 10:39 UTC|newest]
Thread overview: expand[flat|nested] mbox.gz Atom feed
[parent not found: <SG2PR02MB4299E161745C7938E32D4B70F7D30@SG2PR02MB4299.apcprd02.prod.outlook.com>]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=875zdmttsr.fsf@nanos.tec.linutronix.de \
--to=tglx@linutronix.de \
--cc=arnd@arndb.de \
--cc=holger.schurig@advantech.de \
--cc=linux-kernel@vger.kernel.org \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome