From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752608AbdHQKZa (ORCPT ); Thu, 17 Aug 2017 06:25:30 -0400 Received: from usa-sjc-mx-foss1.foss.arm.com ([217.140.101.70]:47800 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751687AbdHQKZZ (ORCPT ); Thu, 17 Aug 2017 06:25:25 -0400 From: Punit Agrawal To: "Luck\, Tony" Cc: "Rafael J. Wysocki" , Len Brown , Boris Petkov , Tyler Baicar , "linux-acpi\@vger.kernel.org" , "linux-kernel\@vger.kernel.org" Subject: Re: [PATCH] ACPI/APEI: Add BERT data driver References: <20170814165613.25561-1-tony.luck@intel.com> <87k225p1v5.fsf@e105922-lin.cambridge.arm.com> <20170815211556.nnnnbtlvorgc3ijh@intel.com> <87a82zpsd7.fsf@e105922-lin.cambridge.arm.com> <3908561D78D1C84285E8C5FCA982C28F61340302@ORSMSX114.amr.corp.intel.com> Date: Thu, 17 Aug 2017 11:25:23 +0100 In-Reply-To: <3908561D78D1C84285E8C5FCA982C28F61340302@ORSMSX114.amr.corp.intel.com> (Tony Luck's message of "Wed, 16 Aug 2017 15:22:44 +0000") Message-ID: <8760dmpk30.fsf@e105922-lin.cambridge.arm.com> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/25.2 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org "Luck, Tony" writes: >> One thing I missed commenting on in the previous version - >> >> Have you thought of exposing the error records via /sys/firmware/acpi? >> The tables are already exposed there and as BERT is part of ACPI >> logically that's a better fit compared to a misc device. > > That was my first thought :-) > > But I got stuck on how to name things. The BERT entry appears in > /sys/firmware/acpi/tables/ ... but the code doesn't know anything special > about "BERT", it just iterates over all the tables and makes them all > appear. > > I thought about making it /sys/firmware/acpi/tables/BERT.data, but that > seemed very ugly (this file isn't a "table", so why does it appear in the > "tables" directory? So maybe /sys/firmware/acpi/table-data/BERT? Now > the driver has to make another directory. > > Thoughts? I agree that keeping the error record out of the tables directory makes sense as it's not an ACPI table. The best I could come up with was bert-data or bert-region in /sys/firmware/acpi/apei/. Though, I am OK with "table-data/BERT" as well. > > -Tony > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html