From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1753062AbdBHQAf (ORCPT <rfc822;w@1wt.eu>);
        Wed, 8 Feb 2017 11:00:35 -0500
Received: from foss.arm.com ([217.140.101.70]:51180 "EHLO foss.arm.com"
        rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
        id S1752009AbdBHQAc (ORCPT <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 8 Feb 2017 11:00:32 -0500
From: Marc Zyngier <marc.zyngier@arm.com>
To: Robert Richter <robert.richter@cavium.com>
Cc: Shanker Donthineni <shankerd@codeaurora.org>,
        Thomas Gleixner <tglx@linutronix.de>,
        Jason Cooper <jason@lakedaemon.net>,
        <linux-arm-kernel@lists.infradead.org>, <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 1/9] irqchip/gic-v3-its: Fix command buffer allocation
In-Reply-To: <20170208153658.GT5020@rric.localdomain> (Robert Richter's
        message of "Wed, 8 Feb 2017 16:36:58 +0100")
Organization: ARM Ltd
References: <20170201173833.12630-1-rrichter@cavium.com>
        <20170201173833.12630-2-rrichter@cavium.com>
        <87tw847njl.fsf@on-the-bus.cambridge.arm.com>
        <20170208144328.GS5020@rric.localdomain>
        <278df776-4d6d-3b89-7a94-effaafcebeb0@codeaurora.org>
        <20170208153658.GT5020@rric.localdomain>
User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux)
Date: Wed, 08 Feb 2017 16:00:19 +0000
Message-ID: <8760kk7jvw.fsf@on-the-bus.cambridge.arm.com>
MIME-Version: 1.0
Content-Type: text/plain
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Wed, Feb 08 2017 at  3:36:58 pm GMT, Robert Richter <robert.richter@cavium.com> wrote:
> On 08.02.17 09:31:00, Shanker Donthineni wrote:
>> In teardown path, code is still calling 'kfree(its->cmd_base)' to free
>> memory, this should be changed to 'free_pages(get_order(ITS_CMD_QUEUE_SZ).
>
> Hmm, right. This is later removed in the series, but should be part of
> this patch. Should I respin this one?

Nope, I've hacked it.

Thanks,

	M.
-- 
Jazz is not dead, it just smell funny.