From: ebiederm@xmission.com (Eric W. Biederman)
To: Cyrill Gorcunov <gorcunov@gmail.com>
Cc: Kees Cook <keescook@chromium.org>,
Andrey Vagin <avagin@virtuozzo.com>,
LKML <linux-kernel@vger.kernel.org>,
Pavel Emelyanov <xemul@virtuozzo.com>,
Linux Containers <containers@lists.linux-foundation.org>,
Jann Horn <jann@thejh.net>
Subject: Re: [REVIEW][PATCH v2] mm: Add a user_ns owner to mm_struct and fix ptrace permission checks
Date: Thu, 27 Oct 2016 21:22:38 -0500 [thread overview]
Message-ID: <8760odnrf5.fsf@xmission.com> (raw)
In-Reply-To: <20161027223430.GC1922@uranus.lan> (Cyrill Gorcunov's message of "Fri, 28 Oct 2016 01:34:30 +0300")
Cyrill Gorcunov <gorcunov@gmail.com> writes:
> On Fri, Oct 28, 2016 at 12:39:18AM +0300, Cyrill Gorcunov wrote:
>> On Thu, Oct 27, 2016 at 10:54:34AM -0500, Eric W. Biederman wrote:
>> >
>> >
>> > I can't imagine either of these changes making a practical difference
>> > to anyone but I am calling them out in case someone can.
>> >
>> > include/linux/mm_types.h | 1 +
>> > kernel/fork.c | 9 ++++++---
>> > kernel/ptrace.c | 26 +++++++++++---------------
>> > mm/init-mm.c | 2 ++
>> > 4 files changed, 20 insertions(+), 18 deletions(-)
>>
>> Thanks a huge, Eric! And really sorry for delay in response,
>> I managed to miss this quite important mail for me in mail
>> storm. Gonna test it and will write you the results. Overall looks
>> great, but better be sure and run the tests.
>>
>> Reviewed-by: Cyrill Gorcunov <gorcunov@openvz.org>
>
> Eric, on which kernel the patch is on top of?
> It doesn't apply on linux-next for some reason.
>
> | Date: Thu Oct 27 14:21:59 2016 +1100
> |
> | Add linux-next specific files for 20161027
> |
> | Signed-off-by: Stephen Rothwell <sfr@canb.auug.org.au>
>
> I applied it on Linus' master and tests passed fine
> (but they were passing fine even without the patch,
> only linux-next failed).
Odd. I don't think I have taken the old version out of
linux-next yet. So you can probably revert the old version out of
linux-next and apply this one. All of my development at this point is
against v4.9-rc1.
I suspect you will find my last version on top of against v4.9-rc1 will
pass. Since my tree is only one deep and I don't think anyone except
linux-next is based on it, I plan to drop and readd this patch.
Especially since it is candidate for backporting.
Eric
next prev parent reply other threads:[~2016-10-28 2:24 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-10-24 10:59 [ISSUE] mm: Add a user_ns owner to mm_struct and fix ptrace_may_access Cyrill Gorcunov
2016-10-24 19:00 ` Andrey Vagin
2016-10-24 19:01 ` Eric W. Biederman
2016-10-24 20:29 ` Cyrill Gorcunov
2016-10-24 21:32 ` Kees Cook
2016-10-24 23:11 ` Eric W. Biederman
2016-10-25 9:02 ` Cyrill Gorcunov
2016-10-27 15:54 ` [REVIEW][PATCH v2] mm: Add a user_ns owner to mm_struct and fix ptrace permission checks Eric W. Biederman
2016-10-27 21:27 ` Kees Cook
2016-10-27 21:39 ` Cyrill Gorcunov
2016-10-27 22:34 ` Cyrill Gorcunov
2016-10-28 2:22 ` Eric W. Biederman [this message]
2016-10-28 4:45 ` Eric W. Biederman
2016-10-28 7:06 ` Cyrill Gorcunov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760odnrf5.fsf@xmission.com \
--to=ebiederm@xmission.com \
--cc=avagin@virtuozzo.com \
--cc=containers@lists.linux-foundation.org \
--cc=gorcunov@gmail.com \
--cc=jann@thejh.net \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=xemul@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome