From: ebiederm@xmission.com (Eric W. Biederman)
To: Nikolay Borisov <kernel@kyup.com>
Cc: "J. Bruce Fields" <bfields@fieldses.org>,
Pavel Emelyanov <xemul@virtuozzo.com>,
Jeff Layton <jlayton@poochiereds.net>,
Andrey Vagin <avagin@openvz.org>,
containers@lists.linux-foundation.org,
linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org,
viro@zeniv.linux.org.uk
Subject: Re: [PATCH v2] locks: Filter /proc/locks output on proc pid ns
Date: Wed, 03 Aug 2016 12:35:39 -0500 [thread overview]
Message-ID: <8760rhiwlw.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <57A2097C.7060206@kyup.com> (Nikolay Borisov's message of "Wed, 3 Aug 2016 18:10:52 +0300")
Nikolay Borisov <kernel@kyup.com> writes:
> On 08/03/2016 06:06 PM, J. Bruce Fields wrote:
>> Digging around... Oh, I see, there's an optional 'lock:..' line in
>> /proc/[pid]/fdinfo/[pid] file, is that what you're looking at? I'd
>> forgotten. Yeah, maybe that would make more sense long term.
>
> Yep, that's the one but this requires the userspace to be updated to use
> that interface. In the meantime we could do away with some maintenance
> of the existing /proc/locks :)
I am tempted to say let's not change /proc/locks at all, but if locks
really are in a pid namespace than I do think it makes sense to filter
them in /proc just so there is not excessive visiblity outside of the
pid namespace.
Excessive visibility is a problem on it's own.
Eric
prev parent reply other threads:[~2016-08-03 17:48 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-08-02 14:42 [RFC PATCH] locks: Show only file_locks created in the same pidns as current process Nikolay Borisov
2016-08-02 14:45 ` Nikolay Borisov
2016-08-02 15:05 ` J. Bruce Fields
2016-08-02 15:20 ` Nikolay Borisov
2016-08-02 15:43 ` J. Bruce Fields
2016-08-02 16:00 ` Eric W. Biederman
2016-08-02 17:40 ` J. Bruce Fields
2016-08-02 19:09 ` Eric W. Biederman
2016-08-02 19:44 ` J. Bruce Fields
2016-08-02 20:01 ` Jeff Layton
2016-08-02 20:11 ` Nikolay Borisov
2016-08-02 20:34 ` J. Bruce Fields
2016-08-03 7:35 ` [PATCH v2] locks: Filter /proc/locks output on proc pid ns Nikolay Borisov
2016-08-03 13:46 ` Jeff Layton
2016-08-03 14:17 ` Nikolay Borisov
2016-08-03 14:28 ` J. Bruce Fields
2016-08-03 14:33 ` Nikolay Borisov
2016-08-03 14:54 ` Pavel Emelyanov
2016-08-03 15:00 ` Nikolay Borisov
2016-08-03 15:06 ` J. Bruce Fields
2016-08-03 15:10 ` Nikolay Borisov
2016-08-03 17:35 ` Eric W. Biederman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8760rhiwlw.fsf@x220.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=avagin@openvz.org \
--cc=bfields@fieldses.org \
--cc=containers@lists.linux-foundation.org \
--cc=jlayton@poochiereds.net \
--cc=kernel@kyup.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
--cc=xemul@virtuozzo.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®