From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754186AbbHHHic (ORCPT ); Sat, 8 Aug 2015 03:38:32 -0400 Received: from smtp05.smtpout.orange.fr ([80.12.242.127]:39433 "EHLO smtp.smtpout.orange.fr" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752274AbbHHHib (ORCPT ); Sat, 8 Aug 2015 03:38:31 -0400 X-ME-Helo: belgarion X-ME-Auth: amFyem1pay5yb2JlcnRAb3JhbmdlLmZy X-ME-Date: Sat, 08 Aug 2015 09:38:29 +0200 X-ME-IP: 90.38.169.142 From: Robert Jarzmik To: Stephen Boyd Cc: Michael Turquette , linux-clk@vger.kernel.org, linux-kernel@vger.kernel.org, Ezequiel Garcia Subject: Re: [PATCH v2] clk: pxa: pxa3xx: fix CKEN register access References: <1438669293-6033-1-git-send-email-robert.jarzmik@free.fr> <20150807235515.GF16477@codeaurora.org> X-URL: http://belgarath.falguerolles.org/ Date: Sat, 08 Aug 2015 09:34:44 +0200 In-Reply-To: <20150807235515.GF16477@codeaurora.org> (Stephen Boyd's message of "Fri, 7 Aug 2015 16:55:15 -0700") Message-ID: <87614qkzcb.fsf@belgarion.home> User-Agent: Gnus/5.130008 (Ma Gnus v0.8) Emacs/24.4 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Stephen Boyd writes: > On 08/04, Robert Jarzmik wrote: >> Clocks 0 to 31 are on CKENA, and not CKENB. The clock register names >> were inadequately inverted. As a consequence, all clock operations were >> happening on CKENB, because almost all but 2 clocks are on CKENA. >> >> As the clocks were activated by the bootloader in the former tests, it >> escaped the testing that the wrong clock gate was manipulated. The error >> was revealed by changing the pxa3xx-and driver to a module, where tupon >> unloading the wrong clock was disabled in CKENB. >> >> Fixes: 9bbb8a338fb2 ("clk: pxa: add pxa3xx clock driver") >> Signed-off-by: Robert Jarzmik >> --- > > Applied to clk-fixes. Sorry, got busy last few days. Thanks Stephen ! Cheers. -- Robert