From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752697AbbCXKbG (ORCPT ); Tue, 24 Mar 2015 06:31:06 -0400 Received: from out03.mta.xmission.com ([166.70.13.233]:38742 "EHLO out03.mta.xmission.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752292AbbCXKbD (ORCPT ); Tue, 24 Mar 2015 06:31:03 -0400 From: ebiederm@xmission.com (Eric W. Biederman) To: Ingo Molnar Cc: Masami Hiramatsu , Baoquan He , =?utf-8?B?SGF0YXlhbWEsIERhaXN1a2Uv55WR5bGxIOWkp+i8lA==?= , Vivek Goyal , hidehiro.kawai.ez@hitachi.com, linux-kernel@vger.kernel.org, kexec@lists.infradead.org, akpm@linux-foundation.org, mingo@redhat.com, bp@suse.de References: <54F9D645.2050008@jp.fujitsu.com> <20150323034752.GD2068@dhcp-16-105.nay.redhat.com> <20150323071943.GA22765@gmail.com> <5510DA42.6040708@hitachi.com> <20150324071129.GA28619@gmail.com> Date: Tue, 24 Mar 2015 05:27:10 -0500 In-Reply-To: <20150324071129.GA28619@gmail.com> (Ingo Molnar's message of "Tue, 24 Mar 2015 08:11:29 +0100") Message-ID: <87619qzo5d.fsf@x220.int.ebiederm.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-XM-AID: U2FsdGVkX18pZtmVv3sO89+abunLi+W/ehwYucOsi24= X-SA-Exim-Connect-IP: 70.59.163.10 X-SA-Exim-Mail-From: ebiederm@xmission.com X-Spam-Report: * -1.0 ALL_TRUSTED Passed through trusted hosts only via SMTP * 0.0 TVD_RCVD_IP Message was received from an IP address * 0.5 XMGappySubj_01 Very gappy subject * 0.7 XMSubLong Long Subject * 0.0 T_TM2_M_HEADER_IN_MSG BODY: No description available. * 0.8 BAYES_50 BODY: Bayes spam probability is 40 to 60% * [score: 0.5000] * -0.0 DCC_CHECK_NEGATIVE Not listed in DCC * [sa04 1397; Body=1 Fuz1=1 Fuz2=1] * 0.0 T_TooManySym_01 4+ unique symbols in subject X-Spam-DCC: XMission; sa04 1397; Body=1 Fuz1=1 Fuz2=1 X-Spam-Combo: *;Ingo Molnar X-Spam-Relay-Country: X-Spam-Timing: total 690 ms - load_scoreonly_sql: 0.05 (0.0%), signal_user_changed: 8 (1.1%), b_tie_ro: 6 (0.8%), parse: 1.26 (0.2%), extract_message_metadata: 15 (2.1%), get_uri_detail_list: 1.67 (0.2%), tests_pri_-1000: 4.7 (0.7%), tests_pri_-950: 0.98 (0.1%), tests_pri_-900: 0.82 (0.1%), tests_pri_-400: 18 (2.6%), check_bayes: 17 (2.4%), b_tokenize: 4.0 (0.6%), b_tok_get_all: 6 (0.8%), b_comp_prob: 1.71 (0.2%), b_tok_touch_all: 2.8 (0.4%), b_finish: 0.66 (0.1%), tests_pri_0: 635 (92.0%), tests_pri_500: 3.4 (0.5%), rewrite_mail: 0.00 (0.0%) Subject: Re: [PATCH v2] kernel/panic/kexec: fix "crash_kexec_post_notifiers" option issue in oops path X-Spam-Flag: No X-SA-Exim-Version: 4.2.1 (built Wed, 24 Sep 2014 11:00:52 -0600) X-SA-Exim-Scanned: Yes (on in02.mta.xmission.com) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Ingo Molnar writes: > * Masami Hiramatsu wrote: > >> > >> > f06e5153f4ae ("kernel/panic.c: add "crash_kexec_post_notifiers" option for kdump after panic_notifers") >> > >> > Was that crash_kexec() was called unconditionally after notifiers were >> > called, which should be fixed via the simple patch below (untested). >> > Looks much simpler than your fix. >> >> No, Daisuke's patch is not for that case. [...] > > Yet the actual bug is in that commit, 'crash_kexec_post_notifiers' was > clearly not a no-op in the default case, against expectations. > > So the first step should be to restore the original behavior (my > patch), then should any new tweaks be added. Honestly I think the proper fix is to simply revert f06e5153f4ae. It was clearly not properly tested by the people who wanted it because they came back quite a while later with additional bleh. I think this pretty much counts as hitting the code doesn't work let's remove it threshold. Eric