From: ebiederm@xmission.com (Eric W. Biederman)
To: Shuah Khan <shuahkh@osg.samsung.com>
Cc: akpm@linux-foundation.org, gregkh@linuxfoundation.org,
colin.king@canonical.com, dbueso@suse.de,
serge.hallyn@ubuntu.com, thierry@linux.vnet.ibm.com,
luto@amacapital.net, linux-api@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/7] selftests/mount: change test to use ksft framework
Date: Tue, 23 Sep 2014 16:07:28 -0700 [thread overview]
Message-ID: <8761geylzj.fsf@x220.int.ebiederm.org> (raw)
In-Reply-To: <5421FA8A.9050209@osg.samsung.com> (Shuah Khan's message of "Tue, 23 Sep 2014 16:56:10 -0600")
Shuah Khan <shuahkh@osg.samsung.com> writes:
> On 09/23/2014 04:41 PM, Eric W. Biederman wrote:
>> Shuah Khan <shuahkh@osg.samsung.com> writes:
>>
>>> Change mount test to use kselftest framework to report
>>> test results.
>>
>> Nacked-by: "Eric W. Biederman" <ebiederm@xmission.com>
>>
>> I am curious did you even run these tests? I can't possibly see how
>> the tests would have passed with this change. At the very least you
>> have taken this test from linear to exponential time complexity.
>>
>
> Oops. I meant to drop this commit from the series. Sorry for the
> noise.
No problem. Except for the unnecessary semantic change the rest of the
change looked fine. I just wanted to make certain you didn't break my
test by accident.
Eric
next prev parent reply other threads:[~2014-09-23 23:07 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-09-23 21:32 [PATCH v2 0/7] kselftest framework and test changes to use it Shuah Khan
2014-09-23 21:32 ` [PATCH v2 1/7] selftests: add kselftest framework for uniform test reporting Shuah Khan
2014-09-24 8:09 ` Davidlohr Bueso
2014-09-24 22:06 ` Shuah Khan
2014-09-23 21:32 ` [PATCH v2 2/7] selftests/breakpoints: change test to use ksft framework Shuah Khan
2014-09-23 21:32 ` [PATCH v2 3/7] selftests/ipc: " Shuah Khan
2014-09-23 21:32 ` [PATCH v2 4/7] selftests/kcmp: " Shuah Khan
2014-09-23 21:32 ` [PATCH v2 5/7] selftests/mount: " Shuah Khan
2014-09-23 22:41 ` Eric W. Biederman
2014-09-23 22:56 ` Shuah Khan
2014-09-23 23:07 ` Eric W. Biederman [this message]
2014-09-23 23:18 ` Shuah Khan
2014-09-23 21:32 ` [PATCH v2 6/7] selftests/ptrace: " Shuah Khan
2014-09-23 21:33 ` [PATCH v2 7/7] selftests/timers: " Shuah Khan
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8761geylzj.fsf@x220.int.ebiederm.org \
--to=ebiederm@xmission.com \
--cc=akpm@linux-foundation.org \
--cc=colin.king@canonical.com \
--cc=dbueso@suse.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-api@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=luto@amacapital.net \
--cc=serge.hallyn@ubuntu.com \
--cc=shuahkh@osg.samsung.com \
--cc=thierry@linux.vnet.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome