From: OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
To: Mikulas Patocka <mpatocka@redhat.com>
Cc: linux-kernel@vger.kernel.org
Subject: Re: [PATCH] deadlock when swapping to FAT
Date: Fri, 20 Mar 2009 07:27:00 +0900 [thread overview]
Message-ID: <8763i5xi6j.fsf@devron.myhome.or.jp> (raw)
In-Reply-To: <Pine.LNX.4.64.0903191052180.14051@hs20-bc2-1.build.redhat.com> (Mikulas Patocka's message of "Thu, 19 Mar 2009 15:34:00 -0400 (EDT)")
Mikulas Patocka <mpatocka@redhat.com> writes:
> It should prevent truncation under bmap. It is used by direct-io code to
> protect the file from being truncated while there's direct-io being
> processed on it.
I know, FAT is ok, of course, and the simple fs would also be ok.
However, it's not enough for all filesystems, in theory.
> But some filesystems do their own direct-io locking (for example XFS). So
> I think it would be best to place the lock to generic_block_bmap, so that
> filesystem that doesn't want the lock can easily avoid it.
>
> You can submit this patch after 2.6.29 is released.
I don't have objection to it. Please submit it yourself.
--
OGAWA Hirofumi <hirofumi@mail.parknet.co.jp>
prev parent reply other threads:[~2009-03-19 22:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-03-12 12:30 Mikulas Patocka
2009-03-12 16:05 ` OGAWA Hirofumi
2009-03-15 1:54 ` Mikulas Patocka
2009-03-15 3:22 ` OGAWA Hirofumi
2009-03-17 12:23 ` Mikulas Patocka
2009-03-17 16:08 ` OGAWA Hirofumi
2009-03-19 19:34 ` Mikulas Patocka
2009-03-19 22:27 ` OGAWA Hirofumi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8763i5xi6j.fsf@devron.myhome.or.jp \
--to=hirofumi@mail.parknet.co.jp \
--cc=linux-kernel@vger.kernel.org \
--cc=mpatocka@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®