From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753436AbdEVHzz (ORCPT ); Mon, 22 May 2017 03:55:55 -0400 Received: from pegasos-out.vodafone.de ([80.84.1.38]:50598 "EHLO pegasos-out.vodafone.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752975AbdEVHzx (ORCPT ); Mon, 22 May 2017 03:55:53 -0400 X-Spam-Flag: NO X-Spam-Score: 0.2 Authentication-Results: rohrpostix2.prod.vfnet.de (amavisd-new); dkim=pass header.i=@vodafone.de X-DKIM: OpenDKIM Filter v2.6.8 pegasos-out.vodafone.de DB7886A0367 Subject: Re: [PATCH] drm/amd: include instead of "linux/delay.h" To: =?UTF-8?Q?Christian_K=c3=b6nig?= , Masahiro Yamada , dri-devel@lists.freedesktop.org, Daniel Vetter , Alex Deucher , =?UTF-8?Q?Michel_D=c3=a4nzer?= , linux-kernel@vger.kernel.org, amd-gfx@lists.freedesktop.org References: <1495082612-10385-1-git-send-email-yamada.masahiro@socionext.com> <20170522073914.vn62nglzaoy3ijrf@phenom.ffwll.local> From: =?UTF-8?Q?Christian_K=c3=b6nig?= Message-ID: <876aa0ab-e536-79a9-db89-f23b2292bcaa@vodafone.de> Date: Mon, 22 May 2017 09:55:46 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.1.1 MIME-Version: 1.0 In-Reply-To: <20170522073914.vn62nglzaoy3ijrf@phenom.ffwll.local> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 22.05.2017 um 09:39 schrieb Daniel Vetter: > On Thu, May 18, 2017 at 08:47:34AM +0200, Christian König wrote: >> Am 18.05.2017 um 06:43 schrieb Masahiro Yamada: >>> Use <...> notation to include headers located in include/linux. >>> While we are here, tweak the includes order a bit to sort them >>> alphabetically. >>> >>> Signed-off-by: Masahiro Yamada >> Reviewed-by: Christian König > I think I'll leave this one for Alex, but I guess I can pick it up into > drm-misc too if that's simpler ... All the other include patches are in > there already. Please pick that up for drm-misc. Alex is on vacation this week and I already have all hands full replacing him. Christian. > -Daniel >>> --- >>> >>> drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c | 4 ++-- >>> drivers/gpu/drm/amd/powerplay/hwmgr/pp_acpi.c | 2 +- >>> drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c | 4 ++-- >>> drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c | 5 +++-- >>> drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c | 8 +++++--- >>> drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c | 5 +++-- >>> 6 files changed, 16 insertions(+), 12 deletions(-) >>> >>> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c >>> index ff4ae3d..963a9e0 100644 >>> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c >>> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/hwmgr.c >>> @@ -22,10 +22,10 @@ >>> */ >>> #include "pp_debug.h" >>> -#include "linux/delay.h" >>> -#include >>> +#include >>> #include >>> #include >>> +#include >>> #include >>> #include "cgs_common.h" >>> #include "power_state.h" >>> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/pp_acpi.c b/drivers/gpu/drm/amd/powerplay/hwmgr/pp_acpi.c >>> index f5e8fda..f6b4dd9 100644 >>> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/pp_acpi.c >>> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/pp_acpi.c >>> @@ -21,8 +21,8 @@ >>> * >>> */ >>> +#include >>> #include >>> -#include "linux/delay.h" >>> #include "hwmgr.h" >>> #include "amd_acpi.h" >>> #include "pp_acpi.h" >>> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c >>> index 8f663ab..581374d 100644 >>> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c >>> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/smu7_hwmgr.c >>> @@ -21,11 +21,11 @@ >>> * >>> */ >>> #include "pp_debug.h" >>> +#include >>> +#include >>> #include >>> #include >>> -#include >>> #include >>> -#include "linux/delay.h" >>> #include "pp_acpi.h" >>> #include "ppatomctrl.h" >>> #include "atombios.h" >>> diff --git a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c >>> index 8394955..f4ab81b 100644 >>> --- a/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c >>> +++ b/drivers/gpu/drm/amd/powerplay/hwmgr/vega10_hwmgr.c >>> @@ -20,10 +20,11 @@ >>> * OTHER DEALINGS IN THE SOFTWARE. >>> * >>> */ >>> + >>> +#include >>> +#include >>> #include >>> #include >>> -#include >>> -#include "linux/delay.h" >>> #include "hwmgr.h" >>> #include "amd_powerplay.h" >>> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c >>> index 1f6744a..39c7091 100644 >>> --- a/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c >>> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/cz_smumgr.c >>> @@ -20,11 +20,13 @@ >>> * OTHER DEALINGS IN THE SOFTWARE. >>> * >>> */ >>> -#include >>> + >>> +#include >>> +#include >>> #include >>> #include >>> -#include >>> -#include "linux/delay.h" >>> +#include >>> + >>> #include "cgs_common.h" >>> #include "smu/smu_8_0_d.h" >>> #include "smu/smu_8_0_sh_mask.h" >>> diff --git a/drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c b/drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c >>> index c0d7576..2e954a4 100644 >>> --- a/drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c >>> +++ b/drivers/gpu/drm/amd/powerplay/smumgr/smumgr.c >>> @@ -20,15 +20,16 @@ >>> * OTHER DEALINGS IN THE SOFTWARE. >>> * >>> */ >>> -#include >>> + >>> +#include >>> #include >>> #include >>> #include >>> +#include >>> #include >>> #include "pp_instance.h" >>> #include "smumgr.h" >>> #include "cgs_common.h" >>> -#include "linux/delay.h" >>> MODULE_FIRMWARE("amdgpu/topaz_smc.bin"); >>> MODULE_FIRMWARE("amdgpu/topaz_k_smc.bin"); >> >> _______________________________________________ >> dri-devel mailing list >> dri-devel@lists.freedesktop.org >> https://lists.freedesktop.org/mailman/listinfo/dri-devel