From: Dou Liyang <dou_liyang@163.com>
To: Christoph Hellwig <hch@lst.de>, Thomas Gleixner <tglx@linutronix.de>
Cc: Kashyap Desai <kashyap.desai@broadcom.com>,
Ming Lei <tom.leiming@gmail.com>,
Sumit Saxena <sumit.saxena@broadcom.com>,
Ming Lei <ming.lei@redhat.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Shivasharan Srikanteshwara
<shivasharan.srikanteshwara@broadcom.com>,
linux-block <linux-block@vger.kernel.org>,
Dou Liyang <douly.fnst@cn.fujitsu.com>
Subject: Re: Affinity managed interrupts vs non-managed interrupts
Date: Tue, 11 Sep 2018 17:38:19 +0800 [thread overview]
Message-ID: <876cd3e2-7519-eab9-7da6-2a672256365e@163.com> (raw)
In-Reply-To: <20180911091354.GA9898@lst.de>
Hi,
At 09/11/2018 05:13 PM, Christoph Hellwig wrote:
> On Thu, Sep 06, 2018 at 01:46:46PM +0200, Thomas Gleixner wrote:
>>
>> I think the right solution for these pre/post vectors is to _NOT_ mark
>> them managed and leave them as regular interrupts which can be affinity
>> controlled and also can move freely on hotplug.
>
> Yes, agreed. Marking the pre/post vector as managed was a mistake
> (and I don't think it even was intentional, at least on my part).
>
Got it !
And, I am trying to fix this by:
-Don't set affinity for pre/post vectors in
irq_create_affinity_masks().
-And do not setup the desc->affinity of pre/post vectors in
alloc_msi_entry().
So, the affinity in alloc_descs() will be NULL, and the interrupt won't
be marked as IRQD_AFFINITY_MANAGED.
Is it OK? and I will show the codes after testing it.
Thanks,
dou
next prev parent reply other threads:[~2018-09-11 9:38 UTC|newest]
Thread overview: 28+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <eccc46e12890a1d033d9003837012502@mail.gmail.com>
2018-08-29 8:46 ` Ming Lei
2018-08-29 10:46 ` Sumit Saxena
2018-08-30 17:15 ` Kashyap Desai
2018-08-31 6:54 ` Ming Lei
2018-08-31 7:50 ` Kashyap Desai
2018-08-31 20:24 ` Thomas Gleixner
2018-08-31 21:49 ` Kashyap Desai
2018-08-31 22:48 ` Thomas Gleixner
2018-08-31 23:37 ` Kashyap Desai
2018-09-02 12:02 ` Thomas Gleixner
2018-09-03 5:34 ` Kashyap Desai
2018-09-03 16:28 ` Thomas Gleixner
2018-09-04 10:29 ` Kashyap Desai
2018-09-05 5:46 ` Dou Liyang
2018-09-05 9:45 ` Kashyap Desai
2018-09-05 10:38 ` Thomas Gleixner
2018-09-06 10:14 ` Dou Liyang
2018-09-06 11:46 ` Thomas Gleixner
2018-09-11 9:13 ` Christoph Hellwig
2018-09-11 9:38 ` Dou Liyang [this message]
2018-09-11 9:22 ` Christoph Hellwig
2018-09-03 2:13 ` Ming Lei
2018-09-03 6:10 ` Kashyap Desai
2018-09-03 9:21 ` Ming Lei
2018-09-03 9:50 ` Kashyap Desai
2018-09-11 9:21 ` Christoph Hellwig
2018-09-11 9:54 ` Kashyap Desai
2018-08-28 6:47 Sumit Saxena
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=876cd3e2-7519-eab9-7da6-2a672256365e@163.com \
--to=dou_liyang@163.com \
--cc=douly.fnst@cn.fujitsu.com \
--cc=hch@lst.de \
--cc=kashyap.desai@broadcom.com \
--cc=linux-block@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.lei@redhat.com \
--cc=shivasharan.srikanteshwara@broadcom.com \
--cc=sumit.saxena@broadcom.com \
--cc=tglx@linutronix.de \
--cc=tom.leiming@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
Powered by JetHome