From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.8 required=3.0 tests=HEADER_FROM_DIFFERENT_DOMAINS, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB119C64EB8 for ; Tue, 9 Oct 2018 15:11:11 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 8EA2B214C4 for ; Tue, 9 Oct 2018 15:11:11 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8EA2B214C4 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=none smtp.mailfrom=linux-kernel-owner@vger.kernel.org Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726600AbeJIW2c (ORCPT ); Tue, 9 Oct 2018 18:28:32 -0400 Received: from foss.arm.com ([217.140.101.70]:40142 "EHLO foss.arm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726393AbeJIW2b (ORCPT ); Tue, 9 Oct 2018 18:28:31 -0400 Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.72.51.249]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id F3E2280D; Tue, 9 Oct 2018 08:11:08 -0700 (PDT) Received: from [10.1.196.62] (usa-sjc-imap-foss1.foss.arm.com [10.72.51.249]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id DC0723F5D3; Tue, 9 Oct 2018 08:11:06 -0700 (PDT) Subject: Re: [PATCH V11 1/8] irqchip: add C-SKY SMP interrupt controller To: Guo Ren , tglx@linutronix.de, jason@lakedaemon.net, robh+dt@kernel.org, mark.rutland@arm.com, daniel.lezcano@linaro.org, will.deacon@arm.com, jhogan@kernel.org, paul.burton@mips.com, peterz@infradead.org, arnd@arndb.de Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org References: <83d216b3fed039037ebe8b8513f3c51a36934e74.1539095312.git.ren_guo@c-sky.com> From: Marc Zyngier Organization: ARM Ltd Message-ID: <8772c090-a139-04e4-a55f-820afe1bb5bd@arm.com> Date: Tue, 9 Oct 2018 16:11:05 +0100 User-Agent: Mozilla/5.0 (X11; Linux aarch64; rv:52.0) Gecko/20100101 Thunderbird/52.9.1 MIME-Version: 1.0 In-Reply-To: <83d216b3fed039037ebe8b8513f3c51a36934e74.1539095312.git.ren_guo@c-sky.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-GB Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 09/10/18 15:41, Guo Ren wrote: > - Irq-csky-mpintc is C-SKY smp system interrupt controller and it > could support 16 soft irqs, 16 private irqs, and 992 max common > irqs. > > Changelog: > - Convert the cpumask to an interrupt-controller specific representation > in driver's code, and not the SMP code's. > - pass checkpatch.pl > - Move IPI_IRQ into the driver > - Remove irq_set_default_host() and use set_ipi_irq_mapping() > - Change name with upstream feed-back > - Change irq map, reserve soft_irq & private_irq space > - Add License and Copyright > - Support set_affinity for irq balance in SMP > > Signed-off-by: Guo Ren > Cc: Marc Zyngier [...] > +/* C-SKY multi processor interrupt controller */ > +static int __init > +csky_mpintc_init(struct device_node *node, struct device_node *parent) > +{ > + unsigned int cpu, nr_irq; > + int ret; > + > + if (parent) > + return 0; > + > + ret = of_property_read_u32(node, "csky,num-irqs", &nr_irq); > + if (ret < 0) > + nr_irq = INTC_IRQS; > + > + if (INTCG_base == NULL) { > + INTCG_base = ioremap(mfcr("cr<31, 14>"), > + INTCL_SIZE*nr_cpu_ids + INTCG_SIZE); > + if (INTCG_base == NULL) > + return -EIO; > + > + INTCL_base = INTCG_base + INTCG_SIZE; > + > + writel_relaxed(BIT(0), INTCG_base + INTCG_ICTLR); > + } > + > + root_domain = irq_domain_add_linear(node, nr_irq, &csky_irqdomain_ops, > + NULL); > + if (!root_domain) > + return -ENXIO; > + > + /* for every cpu */ > + for_each_present_cpu(cpu) { > + per_cpu(intcl_reg, cpu) = INTCL_base + (INTCL_SIZE * cpu); > + writel_relaxed(BIT(0), per_cpu(intcl_reg, cpu) + INTCL_PICTLR); > + } > + > + set_handle_irq(&csky_mpintc_handler); > + > +#ifdef CONFIG_SMP > + set_send_ipi(&csky_mpintc_send_ipi); > + > + set_ipi_irq_mapping(&csky_mpintc_ipi_irq_mapping); Same remark as before. You do not need this second callback, and you should redefine set_send_ipi to take an irq number: ipi_irq = irq_create_mapping(root_domain, IPI_IRQ); if (!ipi_irq) [handle error] set_send_ipi(csky_mpintc_send_ipi, ipi_irq); and you can then delete both set_ipi_irq_mapping and csky_mpintc_handler, none of which serve any purpose. In your SMP code: void __init set_send_ipi(void (*func)(const struct cpumask *), int irq) { if (send_arch_ipi) return; send_arch_ipi = func; ipi_irq = irq; } and simplify setup_smp_ipi. Thanks, M. -- Jazz is not dead. It just smells funny...