From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S933775AbcI3SxU (ORCPT ); Fri, 30 Sep 2016 14:53:20 -0400 Received: from mail-wm0-f68.google.com ([74.125.82.68]:36826 "EHLO mail-wm0-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932348AbcI3SxM (ORCPT ); Fri, 30 Sep 2016 14:53:12 -0400 Subject: Re: [PATCH 2/2] staging: vt6656: Make 'rx_rate' u8 instead of u8 * To: Dan Carpenter , Martin Alonso References: <20160927165901.GA28955@malonso-pc> <1474998769-29646-1-git-send-email-martin.alonso@zoho.com> <1474998769-29646-2-git-send-email-martin.alonso@zoho.com> <20160928074029.GA13620@mwanda> Cc: pasteka@kabsi.at, devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, forest@alittletooquiet.net, joe@perches.com From: Malcolm Priestley Message-ID: <8775808f-5a21-af7a-4e32-126d231dd681@gmail.com> Date: Fri, 30 Sep 2016 19:53:00 +0100 User-Agent: Mozilla/5.0 (X11; Linux i686; rv:45.0) Gecko/20100101 Thunderbird/45.2.0 MIME-Version: 1.0 In-Reply-To: <20160928074029.GA13620@mwanda> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 28/09/16 08:40, Dan Carpenter wrote: > On Tue, Sep 27, 2016 at 02:52:49PM -0300, Martin Alonso wrote: >> Change the type and uses of rx_rate. >> >> Signed-off-by: Martin Alonso >> --- >> drivers/staging/vt6656/dpc.c | 9 +++++---- >> 1 file changed, 5 insertions(+), 4 deletions(-) >> >> diff --git a/drivers/staging/vt6656/dpc.c b/drivers/staging/vt6656/dpc.c >> index 655f000..782b7d7 100644 >> --- a/drivers/staging/vt6656/dpc.c >> +++ b/drivers/staging/vt6656/dpc.c >> @@ -46,7 +46,8 @@ int vnt_rx_data(struct vnt_private *priv, struct vnt_rcb *ptr_rcb, >> __le64 *tsf_time; >> u32 frame_size; >> int ii, r; >> - u8 *rx_rate, *sq, *sq_3; >> + u8 rx_rate; >> + u8 *sq, *sq_3; >> u32 wbk_status; >> u8 *skb_data; >> u16 *pay_load_len; >> @@ -75,7 +76,7 @@ int vnt_rx_data(struct vnt_private *priv, struct vnt_rcb *ptr_rcb, >> >> skb_data = (u8 *)skb->data; >> >> - rx_rate = skb_data + 5; >> + rx_rate = *(skb_data + 5); > > It occurs to me that we don't check that skb->len is large enough here. > We just assume it has at least 5 bytes. > > TODO: vt6656: verify skb->len before using it. skb->len is always set to the tail room then trimmed by this function. Regards Malcolm