From: Stephen Cameron <smcameron@yahoo.com>
To: james.bottomley@hansenpartnership.com,
"Stephen M. Cameron" <scameron@beardog.cce.hp.com>
Cc: linux-scsi@vger.kernel.org, mike.miller@hp.com,
linux-kernel@vger.kernel.org, thenzl@redhat.com,
akpm@linux-foundation.org
Subject: Re: [PATCH] hpsa: do not re-order commands in internal queues
Date: Tue, 11 Jan 2011 14:52:11 -0800 (PST) [thread overview]
Message-ID: <877909.84984.qm@web33006.mail.mud.yahoo.com> (raw)
In-Reply-To: <20110111224658.24457.62925.stgit@beardog.cce.hp.com>
--- On Tue, 1/11/11, Stephen M. Cameron <scameron@beardog.cce.hp.com> wrote:
[...]
> @@ -2837,8 +2837,8 @@ static void start_io(struct ctlr_info
> *h)
> {
> struct CommandList *c;
>
> - while (!hlist_empty(&h->reqQ))
> {
> - c =
> hlist_entry(h->reqQ.first, struct CommandList, list);
> + while (!list_empty(&h->reqQ)) {
> + c =
> list_entry(h->reqQ.first, struct CommandList, list);
No, I screwed this up. Disregard this patch.
-- steve
next prev parent reply other threads:[~2011-01-11 22:58 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2011-01-11 22:46 Stephen M. Cameron
2011-01-11 22:52 ` Stephen Cameron [this message]
2011-01-11 23:01 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=877909.84984.qm@web33006.mail.mud.yahoo.com \
--to=smcameron@yahoo.com \
--cc=akpm@linux-foundation.org \
--cc=james.bottomley@hansenpartnership.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mike.miller@hp.com \
--cc=scameron@beardog.cce.hp.com \
--cc=thenzl@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox
all inboxes | Powered by JetHome®