From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C66C32B130 for ; Thu, 30 Jul 2026 08:07:18 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785398839; cv=none; b=fxboBLFtrC0hfzeKutrM5LbDl/whWMwhXqwyohGC8myBJ591NgJ4/h1OFBVVIIai1C5VWB6BAKJcHToyRoKgwroKMrDt/ZxG14LnwmpQKp9KtSSdjCsrkdbcuO2n8FNmw7waCL3bkyI2VE/y9EzboR16lmlx+k+tVig6Lq3WL/0= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1785398839; c=relaxed/simple; bh=M5RIRprLtCiMRgILjgnVC/xs67DlgOU54y4/rUGc8gI=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=cqzFNWvnQB5AZ2FSJtuChwzJyEbNVIJcDhXvvtmBURGLjA8mJ5NcYSFOwWEUMpr3Kg6G+FjaheXXtdOphxQ0hWKPJvqjbXhXTxBOL95+ZeM9e23PGltZh5W6Fxocrc+NNZz+JQBXDFQx8I4IHlsJ4jB2d76HpZFyYAMIL8YHUGM= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=Q6QzihHo; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=cLAZKWc4; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="Q6QzihHo"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="cLAZKWc4" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1785398837; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=KBck6paOE0M0Ra9bOgFPOF/il0J8O4K8s30LrHyhZdQ=; b=Q6QzihHoRINrc+IUUseJTtI4h09xe7QyhCkVO4glCxX4JkpYWR1zr83Rc7cPlaSGnGKASX Ldck2BdVv7GGF/NgL3vAxin3ik58RhkWlIET1udh2L5JqWVG/yCwCv5HEIavSpJFAMpnJ+ yb40nBVvp+8xVhPI60xvbG1oLjDA7CA= Received: from mail-wm1-f72.google.com (mail-wm1-f72.google.com [209.85.128.72]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-500-8jojjxUWNReUVeuCgefe8g-1; Thu, 30 Jul 2026 04:07:16 -0400 X-MC-Unique: 8jojjxUWNReUVeuCgefe8g-1 X-Mimecast-MFC-AGG-ID: 8jojjxUWNReUVeuCgefe8g_1785398835 Received: by mail-wm1-f72.google.com with SMTP id 5b1f17b1804b1-4954fd771baso3528915e9.0 for ; Thu, 30 Jul 2026 01:07:15 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1785398835; x=1786003635; darn=vger.kernel.org; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:from:to:cc:subject:date:message-id:reply-to :content-type; bh=KBck6paOE0M0Ra9bOgFPOF/il0J8O4K8s30LrHyhZdQ=; b=cLAZKWc4t8mjYGK14m8g+l6Uq6noz/rZPeRPqTxQ9QRlIqJvCj8LAnGKEnrDIP8izz c/97+EFUSsMQrfxYv8QqalOyWoB9TibrjIU1WGkKRxdrUQDck0i1ghx8SQxIs6dsYvj8 ANMGPHskwJ4fe9My7P1sDx/HmdWH2L0K4RdSOCsvacCD3EkYMkKCoDWe0g5sbm3vXcAn 6NeMOp3HmZJnp0kddDVsc49R/firJpWVSygDwUwqQwDM4JJDByzf1s/ygAfzY3lFIMUx 9UdkIVAHgHqMIAfIDdyUL78iB9NO6DBhBHJUD0BgXfSMBVz92zUuEXTteqs47cRG6xpn n0cA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1785398835; x=1786003635; h=content-type:mime-version:message-id:date:references:in-reply-to :subject:cc:to:from:x-gm-gg:x-gm-message-state:from:to:cc:subject :date:message-id:reply-to:content-type; bh=KBck6paOE0M0Ra9bOgFPOF/il0J8O4K8s30LrHyhZdQ=; b=UoRr0WKk90QlbUOf3ODxo8eruQM5RVrqskWax7dXePU2DHwnQuB0NXlXcFc+fdkkhh SI5N7GDI4oCOAYb5BpnpiUmmU73gxFjhi3DLiq8dMxlVxLNJ5lR0r8GRBWdmqH2IuWiq IP866MISxZK5P+0qPbTakzQV0h8Ld+A/+/ohluet1S/YEvfgr+xFL3UB4R0S/MqFBhQ6 7F8VVpkPnnsh8Ac4pzj80NpLpjWuQ96sTR7gjqJ0ETGggg+Fcg5LNA7acCXJwFCA7G5C A/z44ACfitX7ZaVY0j7kPrBbdXIwXMNSOXak3cnX+KBXs5oLUUZbqn5cexi8imrqQY4g w9wA== X-Forwarded-Encrypted: i=1; AHgh+RowBCH/i/JAHDWRZ5ih865rGwjc3QKpeSVf9SBGnrNCAejdyPqz5PLP6Fx7vsQYfa2VEpOS6FsbGMrUxVs=@vger.kernel.org X-Gm-Message-State: AOJu0YwCWnJYo//z4Ei/JancRXcXv5AsxdrmATkr3GZXLK52Eupm006+ 98reLREiBMIlXfL98j+vWBfmVCoxN66cZlConpoPtwHoHwvT4709ROySFtu1fRyttcvnIyQAOJa HqkARnLcQa6CxFeCt3Bcyp//OQBDoUCvNkEQJUNQ9piPt1ibU74nOJnfyuRhw/Hj9eQ== X-Gm-Gg: AR+sD13WpOAjRTeQ6BGyc1eJLHzn/zntnvIOaJZZHbnbQjL+BXBELttUuFU5Q45cJqw L3QBrVqorgazMznQsNuuBEqMX8dHSVFenjUDbEqhwU/MNzd7sbPpqt2W2+9WSxOizApm+BHzoTb f7zFJEB8ZTxEA39UTaiiD+HKMyyDJZXEMciIDTIrr/nlp87YNkrisgp/M8E4/AzeDE/2tKSXwxN Xyi4zP3jqx8DQNmyivi0e072jCVQrokiUgDlEbFB4BC+FvSLHS7khiUk5fUQpDb8zaNuBCRM+Yo bwv25y4vZnz9J5yL8lwYoF7uX90lLHvbPzVs0248JGp64ReRX+wnV2aAHW9JN+4giMS0Av2bR3I WUkMsgU+RVL+i8rtntffD+CCLNKDmILOtlwJcFJGDiwEsoWvazhZkoC78CCg= X-Received: by 2002:a05:600c:19d4:b0:495:5d6d:9cc1 with SMTP id 5b1f17b1804b1-49801e8992cmr15690955e9.0.1785398834628; Thu, 30 Jul 2026 01:07:14 -0700 (PDT) X-Received: by 2002:a05:600c:19d4:b0:495:5d6d:9cc1 with SMTP id 5b1f17b1804b1-49801e8992cmr15690255e9.0.1785398834081; Thu, 30 Jul 2026 01:07:14 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-498019b55cdsm20712735e9.3.2026.07.30.01.07.11 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 30 Jul 2026 01:07:12 -0700 (PDT) From: Javier Martinez Canillas To: Amit Barzilai , Maarten Lankhorst , Maxime Ripard , Thomas Zimmermann , David Airlie , Simona Vetter Cc: dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org, Amit Barzilai Subject: Re: [PATCH 2/2] drm/ssd130x: Add per-family update backlight logic In-Reply-To: <20260729053054.29374-3-amit.barzilai22@gmail.com> References: <20260729053054.29374-1-amit.barzilai22@gmail.com> <20260729053054.29374-3-amit.barzilai22@gmail.com> Date: Thu, 30 Jul 2026 10:07:11 +0200 Message-ID: <877bmcew9c.fsf@ocarina.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Amit Barzilai writes: > ssd130x_update_bl() runs for every SSD13xx panel, but it only works for > SSD130x and SSD132x: it writes the single global SSD13XX_CONTRAST (0x81) > command, which those two families expose. SSD133x has no such command -- > it has three per-channel contrast registers (CONTRAST_A/B/C) that must be > scaled together -- so ssd130x_update_bl() has no effect on it. > > Make backlight_ops.update_status a per-family choice. SSD130x and SSD132x > keep ssd130x_update_bl() because they share the SSD13XX_CONTRAST interface, > while SSD133x gets ssd133x_update_bl(), which drives the three channels > through ssd133x_set_contrast(). > > Signed-off-by: Amit Barzilai > --- Reviewed-by: Javier Martinez Canillas -- Best regards, Javier Martinez Canillas Core Platforms Red Hat