From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [170.10.133.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D80643C3786 for ; Thu, 11 Jun 2026 09:44:37 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=170.10.133.124 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781171086; cv=none; b=Kk2rtX/yHYH+hDhMv+UindhNB5WfMzYI2ioZYzbfBOprReQidA6O4VpwJeyVi72VmlqB/8kPrBZ1M9f6nuyEheQ+KXFIgv0GdpRYcXjstcn+RquoEwkd46/WSYTzlVRhSXt3gT0z3UDUpz4VNw0X5A7nfRP8a1WBOAA+5Ur8fm4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1781171086; c=relaxed/simple; bh=kzSbnEbLCy7oERIPuUeORqHSj6s6hO8tcRnNEjCA1mc=; h=From:To:Cc:Subject:In-Reply-To:References:Date:Message-ID: MIME-Version:Content-Type; b=QoFzOBoQKJrKmYfCpzhFYFs9jxUT6ZAVqDoo6b7HaOADp57OVXRBT548ihC8Rfhb/Z+dVg2+tsC5OGHToSuxIMJ43iDvisCGfVA4I6VsB+OuAJ/09Nu4U83bs6NcRPkTFV2KYwG6nkG4kyX/IgC8+EAwVXSWvlgyQLuRPrnDKQs= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com; spf=pass smtp.mailfrom=redhat.com; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b=ctnpouTD; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b=VfiwvvQN; arc=none smtp.client-ip=170.10.133.124 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=redhat.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=redhat.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (1024-bit key) header.d=redhat.com header.i=@redhat.com header.b="ctnpouTD"; dkim=pass (2048-bit key) header.d=redhat.com header.i=@redhat.com header.b="VfiwvvQN" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1781171075; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=1SIia4HOnRnNxMuugCZfZvhfm+zstNHW2PddKrs89mY=; b=ctnpouTD4SpVtLtaceUBxsvaxVk/L0kpI016u1/ArXgAz6sHbEKB4fQcXBsIS4CePsL6Pn e436ZW1bwOL+ILgDi5JCHqvg5aWlqBlIpYf2N1ticYAO4sYIYihXCtyiqiGWsQTiXunhqU JGyArJAgen0ossMXT2ee4eyQPmSNw3I= Received: from mail-wr1-f70.google.com (mail-wr1-f70.google.com [209.85.221.70]) by relay.mimecast.com with ESMTP with STARTTLS (version=TLSv1.3, cipher=TLS_AES_256_GCM_SHA384) id us-mta-98-C5xoDq_pPba_dE55JnYwDw-1; Thu, 11 Jun 2026 05:44:33 -0400 X-MC-Unique: C5xoDq_pPba_dE55JnYwDw-1 X-Mimecast-MFC-AGG-ID: C5xoDq_pPba_dE55JnYwDw_1781171073 Received: by mail-wr1-f70.google.com with SMTP id ffacd0b85a97d-460163035e3so4636383f8f.2 for ; Thu, 11 Jun 2026 02:44:33 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=google; t=1781171072; x=1781775872; darn=vger.kernel.org; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:from:to:cc:subject:date:message-id:reply-to; bh=1SIia4HOnRnNxMuugCZfZvhfm+zstNHW2PddKrs89mY=; b=VfiwvvQNKefozymr82OMe93NQigijMa79Ew1EzKITzv898BBe4pwk3b21NM8JVYiRj dRQBF/kvuKqfou1nQwuNBpWnvFcW0IfxQad75RaMsvzjmm/5vMuTHhawL9RwjMODo1A7 UpbeI0F4QFPeLtb5HKUm52wFz1suUpBF1Gc4WLkz9ojCZOArowCTAigzUpWxZHUUVrp1 21Etc+Db0aJvgQom/ngpkKU3BVE08mPiTMGrGPKzqcRZTFnzpHAI6M2gBjjw4JA+Wwxd NnUNzB5d5Q19sal3Wshj/q5yeYf60HBT5vEpkBV9qrLzsV9PwWiBGwfIebq+yMpSanD6 pctg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1781171072; x=1781775872; h=mime-version:message-id:date:references:in-reply-to:subject:cc:to :from:x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=1SIia4HOnRnNxMuugCZfZvhfm+zstNHW2PddKrs89mY=; b=FFoE33z41MFf5MSED4AhNVxzvcljj+ANd4xAxI8eYWgcq+zsmHs38khAzsXRa3nWl/ ss6d8FktD4NKuy0QAHeTc6jGmIH1eP/9ExlplJv4PhjYx2lDZiLyqJvxT5FmUEvSuEKi dNK2rmzwjECYhzFVN9WjXctK1uc6+aa1D3X/tN+ggkJIvSpRNvlF6XInT+QbU/4GGUQf 3cbthINjN1tnedCuJWqJ6zM0v1BdeOCI1WtduiQmXXQkxWcmIpezfnaPlaSj75Wqv0c4 lK09m5qSythKBiFt94jpldydPblFAN+Xqe8RuvUjKvVDyCNLcFZmMSsDkVOtG+0y30Bw VkNA== X-Forwarded-Encrypted: i=1; AFNElJ9R/z2DLdixxkGNGdFY6Y4ldbHH19AhU/7daNpX/rsFKTNVIXuCniRHZxbH1LluTFDLWYTC1CYoJ+TWPG4=@vger.kernel.org X-Gm-Message-State: AOJu0Yz1ZAry7NJAdQ8wy/5VNgESa/umk8Rhr5SiJmveeQ3QaUp5Z4c6 Eh58mqhSgJa22kah7DrxZojd8tVfbmG0My6iacX/zRWYjeFXoE+YRst9vsGCPLR9e4f+mET1/1o VmhNayHc/wTC71JPldZxGKFzxgaFwb5ROW0vlBcTnz5ArN/gc9PmEmFoeKfY9mjW13w== X-Gm-Gg: Acq92OE6B+lInX7b82D2+oFr5CRj+oyuUvX00UKqAUv0FpHWgXFKTyV0N9m3/NiJ+yW dNVkcDPkcXbK2QTQ3I8pIPuDPaL6wdE8TLj7BIuiRIv+SsMiHF+8PC+cpJ3FVkZ5G6bxb2Ydme8 9jdNTvx4LkmIQKCCKyFr3pFrTZOtwhc1+v2WLWNuSospa1N6GBIKaXNeVVgcA1lh8kX++K+nKCe 9XEQwTdCR0iZREPn992Ko6BdPw0i7l6lhorWKgNWRQwMOroGijjpYGONq++Ei2+tmYacNvP8Rk/ w11KsfAzB0mh9D74ejFSfH5/SjBegL6B/T0BwWZ2PCyctRHKdmSU5+OGonHljv4zPUwOECCW1oc xnAvo1Gp7ZGhophaTxK1TDy3HXcZ8tT18w2fKJlOeNqUbEcfrCXA6riOEV6y1B5vR3c+ZmFZi3P gedB3gi4tBW/Bl9sY= X-Received: by 2002:a05:6000:461e:b0:460:662d:e686 with SMTP id ffacd0b85a97d-46067599390mr3308753f8f.13.1781171072695; Thu, 11 Jun 2026 02:44:32 -0700 (PDT) X-Received: by 2002:a05:6000:461e:b0:460:662d:e686 with SMTP id ffacd0b85a97d-46067599390mr3308709f8f.13.1781171072292; Thu, 11 Jun 2026 02:44:32 -0700 (PDT) Received: from localhost (62-151-111-63.jazzfree.ya.com. [62.151.111.63]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-4601f2ed944sm82178555f8f.13.2026.06.11.02.44.31 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 11 Jun 2026 02:44:31 -0700 (PDT) From: Javier Martinez Canillas To: Amit Barzilai , maarten.lankhorst@linux.intel.com, mripard@kernel.org, tzimmermann@suse.de, airlied@gmail.com, simona@ffwll.ch Cc: robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Amit Barzilai Subject: Re: [PATCH 0/2] drm: Add driver for the Solomon SSD1351 OLED controller In-Reply-To: <20260610164428.180091-1-amit.barzilai22@gmail.com> References: <20260610164428.180091-1-amit.barzilai22@gmail.com> Date: Thu, 11 Jun 2026 11:44:30 +0200 Message-ID: <877bo576o1.fsf@ocarina.mail-host-address-is-not-set> Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain Amit Barzilai writes: Hello Amit, Thanks for your patches. > This series adds a new DRM/KMS driver for the Solomon SSD1351, a 128x128 > 65k-color RGB OLED controller driven over a 4-wire SPI bus. The SSD1351 > currently has no DRM driver; the only in-tree support is the legacy fbtft > fb_ssd1351. > > The driver advertises XRGB8888 to userspace and converts to big-endian > RGB565 on flush via drm_fb_xrgb8888_to_rgb565be(), building on the GEM > SHMEM and atomic modeset/shadow-plane helpers with damage-clipped partial > updates. > > The SSD1351 is implemented as a standalone driver rather than as part of > ssd130x. ssd130x converts XRGB8888 down to a packed <= 8bpp hardware > format (mono, grayscale, or 256-colour RGB332); the SSD1351 is driven in > its native 65k-colour RGB565 and does not fit that pixel pipeline. > I think that makes more sense to have the SSD1351 support as a part of the ssd130x driver, rather than as a separate one. There is already support for SSD133X in ssd130x and this family also supports the same 65k format than used by SSD1351. The correct approach in my opinion to add SSD1351 support is as follows: 1) Add support for 65k (DRM_FORMAT_RGB565) for the SSD133X_FAMILY. 2) Add support for the SSD135X_FAMILY with DRM_FORMAT_RGB565. 3) Optionally add support for the 256k color format to SSD135X_FAMILY but I don't think there's a native fourcc code for this. So likely you will need to do a XRGB8888 to native 256k format conversion. By doing this way, not only SSD1351 will be supported by ssd130x but also you could make the existing SSD133X support to use the 65k color depth. -- Best regards, Javier Martinez Canillas Core Platforms Red Hat